linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] arm64: dts: imx8mp: move noc node to correct position
@ 2023-05-16  5:50 Alexander Stein
  2023-05-16  7:13 ` Marek Vasut
  2023-05-27  8:39 ` Shawn Guo
  0 siblings, 2 replies; 5+ messages in thread
From: Alexander Stein @ 2023-05-16  5:50 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Marek Vasut, Fabio Estevam
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
	devicetree, linux-arm-kernel

The base address of NOC is bigger than aips5, but smaller than aips4.

Fixes: b86c3afabb4f ("arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
This patch is to actually move aips5 before noc, but the diff for moving
noc is smaller, so that's why it is this way around.

 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 40 +++++++++++------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 005527ea6934..39aef5fbf77b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1176,26 +1176,6 @@ eqos: ethernet@30bf0000 {
 			};
 		};
 
-		noc: interconnect@32700000 {
-			compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc";
-			reg = <0x32700000 0x100000>;
-			clocks = <&clk IMX8MP_CLK_NOC>;
-			#interconnect-cells = <1>;
-			operating-points-v2 = <&noc_opp_table>;
-
-			noc_opp_table: opp-table {
-				compatible = "operating-points-v2";
-
-				opp-200000000 {
-					opp-hz = /bits/ 64 <200000000>;
-				};
-
-				opp-1000000000 {
-					opp-hz = /bits/ 64 <1000000000>;
-				};
-			};
-		};
-
 		aips5: bus@30c00000 {
 			compatible = "fsl,aips-bus", "simple-bus";
 			reg = <0x30c00000 0x400000>;
@@ -1347,6 +1327,26 @@ audio_blk_ctrl: clock-controller@30e20000 {
 			};
 		};
 
+		noc: interconnect@32700000 {
+			compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc";
+			reg = <0x32700000 0x100000>;
+			clocks = <&clk IMX8MP_CLK_NOC>;
+			#interconnect-cells = <1>;
+			operating-points-v2 = <&noc_opp_table>;
+
+			noc_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-200000000 {
+					opp-hz = /bits/ 64 <200000000>;
+				};
+
+				opp-1000000000 {
+					opp-hz = /bits/ 64 <1000000000>;
+				};
+			};
+		};
+
 		aips4: bus@32c00000 {
 			compatible = "fsl,aips-bus", "simple-bus";
 			reg = <0x32c00000 0x400000>;
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm64: dts: imx8mp: move noc node to correct position
  2023-05-16  5:50 [PATCH 1/1] arm64: dts: imx8mp: move noc node to correct position Alexander Stein
@ 2023-05-16  7:13 ` Marek Vasut
  2023-05-16  7:32   ` Krzysztof Kozlowski
  2023-05-27  8:39 ` Shawn Guo
  1 sibling, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2023-05-16  7:13 UTC (permalink / raw)
  To: Alexander Stein, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Shawn Guo, Sascha Hauer, Fabio Estevam
  Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
	linux-arm-kernel

On 5/16/23 07:50, Alexander Stein wrote:
> The base address of NOC is bigger than aips5, but smaller than aips4.
> 
> Fixes: b86c3afabb4f ("arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX")

I don't mind this Fixes tag, since this will likely land in the same 
upcoming release anyway.

But in general, is this really Fixes: material ?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm64: dts: imx8mp: move noc node to correct position
  2023-05-16  7:13 ` Marek Vasut
@ 2023-05-16  7:32   ` Krzysztof Kozlowski
  2023-05-16  7:55     ` Alexander Stein
  0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-16  7:32 UTC (permalink / raw)
  To: Marek Vasut, Alexander Stein, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam
  Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
	linux-arm-kernel

On 16/05/2023 09:13, Marek Vasut wrote:
> On 5/16/23 07:50, Alexander Stein wrote:
>> The base address of NOC is bigger than aips5, but smaller than aips4.
>>
>> Fixes: b86c3afabb4f ("arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX")
> 
> I don't mind this Fixes tag, since this will likely land in the same 
> upcoming release anyway.
> 
> But in general, is this really Fixes: material ?

Order of nodes in DTS is not a bug...

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm64: dts: imx8mp: move noc node to correct position
  2023-05-16  7:32   ` Krzysztof Kozlowski
@ 2023-05-16  7:55     ` Alexander Stein
  0 siblings, 0 replies; 5+ messages in thread
From: Alexander Stein @ 2023-05-16  7:55 UTC (permalink / raw)
  To: Marek Vasut, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Shawn Guo, Sascha Hauer, Fabio Estevam, Krzysztof Kozlowski
  Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
	linux-arm-kernel

Am Dienstag, 16. Mai 2023, 09:32:31 CEST schrieb Krzysztof Kozlowski:
> On 16/05/2023 09:13, Marek Vasut wrote:
> > On 5/16/23 07:50, Alexander Stein wrote:
> >> The base address of NOC is bigger than aips5, but smaller than aips4.
> >> 
> >> Fixes: b86c3afabb4f ("arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX")
> > 
> > I don't mind this Fixes tag, since this will likely land in the same
> > upcoming release anyway.
> > 
> > But in general, is this really Fixes: material ?
> 
> Order of nodes in DTS is not a bug...
> 
> Best regards,
> Krzysztof

Okay, fine for me. Want me to resend?

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm64: dts: imx8mp: move noc node to correct position
  2023-05-16  5:50 [PATCH 1/1] arm64: dts: imx8mp: move noc node to correct position Alexander Stein
  2023-05-16  7:13 ` Marek Vasut
@ 2023-05-27  8:39 ` Shawn Guo
  1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2023-05-27  8:39 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
	Marek Vasut, Fabio Estevam, Pengutronix Kernel Team,
	NXP Linux Team, devicetree, linux-arm-kernel

On Tue, May 16, 2023 at 07:50:06AM +0200, Alexander Stein wrote:
> The base address of NOC is bigger than aips5, but smaller than aips4.
> 
> Fixes: b86c3afabb4f ("arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Applied with Fixes tag dropped.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-05-27  8:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16  5:50 [PATCH 1/1] arm64: dts: imx8mp: move noc node to correct position Alexander Stein
2023-05-16  7:13 ` Marek Vasut
2023-05-16  7:32   ` Krzysztof Kozlowski
2023-05-16  7:55     ` Alexander Stein
2023-05-27  8:39 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).