From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28F4BC77B73 for ; Sat, 27 May 2023 13:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qZMxuGGj68tGwDEHLqch3QF3Be18+4BnICFaYjGvF3I=; b=YFZsUZhy9kZmNc x52znFepaLuaYs8d1wzNd4BzEHDiiZQqKtWJTChIq6DGqbPPUvtIX9kLU8USIZMHnLh1fUY36Vpy4 3CXivGD85JDr3ofqu6JJP8VM3hhkVNVvQzjWLNZsePIMq6x5m+Hpju9zWYTjoTpJVHf838HepGZ6O XC20beHX20wJcW2cD9P3Cn4s832ovJZHOHnm3FSzu/C982ZjaBOYRN7bT/ECb/beafenp3vWUp+Eb Qv3efnA62A9xZUx4LCt3dSDxKj1sdmBwBezpx1Z2Tg9zYc7IJ1Ml59auLFYpKffZOFZEKsbtXp7ZM V1iDYd7C61mbBsDXNELg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2trw-005nSO-3D; Sat, 27 May 2023 13:22:05 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2trt-005nRu-2D for linux-arm-kernel@lists.infradead.org; Sat, 27 May 2023 13:22:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 433C560BB1; Sat, 27 May 2023 13:22:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8233C433D2; Sat, 27 May 2023 13:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685193720; bh=PzjEt2/h0CjY0WOMNH3YjbhNNTjlWbDN5hX9cNubPHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O0SwLySGnNOhn2Y0lSKqrlRuS9SHuObCdg6BxMAsdmJDay+GzGgObr42vXYvZ5r7v Oiklt2+Rhhm7oeLvlq+i1V4fHxrY59dXG56UQZDeEwKzBCeGcBREM8ep0MQjP8rmKm K9mtfGlH0ahDpWcBF4mC3w+ZZ3FhM39w52nwpszbMxMzDOD9ckYnizV2ydT7xG/jul vOMf9LckBOa9ieC1mq9bGO5aHavYhOlG1Xv2pNr0NSxvR+CJtl5Rq3YhO3oJRVj9Hi wsvo2a65OM3rnmO80XhRxfDU7w42XjZAzRWvfqfNEuIig+p4h6zUjDvjgt0xfCiQdi Wty34T0cfJU5Q== Date: Sat, 27 May 2023 21:21:49 +0800 From: Shawn Guo To: Luca Ceresoli Cc: devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: imx8mp-msc-sm2s: Add sound card Message-ID: <20230527132149.GD560301@dragon> References: <20230525104755.286282-1-luca.ceresoli@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230525104755.286282-1-luca.ceresoli@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230527_062201_803615_62161FF3 X-CRM114-Status: GOOD ( 21.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 25, 2023 at 12:47:55PM +0200, Luca Ceresoli wrote: > The MSC SM2-MB-EP1 carrier board for the SM2S-IMX8PLUS SMARC module has an > NXP SGTL5000 audio codec connected to I2S-0 (sai2). > > This requires to: > > * add the power supplies (always on) > * enable sai2 with pinmuxes > * reparent the CLKOUT1 clock that feeds the codec SYS_MCLK to > IMX8MP_CLK_24M in order it to generate an accurate 24 MHz rate > > Signed-off-by: Luca Ceresoli > > --- > > Changed in v2: > > - switch to simple-audio-card > - fix typo in commit message > - no underscores in node names > - rename "sgtl5000-sound" node to "sound" > --- > .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > index 470ff8e31e32..cd651e1e3262 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > @@ -14,6 +14,67 @@ / { > compatible = "avnet,sm2s-imx8mp-14N0600E-ep1", > "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", > "fsl,imx8mp"; > + > + reg_vcc_3v3_audio: 3v3-audio-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "VCC_3V3_AUD"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + reg_vcc_1v8_audio: 1v8-audio-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "VCC_1V8_AUD"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + sound { > + compatible = "simple-audio-card"; > + simple-audio-card,name = "sgtl5000-audio"; > + simple-audio-card,format = "i2s"; > + simple-audio-card,frame-master = <&codec_dai>; > + simple-audio-card,bitclock-master = <&codec_dai>; > + > + simple-audio-card,cpu { > + sound-dai = <&sai2>; > + }; > + > + codec_dai: simple-audio-card,codec { > + sound-dai = <&sgtl5000>; > + }; > + }; > +}; > + > +&i2c1 { > + sgtl5000: sgtl5000@a { audio-codec for node name. Shawn > + compatible = "fsl,sgtl5000"; > + reg = <0x0a>; > + > + assigned-clocks = <&clk IMX8MP_CLK_CLKOUT1_SEL>; > + assigned-clock-parents = <&clk IMX8MP_CLK_24M>; > + assigned-clock-rates = <24000000>; > + clocks = <&clk IMX8MP_CLK_CLKOUT1>; > + clock-names = "mclk"; > + #sound-dai-cells = <0>; > + > + VDDA-supply = <®_vcc_3v3_audio>; > + VDDD-supply = <®_vcc_1v8_audio>; > + VDDIO-supply = <®_vcc_1v8_audio>; > + }; > +}; > + > +/* I2S-0 = sai2 */ > +&sai2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sai2>; > + > + assigned-clocks = <&clk IMX8MP_CLK_SAI2>; > + assigned-clock-parents = <&clk IMX8MP_AUDIO_PLL1_OUT>; > + assigned-clock-rates = <12288000>; > + > + fsl,sai-mclk-direction-output; > + status = "okay"; > }; > > &flexcan1 { > @@ -32,6 +93,15 @@ &iomuxc { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_smarc_gpio>; > > + pinctrl_sai2: sai2grp { > + fsl,pins = < > + MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC 0xd6 > + MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK 0xd6 > + MX8MP_IOMUXC_SAI2_RXD0__AUDIOMIX_SAI2_RX_DATA00 0xd6 > + MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00 0xd6 > + >; > + }; > + > pinctrl_smarc_gpio: smarcgpiosgrp { > fsl,pins = > , /* GPIO0 */ > > base-commit: efdde75fee54667153a5fa236907b55452fddbfa > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel