From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50150C77B7E for ; Sun, 28 May 2023 13:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TBweaQI0y415JxXIBpfE5EW2n3V3JWjKpSru6T5vp/w=; b=Nil6BC5DdzsKPg Y2ZNrkiboCY6C2/4SD0Y9yH4h+Y/S4E+9CbZKmX3sVInQVjYgDx9JSnkr4t45ndcKwHlOXr6NQWSh ZHinxwF5bT8AaAzHH0rU7dcDEiq3C3am8PpEYaAU+ukvrWwp1lKscoQzuh1J4lEJp6v3wwOC+ISHY H41RFSiaD6UJFQHzLJjgivpBkcUsS/XLCOh6j1AHtWdVZlcBhHoFlEiNeg6Dtxaey5XErQ2xvDEM8 BVWzUaWmY4VKNmIcUcdYQ+cH97MVbToqnICsqwh4uLvoTdiB5exZHISWpisKMn4+qBu+AXydFbIRY b7WUbB0eh7HXStFtdYKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3GsT-007kQp-0X; Sun, 28 May 2023 13:56:09 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3GsQ-007kQS-2N for linux-arm-kernel@lists.infradead.org; Sun, 28 May 2023 13:56:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 006D060B07; Sun, 28 May 2023 13:56:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD66EC433D2; Sun, 28 May 2023 13:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685282165; bh=OoZPC1V1hYUWEPl5vfYB+Zu55Xna3a+gVyr1lVOG01E=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=wgWVmXL9JVkXhkERB8AHu7gZIz4/SC6Cd9GvHnQBtdwTxTo8laghhoiL5iVFDHY3g YIWmU8jbia/wnIJN4Z5vSid1X9Z8prPA2B14S35Q3BhJAdTylyAx9hLp4qyOlWKQj6 quA1BrNAkOX95gV/9QGf0zwSJkxxV8GXrEQsQLEo= Date: Sun, 28 May 2023 12:46:25 +0100 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: soc@kernel.org, Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 10/13] ARM: pxa: fix missing-prototypes warnings Message-ID: <2023052815-skinning-mantis-2cee@gregkh> References: <20230516153109.514251-1-arnd@kernel.org> <20230516153109.514251-11-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230516153109.514251-11-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230528_065606_880369_9692BCA9 X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 16, 2023 at 05:31:06PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The PXA platform has a number of configurations that end up with > a warning like these when building with W=1: > > drivers/hwmon/max1111.c:83:5: error: no previous prototype for 'max1111_read_channel' [-Werror=missing-prototypes] > arch/arm/mach-pxa/reset.c:86:6: error: no previous prototype for 'pxa_restart' [-Werror=missing-prototypes] > arch/arm/mach-pxa/mfp-pxa2xx.c:254:5: error: no previous prototype for 'keypad_set_wake' [-Werror=missing-prototypes] > drivers/clk/pxa/clk-pxa25x.c:70:14: error: no previous prototype for 'pxa25x_get_clk_frequency_khz' [-Werror=missing-prototypes] > drivers/clk/pxa/clk-pxa25x.c:325:12: error: no previous prototype for 'pxa25x_clocks_init' [-Werror=missing-prototypes] > drivers/clk/pxa/clk-pxa27x.c:74:14: error: no previous prototype for 'pxa27x_get_clk_frequency_khz' [-Werror=missing-prototypes] > drivers/clk/pxa/clk-pxa27x.c:102:6: error: no previous prototype for 'pxa27x_is_ppll_disabled' [-Werror=missing-prototypes] > drivers/clk/pxa/clk-pxa27x.c:470:12: error: no previous prototype for 'pxa27x_clocks_init' [-Werror=missing-prototypes] > arch/arm/mach-pxa/pxa27x.c:44:6: error: no previous prototype for 'pxa27x_clear_otgph' [-Werror=missing-prototypes] > arch/arm/mach-pxa/pxa27x.c:58:6: error: no previous prototype for 'pxa27x_configure_ac97reset' [-Werror=missing-prototypes] > arch/arm/mach-pxa/spitz_pm.c:170:15: error: no previous prototype for 'spitzpm_read_devdata' [-Werror=missing-prototypes] > > The problem is that there is a declaration for each of these, but > it's only seen by the caller and not the callee. Moving these > into appropriate header files ensures that both use the same > calling conventions and it avoids the warnings. > > Signed-off-by: Arnd Bergmann Acked-by: Greg Kroah-Hartman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel