From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54FAFC77B7E for ; Sun, 28 May 2023 14:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=63R8DF7NJu7ZfKkULkJSwddimoA66KAtAqzf9W0JyYE=; b=F47ci8uwuXVM88 6hyH9JLWwuoeJ4uj47gL48Rf+DdgkvMlwMHmEXH3BupIfD5hrkKqGHjQZPbu69XP33hwUa/+hegdF cefLeVcTwHl0+bhIT2QIDfM+gX5OtN4rFYShy2R+ZChUgfDqMoQMgB0ZsL1nIU+UuuxUlb4lop53C uh58LLo0GBHhfvJk1ae5O7skn1nvRdZglP4gRQPE1XZo3UNVdagXYmRMlbGEPfs6QS2eGlyN9brBb D1WGcWpaKY4aWt2IDqSIiJLP/sy4lmLeJID0dw4aqj8CMy1mpCDVLJ/mMSnljz/SKhB0I3JCL571a iL033MMxkLVe1FmW3dSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3Hp3-007rpv-2s; Sun, 28 May 2023 14:56:41 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3Hp0-007rop-30; Sun, 28 May 2023 14:56:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 994A660D3A; Sun, 28 May 2023 14:56:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8421C433D2; Sun, 28 May 2023 14:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685285797; bh=dYRUdw6cd80d3tuK/aTvNjJCPgSv66gl3Tan1xRID+Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ozKYerTIdU290Z5Ru5InZuObVJvZ7SRayUrYO6E1jm9GIjlKx3UL9+UkVSR2HwPkT PV2nBCOF0IxrDlwqVWNPBRFsmHFVbpBo5jt+zl46YKbuaxCkA+hcnzAZJ/BJMgZNEZ /iyhprd7ImIz+xH69Up6SKvCtRjuMo447Mz8DZmvpfr9DEIzJfzOBruUkXUNSGjFnC aR9+7VzVF2F6VE1PBRHddvYZmCXoszln5131uQjS4D0AfAsVDw0FMygMpsU2tEU4uA gMlndYp1VsE//TbFheeT+c7/cT52tKYKwcYVLld5bpe1dSCAUbbsmxnAdpwLropBic beBWU9vY3JUfQ== Date: Sun, 28 May 2023 16:12:55 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: George Stark , lars@metafoo.de, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, kernel@sberdevices.ru Subject: Re: [PATCH v2] meson saradc: add iio device attrib to switch channel 7 mux Message-ID: <20230528161255.216fee6f@jic23-huawei> In-Reply-To: References: <20230527214854.126517-1-gnstark@sberdevices.ru> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230528_075639_015989_C372FB48 X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 28 May 2023 13:55:20 +0300 Andy Shevchenko wrote: > On Sun, May 28, 2023 at 01:46:37PM +0300, Andy Shevchenko wrote: > > On Sun, May 28, 2023 at 12:48:54AM +0300, George Stark wrote: > > ... > > > > +static const char * const chan7_vol[] = { > > > + "gnd", > > > + "vdd/4", > > > + "vdd/2", > > > + "vdd*3/4", > > > + "vdd", > > > + "ch7_input", > > > +}; > > One more thing to discuss (Jonathan, what's your opinion?) I think the > following easier to understand and has less problematic characters in the names > (in case of sysfs direct use from shelll): I suspect no one would use these particulary inputs directly from the shell, but agreed that avoiding / where not absolutely necessary is a good idea. Jonathan > > static const char * const chan7_vol[] = { > "gnd", // alternatively GND > "0.25vdd", // alternatively 0.25_vdd, 0.25Vdd, 0.25_Vdd > "0.5vdd", > "0.75vdd", > "vdd", // Vdd > "ch7_input", > }; > > That said, my personal preference: > > static const char * const chan7_vol[] = { > "GND", > "0.25Vdd", > "0.5Vdd", > "0.75Vdd", > "Vdd", > "ch7_input", > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel