From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7486C77B7C for ; Sun, 28 May 2023 15:12:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bYl3hzgc1ZN4I1PKy3eu3XKLHozP0yPnZukD2GWgyH8=; b=AQLN10Z2bljkCO Spn1sQtuI7RS2AFMiH0VWBw9++Ljd6WbyDS0k4TVGPR3nx7bP1iKYNYg0TrOBfo1xa/OJ56E+Lafr jImJX01mslWxEXkAP5Y6pDFxRHXoFNnVAIJJ5I16Uo/RLsY9k3Wu7mA0Ezw97HIHpUMvjPZ5fX/gt XWSUpGG3rXAn2oorssbR3nDhSMDUSvUUks0NcioHExqZRJKRrsWAPETRjMmFZgjS9bRbYE2ob43Xa EyeqbUlbiFK4AmorYDZGcsM4UbqKMT2BGgFTHWQtMtnxe66DZ5GDw9fVP/UFRC1ploSvu3bSlO3co /ZN1Y+cnlnJFF9ObXrDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3I3w-007vQ1-09; Sun, 28 May 2023 15:12:04 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3I3s-007vOq-1a; Sun, 28 May 2023 15:12:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD3D360DFE; Sun, 28 May 2023 15:11:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FAE9C433EF; Sun, 28 May 2023 15:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685286719; bh=ARvEO23dasH18+5jDJHBo7KTOvsMfUCav6bqynj3MxM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Qd2gPvwOncZlWRSsTAihexqmUAaBRd4Fr+aDYrucvyakAr9S88rLgH4czuFrGk421 ikl5iyFfKrv1JNNrdtyDgCCr691/7PoMWQm3ryDK3eGWYWvxZXow93Hacy7wrScnz2 7TR5w7ZJFUnjAQrKfD/lP4Zt8+dXyAEJ0c7pGgbaj09VhoIBDKJLaKJ8AERjX0TwRM 32/YraaCelspQHyF/iBDCi+NYoo5p29Kwyg6LOcukYv7KXHVSj76ePAa0aoqqoa/4o CoQsEgCMCXR1TMuvHRbOP2NENPf/Boj4uxXpGAW/raUZQy9Gerb3qouMGyDjo3xi4c VSwfC4CtVhu7g== Date: Sun, 28 May 2023 16:28:13 +0100 From: Jonathan Cameron To: Maxim Kiselev Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Andre Przywara , Heiko Stuebner , Andy Shevchenko , Cosmin Tanislav , Miquel Raynal , Alexander Sverdlin , Ramona Bolboaca , William Breathitt Gray , ChiYuan Huang , Ibrahim Tilki , Caleb Connolly , Arnd Bergmann , Mike Looijmans , ChiaEn Wu , Haibo Chen , Hugo Villeneuve , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [RFC PATCH v1 2/4] dt-bindings: iio: adc: Add Allwinner D1/T113s/R329 SoCs GPADC Message-ID: <20230528162813.6a7263e5@jic23-huawei> In-Reply-To: <20230524082744.3215427-3-bigunclemax@gmail.com> References: <20230524082744.3215427-1-bigunclemax@gmail.com> <20230524082744.3215427-3-bigunclemax@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230528_081200_610870_D95FE160 X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 24 May 2023 11:27:31 +0300 Maxim Kiselev wrote: > Allwinner's D1, T113s and R329 SoCs have a new general purpose ADC. > This ADC is the same for all of this SoCs. The only difference is > the number of available channels. > > Signed-off-by: Maxim Kiselev > --- > .../iio/adc/allwinner,sun20i-d1-gpadc.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml > new file mode 100644 > index 000000000000..a79b874750dd > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/allwinner,sun20i-d1-gpadc.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/allwinner,sun20i-d1-gpadc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner D1 General Purpose ADC > + > +properties: > + "#io-channel-cells": > + const: 0 That's odd for a device with more than one channel. How do you reference which channel you want to consume? > + > + clocks: > + maxItems: 1 > + > + compatible: > + enum: > + - allwinner,sun20i-d1-gpadc > + - allwinner,sun8i-t113-gpadc > + - allwinner,sun50i-r329-gpadc > + > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > +required: > + - "#io-channel-cells" > + - clocks > + - compatible > + - interrupts > + - reg > + - resets > + > +additionalProperties: false > + > +examples: > + - | > + gpadc: adc@2009000 { > + compatible = "allwinner,sun20i-d1-gpadc"; > + reg = <0x2009000 0x1000>; > + clocks = <&ccu CLK_BUS_GPADC>; > + resets = <&ccu RST_BUS_GPADC>; > + interrupts = ; I guess the bot probably got this, but to use these macros you need some includes. > + #io-channel-cells = <0>; > + }; > + > +... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel