Re: [PATCH v2 1/4] ARM: dts: at91: sama7g5: keep only microchip,sam9x60-pit64b compatible for pit64b

Conor Dooley
2023-05-29T12:13:53Z

[-- Attachment #1.1: Type: text/plain, Size: 1485 bytes --]

Hey Claudiu,

On Mon, May 29, 2023 at 09:26:01AM +0300, Claudiu Beznea wrote:
> SAM9X60 and SAMA7G5 PIT64Bs are 1 to 1 compatible. Thus, there is no
> need for specific compatible string on SAMA7G5.

Generally, soc-specific compatibles are something that we want people to
add, not remove!

Cheers,
Conor.

>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> arch/arm/boot/dts/sama7g5.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
> index 886b6209a71e..500b00508621 100644
> --- a/arch/arm/boot/dts/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/sama7g5.dtsi
> @@ -610,7 +610,7 @@ eic: interrupt-controller@e1628000 {
> };
>
> pit64b0: timer@e1800000 {
> - compatible = "microchip,sama7g5-pit64b", "microchip,sam9x60-pit64b";
> + compatible = "microchip,sam9x60-pit64b";
> reg = <0xe1800000 0x4000>;
> interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 70>, <&pmc PMC_TYPE_GCK 70>;
> @@ -618,7 +618,7 @@ pit64b0: timer@e1800000 {
> };
>
> pit64b1: timer@e1804000 {
> - compatible = "microchip,sama7g5-pit64b", "microchip,sam9x60-pit64b";
> + compatible = "microchip,sam9x60-pit64b";
> reg = <0xe1804000 0x4000>;
> interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 71>, <&pmc PMC_TYPE_GCK 71>;
> --
> 2.34.1
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]