From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3317C77B7A for ; Mon, 29 May 2023 18:05:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ePMQj7Diz49QfOHDvLpocT4ArL5oqk2ZZRomp0A/src=; b=XpNJ4+EDRzfnUUzSE+EBSP5BCH obwggFUpi5qTBn4KIa65YHbu03QWhzo/sSlj4X5NYaA5KrJN+MaZbgc03Wv9M1kT8QXyrRqWnLWVb Jo0sW0dgCxo5aDYHsoz1EOAkWFa5G3m9slrqfCMZgc8sUTKwKrHUAJekN2qUoXHYKP+XRGO6lDe+J ywpaHiFKupNVeQWtz3uROnlhDZbwV6Lo7Vd7jsbZ39a0DqVLHcDtyvI/Eik79GR5ZEur3N35BdI33 A56+9fNkJTaA27Cqek4vneJnC0XQjHM8Ns8B5GZ9tATQgXi04ZEvnbsTJKhvbY2vmXwqlAjfLtU/N fMqO5pWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3hEp-00BMrE-0a; Mon, 29 May 2023 18:04:59 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3hEm-00BMqm-1z for linux-arm-kernel@lists.infradead.org; Mon, 29 May 2023 18:04:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0EA7460B65; Mon, 29 May 2023 18:04:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C8BFC433EF; Mon, 29 May 2023 18:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685383495; bh=kKXl/E6gk/dFtNN1CB6T+UUUTzz3mIITm1Zk1GG7tus=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=JCQgSoo18UhGLXd+xiwAkYtVwqA5NX24O+I56aRUT5icZAE5vL5S/4z00fLLFRESd xmtuIEJUP9PBZwTuI+0IsPSpVoeCFbmYxsSqpYoivPprpeq17qBZhZKeoDsCKXvx6q vrj86t4tv50hcneL/qFbXMo1sBwqFaaMbvxLew+f5mFewlqU00He2X2s0NIkIkhEvp 3SWgdCV2BCk8KzTf2KSoj9z0cjHx9bIAHhvtqHua6hDm6AwaaczsLdhVXz1DuFVVlO 0CYy7Jx5yXRQScPNqHScGXKUPGkuVi2+2MK7Skx+uV9vWUlZN5necuhifV5TLgjf8o wNL20SZiI6Y7A== Date: Mon, 29 May 2023 19:04:50 +0100 From: Conor Dooley To: Alexandre Torgue Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Conor Dooley , Linus Walleij , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 02/11] pinctrl: stm32: add stm32mp257 pinctrl support Message-ID: <20230529-enrich-clammy-14b498baf09f@spud> References: <20230529162034.20481-1-alexandre.torgue@foss.st.com> <20230529162034.20481-3-alexandre.torgue@foss.st.com> MIME-Version: 1.0 In-Reply-To: <20230529162034.20481-3-alexandre.torgue@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230529_110456_698119_571CB6A6 X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6911546164954979417==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6911546164954979417== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t41OrSZBzQnUEuSq" Content-Disposition: inline --t41OrSZBzQnUEuSq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 29, 2023 at 06:20:25PM +0200, Alexandre Torgue wrote: > Add stm32mp257 pinctrl support. > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.h b/drivers/pinctrl/stm32/pinctrl-stm32.h > index e0c31c4c8bca..5e5de92ddd58 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32.h > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.h > @@ -24,6 +24,9 @@ > #define STM32MP_PKG_AB BIT(1) > #define STM32MP_PKG_AC BIT(2) > #define STM32MP_PKG_AD BIT(3) > +#define STM32MP_PKG_AI BIT(8) > +#define STM32MP_PKG_AK BIT(10) > +#define STM32MP_PKG_AL BIT(11) Mainly out of curiosity, why have you go duplicate defines for these? Cheers, Conor. --t41OrSZBzQnUEuSq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZHTpQQAKCRB4tDGHoIJi 0prAAP4kVP4W0utKn8JZzGkGIrQ25LkCdWPdC3VDNVom01MAdQEA5+piPAcHUvh6 DL7szeSe5AxTep3AtCjEfp4OSJa+PQQ= =2SPj -----END PGP SIGNATURE----- --t41OrSZBzQnUEuSq-- --===============6911546164954979417== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6911546164954979417==--