From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9580C77B7E for ; Mon, 29 May 2023 12:49:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9ecweLmCzewqnRMKInXiRBXqI79b2x5OVhBgCp6uY+g=; b=OmSzrZwW4Xnir3k8bUDm+glxQC T/TSo5Teg6FPu+wtmDHGveYd2cMQtoTsQtYNCAeknBr/mldiUY7hTMRpTSBkbS3nfLbStRdkwJNOj Q1AMdPTpAvWZI0sKxL/7nhODGaACp3wjkMKHEqYGko9R1WvO0LIa3GwVMZS5Pn3uUsBEw4Yh4zC9T JKFDdG/7TUcTPKJFXtzLLM4MHZOYgY/WWunCiji4pG6fQHtFETMj7zOadKdR3uEF7Q7k0I3C6Gba8 Sl19lHl+y8VgxkF+E5TMGFWkuN8h3NqoytxZOk5jhW/sJrESeq9kmgLTQ85ZbfXIZKksISD0ylY92 sTYbpn/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3cJ8-00AUEq-1N; Mon, 29 May 2023 12:49:06 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3cJ4-00AUDr-3A for linux-arm-kernel@lists.infradead.org; Mon, 29 May 2023 12:49:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1685364542; x=1716900542; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sihrqxGXOegLfJu5K0vAKoVsedsMzHotWvqPkMnnUEw=; b=XSaWV2L8ftWOamiRZ1rYz7fkE3Ri43qXnwxisxBrVISwPValuzO7+nSj kGg6hQpLfO1lTTb/Zx4JnVJIfi27hW53qVq1pklfsX3ZhChW89imlWtD0 jukBwp7GRpw9iag6eHhAZP0LmFCQg0xivfihH2zGe6T9Opi8IdBOjP0u6 r5Bdb75Sjt5XQw61WxcZ4WKMBPeiMkhdosGiIMlpAlC14q9H0xW1I1ttX f7TN8jVyf1yEuNkEKgqjfc/Jy3MVf90RqSA2IL0VRgOk8oHQ9d+JrOQUD x4VJISQPcnULD1OIL3sR5MLrUVTDohofxHi15r5xNVxkVyAFndteYUTQP w==; X-IronPort-AV: E=Sophos;i="6.00,201,1681196400"; d="asc'?scan'208";a="154432424" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 29 May 2023 05:49:01 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 29 May 2023 05:49:01 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 29 May 2023 05:48:58 -0700 Date: Mon, 29 May 2023 13:48:36 +0100 From: Conor Dooley To: Subject: Re: [PATCH v2 2/4] dt-bindings: timer: atmel,at91sam9260-pit: convert to yaml Message-ID: <20230529-schematic-abrasion-a06a29481ace@wendy> References: <20230529062604.1498052-1-claudiu.beznea@microchip.com> <20230529062604.1498052-3-claudiu.beznea@microchip.com> <20230529-chuck-turbofan-a8aabbdd9341@wendy> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230529_054903_103083_AD8A3574 X-CRM114-Status: GOOD ( 17.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, conor+dt@kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski+dt@linaro.org, tglx@linutronix.de, wim@linux-watchdog.org, linux@roeck-us.net Content-Type: multipart/mixed; boundary="===============5215722945289948096==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5215722945289948096== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QnBF0FcDx3VBpqKu" Content-Disposition: inline --QnBF0FcDx3VBpqKu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 29, 2023 at 12:32:49PM +0000, Claudiu.Beznea@microchip.com wrot= e: > On 29.05.2023 15:17, Conor Dooley wrote: > > On Mon, May 29, 2023 at 09:26:02AM +0300, Claudiu Beznea wrote: > >> + interrupts: > >> + description: > >> + Contain interrupt for the PIT which is the IRQ line share= d across all > >> + System Controller members. > >=20 > > I think you should drop this & the corresponding section below, since > > both PIT and PIT64 have a single interrupt. >=20 > OK. Just wanted to emphasize with this that in case of PIT the interrupt > may be shared with other IPs. Hmm. Perhaps for the other patch, keep the description then, and for this one remove the description from the else branch & add explain what "all system controller members" actually means here? It probably made sense in the txt binding, but "system controller" has lost its context here. Maybe something like: "Shared interrupt between the PIT and other functions of the system controller, for example, the watchdog, trumpet and airhorn"? Cheers, Conor. > >> + clocks: > >> + maxItems: 1 > >> + > >> + else: > >> + properties: > >> + interrupts: > >> + description: > >> + PIT64B peripheral interrupt identifier. > >> + clocks: > >> + minItems: 2 > >> + clock-names: > >> + items: > >> + - const: pclk > >> + - const: gclk > >> + required: > >> + - clock-names > >=20 >=20 --QnBF0FcDx3VBpqKu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZHSfIwAKCRB4tDGHoIJi 0jihAP9RPI9uRTfWz1IZRSiam+UQ+nEDIQA6miPvid++71X53gD/WqPNahZzotuJ FT+ZEVVKizduAnFCebdolxza7JIw6Ac= =16Ml -----END PGP SIGNATURE----- --QnBF0FcDx3VBpqKu-- --===============5215722945289948096== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5215722945289948096==--