Re: [PATCH v2 2/4] dt-bindings: timer: atmel,at91sam9260-pit: convert to yaml

Conor Dooley
2023-05-29T12:49:34Z

[-- Attachment #1.1: Type: text/plain, Size: 1546 bytes --]

On Mon, May 29, 2023 at 12:32:49PM +0000, Claudiu.Beznea@microchip.com wrote:
> On 29.05.2023 15:17, Conor Dooley wrote:
> > On Mon, May 29, 2023 at 09:26:02AM +0300, Claudiu Beznea wrote:
> >> + interrupts:
> >> + description:
> >> + Contain interrupt for the PIT which is the IRQ line shared across all
> >> + System Controller members.
> >
> > I think you should drop this & the corresponding section below, since
> > both PIT and PIT64 have a single interrupt.
>
> OK. Just wanted to emphasize with this that in case of PIT the interrupt
> may be shared with other IPs.

Hmm. Perhaps for the other patch, keep the description then, and for this
one remove the description from the else branch & add explain what "all
system controller members" actually means here? It probably made sense in
the txt binding, but "system controller" has lost its context here.
Maybe something like:
"Shared interrupt between the PIT and other functions of the system
controller, for example, the watchdog, trumpet and airhorn"?

Cheers,
Conor.

> >> + clocks:
> >> + maxItems: 1
> >> +
> >> + else:
> >> + properties:
> >> + interrupts:
> >> + description:
> >> + PIT64B peripheral interrupt identifier.
> >> + clocks:
> >> + minItems: 2
> >> + clock-names:
> >> + items:
> >> + - const: pclk
> >> + - const: gclk
> >> + required:
> >> + - clock-names
> >
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]