From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20866C7EE2E for ; Tue, 30 May 2023 08:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:CC:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6NOLa16XuiEL9lfGsxpwaWyrR9BdY3k83i5Wn924QFM=; b=wDyrL1hG1hUmUL7V6bThQn0iPy liuinsooW6vRU2Zf1PgvSctwMPJXv1UHB7zT1VMFK/l01OER/fsyfK81EtxnOB3h3JpvD9HfAwusw QOF7k5suNogTa+BCwDficaGhRRCqsGOXJDXFg/G9IrLh41cgeAcGYH/wQQzpdHMnUXSB97t8yMMQT cv8XQez09fDb3Y363LqXXRYcTjaQghxjJNBg9/H0qlWSnIKUaFuUoTfEtdxNx2jNL05B4mJ/euWB8 3tXODUtjV0cE32AZh49ds2rnB7PQFGPbtp9y8CLB5JCbBYx/maEtVCehe6Z6xEoWimRZD4y2EA5+M SBELoXUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3v9o-00D378-0o; Tue, 30 May 2023 08:56:44 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3v9k-00D34q-1S for linux-arm-kernel@lists.infradead.org; Tue, 30 May 2023 08:56:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1685437000; x=1716973000; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TwJucBXBGUN+OLdeFJgi+mcuaAx9YZFO5Ndm7y/BYEo=; b=Q/qIsFZTEOSo792y58jEjuflXxIfxNLk0uMCNmrubwDPrFWo7nkN84mT QaCaZyR8KyS7eSVxRdgqW0zEjAT1WlQET3uLl5oz01fmwKRYQa4QoS46E AD0H+lpHDg6BjpfRRm4KLExM8KVpjYULWpMAH8ZaFcyO22oy/igAtlEhJ iS7+PjmIw3e4APROec4omVI8G7FWSe4OqFiyzXlSYAShgWxWVmTApKc/d 4iZ30zbXegt8CyWRtlzeGRD6zT+2WO3xHJXYx38sYNEUmMPVKb9+yR8VG OEa6S40+e/+5SmUt1sho8itm6QEYSxxPnBwtQLCslMWnYeUfGCthCqhL7 w==; X-IronPort-AV: E=Sophos;i="6.00,203,1681196400"; d="asc'?scan'208";a="216001309" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 30 May 2023 01:56:36 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 30 May 2023 01:56:35 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 30 May 2023 01:56:33 -0700 Date: Tue, 30 May 2023 09:56:10 +0100 From: Conor Dooley To: Alexandre TORGUE CC: Conor Dooley , , , Conor Dooley , Linus Walleij , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , , , , , , Subject: Re: [PATCH 02/11] pinctrl: stm32: add stm32mp257 pinctrl support Message-ID: <20230530-payday-gravity-45a26bd7f2dc@wendy> References: <20230529162034.20481-1-alexandre.torgue@foss.st.com> <20230529162034.20481-3-alexandre.torgue@foss.st.com> <20230529-enrich-clammy-14b498baf09f@spud> <879b7689-5663-28b5-9431-2fdd243ffff2@foss.st.com> MIME-Version: 1.0 In-Reply-To: <879b7689-5663-28b5-9431-2fdd243ffff2@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_015640_500493_D7B5B1A6 X-CRM114-Status: GOOD ( 17.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5531992542671054906==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5531992542671054906== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nUFaAWKbUup9Ifzb" Content-Disposition: inline --nUFaAWKbUup9Ifzb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 30, 2023 at 10:38:30AM +0200, Alexandre TORGUE wrote: > Hi Conor >=20 > On 5/29/23 20:04, Conor Dooley wrote: > > On Mon, May 29, 2023 at 06:20:25PM +0200, Alexandre Torgue wrote: > > > Add stm32mp257 pinctrl support. > > > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.h b/drivers/pinctrl/= stm32/pinctrl-stm32.h > > > index e0c31c4c8bca..5e5de92ddd58 100644 > > > --- a/drivers/pinctrl/stm32/pinctrl-stm32.h > > > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.h > > > @@ -24,6 +24,9 @@ > > > #define STM32MP_PKG_AB BIT(1) > > > #define STM32MP_PKG_AC BIT(2) > > > #define STM32MP_PKG_AD BIT(3) > > > +#define STM32MP_PKG_AI BIT(8) > > > +#define STM32MP_PKG_AK BIT(10) > > > +#define STM32MP_PKG_AL BIT(11) > >=20 > > Mainly out of curiosity, why have you go duplicate defines for these? >=20 > Mainly to fit with available packages for various STM32 MPU. Currently MP1 > SoCs are available with packages AB/AC/AD and MP2 series with AI/AK/AL but > in the future we could have package AB/AC/AD/AI available for a particular > SoC and then I need to anticipate this case. Sorry, what I meant was "why have you got defines for these in this header, when there is an existing set in include/dt-bindings/pinctrl/stm32-pinfunc.h?". Cheers, Conor. --nUFaAWKbUup9Ifzb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZHW6KgAKCRB4tDGHoIJi 0kFZAQDNwlhOAKYKGvOi/CDjWW2Mt/BRKIp/vzjgcMjS9EwGVQD9F29KDtdq+WOs LS3PsjPYYdNc61FM+WOSgjb+Z3y1bAc= =gjoB -----END PGP SIGNATURE----- --nUFaAWKbUup9Ifzb-- --===============5531992542671054906== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5531992542671054906==--