From: Conor Dooley <conor@kernel.org>
To: matthias.bgg@kernel.org
Cc: rafael@kernel.org, Daniel Lezcano <daniel.lezcano@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
devicetree@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Zhang Rui <rui.zhang@intel.com>,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding to yaml
Date: Tue, 30 May 2023 23:02:56 +0100 [thread overview]
Message-ID: <20230530-thaw-unpaved-a1708d46eb5a@spud> (raw)
In-Reply-To: <20230530150413.12918-1-matthias.bgg@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 826 bytes --]
Hey Matthias,
On Tue, May 30, 2023 at 05:04:12PM +0200, matthias.bgg@kernel.org wrote:
> + The MediaTek thermal controller measures the on-SoC temperatures.
> + This device does not have its own ADC, instead it directly controls
> + the AUXADC via AHB bus accesses. For this reason this device needs
> + phandles to the AUXADC. Also it controls a mux in the apmixedsys
> + register space via AHB bus accesses, so a phandle to the APMIXEDSYS
> + is also needed.
That double "also" bothers my OCD greatly, but it is a faithful
conversion.
> + "#thermal-sensor-cells":
> + const: 1
> -- #thermal-sensor-cells : Should be 0. See Documentation/devicetree/bindings/thermal/thermal-sensor.yaml for a description.
How come this has changed? I didn't see an explanation for it in either
of the patches.
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-30 22:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 15:04 [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding to yaml matthias.bgg
2023-05-30 15:04 ` [PATCH 2/2] arm64: dts: mt8173: Update thermal node matthias.bgg
2023-05-30 22:02 ` Conor Dooley [this message]
2023-05-31 7:53 ` [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding to yaml Krzysztof Kozlowski
2023-05-31 7:57 ` Krzysztof Kozlowski
2023-05-31 12:42 ` Matthias Brugger
2023-05-31 13:08 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530-thaw-unpaved-a1708d46eb5a@spud \
--to=conor@kernel.org \
--cc=amitk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox