From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 568D3C7EE23 for ; Tue, 30 May 2023 12:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QkZu3tNJxYHvCqgelfftr1QWK6YvjnDluPv1Ad7j4Nw=; b=DOPzirsMbeN6XP lgUeK3lR3FGpUlvJ6fDsuV5ykyiuVwZ4CU0gGKyvJsw6auEOvXed83Y4tzm0SH9/s25ndHNAPYz6L No980VGTMVn38Dh9PTnWRA9u88pYzqaARwhLWfVr1W4QVGTXgpm0PGpvwn7o6EJGCbgLQhzqtEOJK Bgk+9dPkAA5wDOCVFkMCyi3u4kaJGlP/Vlsy3uXxKyz0iZPAxgePUvP/FYgbsIgZ/H5pVrOchW72u Eep+7PnxSnGESVW3/YvRrC954HneRn2yIKmW/rHcEfFysWb4+M9PjiT51KqEFtE5rhhwvWSgeRo4l EvEtxTt2TuYgZZd2jZew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q3yBt-00Dnpz-0K; Tue, 30 May 2023 12:11:05 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q3yBp-00DnoW-0U for linux-arm-kernel@lists.infradead.org; Tue, 30 May 2023 12:11:03 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 34UCAiqM035104; Tue, 30 May 2023 07:10:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1685448644; bh=3Wjej0LyT5Fh0GI+iBtjlzAn6+Ozz/czgZi2sHh7gn4=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=GbAAIkZy2kKT8iGefaeW15cnQQ0EEREBemLruY8lOnDjmdMeD8AaomxCrrdPc3cAz 6gk+5zo0yREL0txskgln29YNSa0A9rEPWolVyijRAP3YZBLhmf8Uz16JbnSqZsxmPV QpE9hsnsf08MQ5Dt8SYatkJy2Gp3qnPorFzeOa5c= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 34UCAink049402 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 May 2023 07:10:44 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 30 May 2023 07:10:44 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 30 May 2023 07:10:44 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 34UCAipR020110; Tue, 30 May 2023 07:10:44 -0500 Date: Tue, 30 May 2023 07:10:44 -0500 From: Nishanth Menon To: Francesco Dolcini CC: Vignesh Raghavendra , Francesco Dolcini , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , Subject: Re: [PATCH v1 3/5] arm64: dts: ti: add verdin am62 Message-ID: <20230530121044.sjhv452b4hs4lyiy@flyer> References: <20230524143631.42471-1-francesco@dolcini.it> <20230524143631.42471-4-francesco@dolcini.it> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230524143631.42471-4-francesco@dolcini.it> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_051101_375869_050932BD X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:36-20230524, Francesco Dolcini wrote: [...] > diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi > new file mode 100644 > index 000000000000..e138b1c8ed14 > --- /dev/null > +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-dev.dtsi > @@ -0,0 +1,233 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Copyright 2023 Toradex Please also add appropriate product links to dts/dtsi > + */ > + > +/ { > + sound_card: sound-card { > + compatible = "simple-audio-card"; > + simple-audio-card,bitclock-master = <&dailink_master>; > + simple-audio-card,format = "i2s"; > + simple-audio-card,frame-master = <&dailink_master>; > + simple-audio-card,name = "verdin-nau8822"; > + simple-audio-card,routing = > + "Headphones", "LHP", > + "Headphones", "RHP", > + "Speaker", "LSPK", > + "Speaker", "RSPK", > + "Line Out", "AUXOUT1", > + "Line Out", "AUXOUT2", > + "LAUX", "Line In", > + "RAUX", "Line In", > + "LMICP", "Mic In", > + "RMICP", "Mic In"; > + simple-audio-card,widgets = > + "Headphones", "Headphones", > + "Line Out", "Line Out", > + "Speaker", "Speaker", > + "Microphone", "Mic In", > + "Line", "Line In"; > + > + dailink_master: simple-audio-card,codec { > + clocks = <&k3_clks 157 10>; > + sound-dai = <&nau8822_1a>; > + }; > + > + simple-audio-card,cpu { > + sound-dai = <&mcasp0>; > + }; > + }; > +}; > + > +/* Verdin ETHs */ > +&cpsw3g { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rgmii1 &pinctrl_rgmii2>; here and elsewhere: pinctrl-0 = <&pinctrl_rgmii1>, <&pinctrl_rgmii2>; > + status = "okay"; > +}; [...] > + /* EEPROM */ > + eeprom@57 { > + compatible = "st,24c02", "atmel,24c02"; checkpatch warns: DT compatible string "st,24c02" appears un-documented > + reg = <0x57>; > + pagesize = <16>; > + }; > +}; > + > +/* Verdin I2C_2_DSI */ > +&main_i2c2 { > + status = "okay"; Here and few other dtsis: you should set status along with pinmux. [...] > + > +/* Verdin UART_2 */ > +&wkup_uart0 { > + /* FIXME: WKUP UART0 is used by DM firmware */ > + status = "reserved"; If you do configure this in R5 SPL, you'd want to add the pinmux as well. > +}; > diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin-wifi.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin-wifi.dtsi > new file mode 100644 > index 000000000000..289db1666fc0 > --- /dev/null > +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin-wifi.dtsi > @@ -0,0 +1,36 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Copyright 2023 Toradex > + */ > + > +/ { > + wifi_pwrseq: wifi-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_wifi_en>; > + reset-gpios = <&main_gpio0 22 GPIO_ACTIVE_LOW>; > + }; > +}; > + > + Drop extra EoLs. [...] > diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi > new file mode 100644 > index 000000000000..2e7cb607df45 > --- /dev/null > +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi > @@ -0,0 +1,1400 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT Assuming you really intent this instead of purely GPL-2.0 [...] > +/* MDIO, shared by Verdin ETH_1 (On-module PHY) and Verdin ETH_2_RGMII */ > +&cpsw3g_mdio { > + assigned-clocks = <&k3_clks 157 20>; > + assigned-clock-parents = <&k3_clks 157 22>; > + assigned-clock-rates = <25000000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_eth_clock &pinctrl_mdio>; > + status = "disabled"; > + > + cpsw3g_phy0: ethernet-phy@0 { > + compatible = "ethernet-phy-id2000.a231"; Check binding - we don't include any compatibles that dont have yaml conversion done (pinctrl is the only exception). [...] > +/* TODO: Verdin DSI_1 / TIDSS */ Drop the TODO. [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel