From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D8E8C77B73 for ; Tue, 30 May 2023 14:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l1aw719wIak5pn+/nWzOCKMindBQdyry88RdWo4Vnjs=; b=X8xmDH9dvTf3WxbX30rLlqGts3 x0MdF+JoErjuaJUylmMHA86iTUzlD4ajc+O7v+mH1U5x4gPzr+yD+EX0xxc8Bw+LR/Oc1rMi03kcq cpGch+53X6RYU9cC3nWL3AbFWNXFcPRReS6TtUzlkaYg0I81GhmZoR2gg2IS1pgj5LvboSfxH9r7p aAsAtNbECuCDXhjjdnVbiNlbzncwX4fhuKDhKmPacQdVkEc24Km/aQFo1wt6IFwdpcxldzFentUb3 7+gZdlX+V3V2tvPap6jLA71Ft6uyiEzorA2PCXyiSrFlHR+iIDpFY3CeTXWEEYb7H9gLeAbsyyqYZ cMTODFQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q401v-00EB13-0e; Tue, 30 May 2023 14:08:55 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q401s-00EAyZ-0X for linux-arm-kernel@lists.infradead.org; Tue, 30 May 2023 14:08:53 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q400v-0004ps-Ru; Tue, 30 May 2023 16:07:53 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q400o-003tfR-8p; Tue, 30 May 2023 16:07:46 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q400n-009WHq-B9; Tue, 30 May 2023 16:07:45 +0200 Date: Tue, 30 May 2023 16:07:42 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Bjorn Helgaas Cc: Thomas Petazzoni , Pali =?utf-8?B?Um9ow6Fy?= , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Joyce Ooi , Florian Fainelli , Jim Quinlan , Nicolas Saenz Julienne , Vignesh Raghavendra , Tom Joseph , Shawn Guo , Rahul Tanwar , Manivannan Sadhasivam , Thierry Reding , Jonathan Hunter , Serge Semin , Vidya Sagar , Jisheng Zhang , Miaoqian Lin , Ray Jui , Scott Branden , Ryder Lee , Jianjun Wang , Matthias Brugger , Sergio Paracuellos , Shawn Lin , Heiko Stuebner , Toan Le , Rob Herring , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, Broadcom internal kernel review list , linux-rpi-kernel@lists.infradead.org, kernel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Subject: Re: [PATCH 00/15] PCI: Convert to platform remove callback returning void Message-ID: <20230530140742.ebbrxmpieuphbmz3@pengutronix.de> References: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_070852_207058_FF27B38D X-CRM114-Status: GOOD ( 22.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7925390141903317474==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7925390141903317474== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qk26xz6flafy3g2q" Content-Disposition: inline --qk26xz6flafy3g2q Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Bjorn, On Tue, Mar 21, 2023 at 08:31:53PM +0100, Uwe Kleine-K=F6nig wrote: > this series adapts the platform drivers below drivers/pci to use the > .remove_new() callback. Compared to the traditional .remove() callback > .remove_new() returns no value. This is a good thing because the driver c= ore > doesn't (and cannot) cope for errors during remove. The only effect of a > non-zero return value in .remove() is that the driver core emits a warnin= g. The > device is removed anyhow and an early return from .remove() usually yield= s a > resource leak. >=20 > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. >=20 > All drivers were easy to convert as they all returned zero in their > remove callback. Only for iproc the conversion wasn't trivial, the other > were converted using coccinelle. >=20 > There are no interdependencies between these patches. So even if there > are some concerns for individual patches, I ask you to apply the > remaining set. Then I only have to care for the review feedback of the > refused patches. (Having said that I don't expect any serious objection, > just things like squashing or separating patches, or maybe I picked a > wrong subject prefix.) These patches wait for application for quite some time now. They apply just fine to v6.4-rc1 and next/master. Would be great to get them in during the next merge window and ideally give them some time in next before. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --qk26xz6flafy3g2q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmR2Ay0ACgkQj4D7WH0S /k5qnwgAnpUxpx4rn6WEsDH7Xm3DdX2vIesYJvk7oOO95SBT/vP6MAkPvzaDUJfe WVi/Oz1Ka8FPwOop8vkbb8M3nQIjNjB9OfI+6fW+55MvN9guFPI/Utl1TIscmgQz YnH2pnHF7uIzKApPtniNZJ6CDy1deepI9SK9Vyx/eMbuppFuUfVz5NR+vdR8e1FA o+DEn8E+tjfjwSb0FdxgTv+Subwm4oPwuYrhyv3bJZ17YenL7OoGc8coPdQr13BS Mq7t/nM05p/vZtkey55UWA3E+SEsbGz64ikmcv1hfwGVq2aRi8qO+aCUnhe3LX9m GZAiwIh4ypdjtDXIIMwGjMatqA4QQA== =tfIE -----END PGP SIGNATURE----- --qk26xz6flafy3g2q-- --===============7925390141903317474== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7925390141903317474==--