Re: [PATCH v1 3/5] arm64: dts: ti: add verdin am62

From: Nishanth Menon <nm@ti.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/5] arm64: dts: ti: add verdin am62
Date: Tue, 30 May 2023 11:53:51 -0500	[thread overview]
Message-ID: <20230530165351.rqpu7go3kw6j3upc@storable> (raw)
In-Reply-To: <ZHYl8/8k4CTm/2LW@francesco-nb.int.toradex.com>

On 18:36-20230530, Francesco Dolcini wrote:
> On Tue, May 30, 2023 at 07:10:44AM -0500, Nishanth Menon wrote:
> > On 16:36-20230524, Francesco Dolcini wrote:
> > > +/* Verdin I2C_2_DSI */
> > > +&main_i2c2 {
> > > +	status = "okay";
> > 
> > Here and few other dtsis:
> > you should set status along with pinmux.
> This is already done in the SoM dtsi, same applies to the other comment
> you have on this pinmux topic.
> 
> To rephrase what's hopefully is already written in the commit
> message/series description, or at least it was in my intention.
> 
> The system is modular, with multiple SoM variant and multiple carrier
> boards. Standard interfaces are defined at the family level, e.g.
> already in the SoM, in the carrier board DT file peripherals are just
> enabled, the pinmux is already defined in the common som.dtsi [1][2][3]
> files and the carrier board just use those unless there is some kind of
> non-standard deviation.
> 
> This prevents duplication and simplify writing device tree file for board
> that use standard Verdin family interfaces. This should be visible
> looking at this series in which 3 different boards (Dev, Yavia and
> Dahlia) are added.

It helps clarity if the node is marked "okay" when all the necessary
properties required for operation (in this case pinmux) is enabled. I
don't see a big change as a result. Just stops people from hunting for
where pinmux is actually done.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel