From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2763C7EE23 for ; Tue, 30 May 2023 17:51:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t+AVR2xV1owiCXApi/SLLV6iGCeia1OV1kG8Ue3Bffg=; b=eLleD6NQ3dsZUp kHvrzEindSDlgwYmApJzxxP9+/UsFxBQcgdxr9UUOun/+Qg2rFNNu0A0RrkyZpM5rSRzti01XT1PB e0VUAgkDESZetJPKO+O+v051k30rFKeHGZIpGuluTgUEP6Q4+yy+HbjP0VdzWTlc7A265MZ3xTECe OiTnZ91eJ3ue2HUaTmTPCGMXMMJ+2Pc0j5FDMtffF9+lncg8eEa9XdVuzHfU+QZ4SNg8b1MJqb7ay /3qYFgmnRucxLwqDJ4edG4XBp2dkMuPN15e3wALPrjGROHHVeTPwmK0kGKj0b5eSVzssPaQhXENHP 3jrqVXBXs3E4r9An6Pkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q43Up-00Eo0G-02; Tue, 30 May 2023 17:50:59 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q43Ul-00EnyI-20 for linux-arm-kernel@lists.infradead.org; Tue, 30 May 2023 17:50:57 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 34UHone2006637; Tue, 30 May 2023 12:50:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1685469050; bh=EeURbpGqVcxBuyv5DijQKXjocdeNk4oLnlwGWm0D+9s=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=zDH7qfSArEfl8AtR5v6WXwA1pWT5TS6JGO+gibYnUTgOCOzCWAbRkOVtjn187pbOw /heL5lQin/SVPr24WdCIuCooyD7nb2SPHs6LOR6U0fISWyGs/SqZ1czTOhdrARAPdS EL1017YRdbdNoZV5KLkwsg6vuGTCKEdA4biPMYts= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 34UHonPv074569 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 May 2023 12:50:49 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 30 May 2023 12:50:49 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 30 May 2023 12:50:49 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 34UHoniL019431; Tue, 30 May 2023 12:50:49 -0500 Date: Tue, 30 May 2023 12:50:49 -0500 From: Nishanth Menon To: Nitin Yadav CC: , , , , , , , Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am62x-sk-common: Add main_uart1 and wkup_uart nodes Message-ID: <20230530175049.yjcc6nnuipbkafhx@cryptic> References: <20230510123216.3440019-1-n-yadav@ti.com> <20230510123216.3440019-2-n-yadav@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230510123216.3440019-2-n-yadav@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_105055_738553_5EB4AAF6 X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18:02-20230510, Nitin Yadav wrote: > wkup_uart and main_uart1 on this platform is used by TIFS and DM > firmwares. Describe pinmux and add aliases for completeness. > > Signed-off-by: Nitin Yadav > --- > .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi > index 976f8303c84f..e29ea8ae2177 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi > @@ -12,7 +12,9 @@ > > / { > aliases { > + serial0 = &wkup_uart0; > serial2 = &main_uart0; > + serial3 = &main_uart1; > mmc0 = &sdhci0; > mmc1 = &sdhci1; > mmc2 = &sdhci2; > @@ -127,6 +129,15 @@ AM62X_IOPAD(0x1cc, PIN_OUTPUT, 0) /* (E14/E11) UART0_TXD */ > >; > }; > > + main_uart1_pins_default: main-uart1-pins-default { > + pinctrl-single,pins = < > + AM62X_IOPAD(0x194, PIN_INPUT, 2) /* (B19) MCASP0_AXR3.UART1_CTSn */ > + AM62X_IOPAD(0x198, PIN_OUTPUT, 2) /* (A19) MCASP0_AXR2.UART1_RTSn */ > + AM62X_IOPAD(0x1ac, PIN_INPUT, 2) /* (E19) MCASP0_AFSR.UART1_RXD */ > + AM62X_IOPAD(0x1b0, PIN_OUTPUT, 2) /* (A20) MCAS/mP0_ACLKR.UART1_TXD */ In all places for sk-common.dtsi, Could you fix the documentation in line with rest of the code? /* First pad number is ALW package and second is AMC package */ [..] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel