From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1AEAC7EE23 for ; Wed, 31 May 2023 14:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aGQNZOpkZvGnY3DNdmtA2i6yYATh0Weirxos+54O9NU=; b=C39vvBYOvEnvLX pXc6i7AMuX9T864S2d1OIf0S8SjTO9B1/41Hz9Sn3pLI+ilbPjaP6oxa/lyscV2Rnz/3mFQ1G5xDh +0YlsqGp3xVQSzcy4TzQBzSliSlrrGrcf8A1ofZKivBCjt76sk0OPgl7/MLUj1hxMxsCHEUyrzUsO HE60TDNKlWaNb0oqoE03O42UdlmEHjZZKc8cgIFCCOktDQx+bs+xZxP0EyJ1KqEwx0Hcsc0d2uibD I1gfozJ45eudImMXYHp6euF48eWX8UBpLiuqIqx4+0wVmn8zV2dSqy4I0LSD+RfKuw1lxGyuRI8D/ 34/jwBv1Bc6qUqoi9c3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4MW6-0005nc-2q; Wed, 31 May 2023 14:09:34 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4MW3-0005mc-2D for linux-arm-kernel@lists.infradead.org; Wed, 31 May 2023 14:09:32 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-30af56f5f52so1816056f8f.1 for ; Wed, 31 May 2023 07:09:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1685542170; x=1688134170; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pgpyzmnbNHAseyCM+s0XsB0KjofBbxw68PBCInlqrLM=; b=oxzmFA70Bjtlz6BsRl7Er91ErjmIoeIoblFWyRv4dTc3OiWmG2pPwau86hZLSdyF+x o/en/dxj3KIaEe2mRLZqODiQX+Fg+JSppTKF39rcISQ02VRyDntm1u1tkc/glQkXxXhh EaiHBTIEfxCSC7I4LMcET+AewMo97ui82kaVsMEd7Ab8ZHEKv8SF/Xsnqc94oJk3BzeN i2yd/18czjL4o65TJ3sZKe+lBjgFghQNfjWmqI/7IwN3IC290cPe1bGt6TzPvtWv2jX4 ehNH+GVJmKOfUJCeQKY/KPO98LY19AkaBF/5VcNefetloyimk0xYMoTcdzEvgx+HftjY /BSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685542170; x=1688134170; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pgpyzmnbNHAseyCM+s0XsB0KjofBbxw68PBCInlqrLM=; b=BZx6d0lozHBets076D2CxeiLbKR0Ow9yxHYu761YXoYMraln8umQHtRXnwX+pawW6r zb+/PXM9s3OoXIlz/5plybWzJKcXdYIYv88ErRS1oGk1sUx/o2v3+WEeVshzWYDtLF24 +qA7arfieq8ZwygnXK5nXKs3yLvwY/VEE/njn32mBlYxVPYhCv9rF3Rk6lHn1hroCOVx r1VHsON+LKFz0SwJqbb1MUQcxyI6kOye1dN03Rsr9WdCJp2aPHUGYy1MK0MuQ24BJbVU pJ3neoja8E6Qs+Jm5Kf7iKsTX7gbuIlOC+H/KSouf9/2kUBvqh2P9Rj30Jc1g1ug9CDo LCIQ== X-Gm-Message-State: AC+VfDwpHw3mTBZxlZgzqFPCSDZNoxhL6oD3ey061yO60wNJ8iL0jkaX a21iY/fqiU14r7FQaCUa5MHB1Q== X-Google-Smtp-Source: ACHHUZ6/5u1aIeEPR87Cph6/LuYqwzkXH6Ggsh21iSthCsoK8ecfPiKMDhYwuo0sJqTdGafvLc34yA== X-Received: by 2002:a5d:526e:0:b0:309:50e7:7c3 with SMTP id l14-20020a5d526e000000b0030950e707c3mr4408962wrc.63.1685542170038; Wed, 31 May 2023 07:09:30 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id d15-20020a056000114f00b0030af72bca98sm4800839wrx.103.2023.05.31.07.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 07:09:29 -0700 (PDT) Date: Wed, 31 May 2023 16:09:28 +0200 From: Andrew Jones To: Alexandre Ghiti Cc: Jonathan Corbet , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Paul Walmsley , Palmer Dabbelt , Albert Ou , Atish Patra , Anup Patel , Will Deacon , Rob Herring , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 04/10] drivers: perf: Rename riscv pmu driver Message-ID: <20230531-49ed4c2054db0abbacd03632@orel> References: <20230512085321.13259-1-alexghiti@rivosinc.com> <20230512085321.13259-5-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230512085321.13259-5-alexghiti@rivosinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230531_070931_730685_D7B499F1 X-CRM114-Status: GOOD ( 20.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 12, 2023 at 10:53:15AM +0200, Alexandre Ghiti wrote: > In addition to being more pretty, it will be useful in upcoming commits > to distinguish those pmu drivers from the other pmu drivers. > > Signed-off-by: Alexandre Ghiti > --- > drivers/perf/riscv_pmu_legacy.c | 2 +- > drivers/perf/riscv_pmu_sbi.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/perf/riscv_pmu_legacy.c b/drivers/perf/riscv_pmu_legacy.c > index 0d8c9d8849ee..ffe09d857366 100644 > --- a/drivers/perf/riscv_pmu_legacy.c > +++ b/drivers/perf/riscv_pmu_legacy.c > @@ -95,7 +95,7 @@ static void pmu_legacy_init(struct riscv_pmu *pmu) > pmu->ctr_clear_idx = NULL; > pmu->ctr_read = pmu_legacy_read_ctr; > > - perf_pmu_register(&pmu->pmu, "cpu", PERF_TYPE_RAW); > + perf_pmu_register(&pmu->pmu, RISCV_PMU_LEGACY_PDEV_NAME, PERF_TYPE_RAW); > } > > static int pmu_legacy_device_probe(struct platform_device *pdev) > diff --git a/drivers/perf/riscv_pmu_sbi.c b/drivers/perf/riscv_pmu_sbi.c > index 70cb50fd41c2..3b0ee2148054 100644 > --- a/drivers/perf/riscv_pmu_sbi.c > +++ b/drivers/perf/riscv_pmu_sbi.c > @@ -897,7 +897,7 @@ static int pmu_sbi_device_probe(struct platform_device *pdev) > if (ret) > goto out_unregister; > > - ret = perf_pmu_register(&pmu->pmu, "cpu", PERF_TYPE_RAW); > + ret = perf_pmu_register(&pmu->pmu, RISCV_PMU_PDEV_NAME, PERF_TYPE_RAW); Should we include "sbi" in this name? > if (ret) > goto out_unregister; > > -- > 2.37.2 > Otherwise, Reviewed-by: Andrew Jones _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel