From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18322C77B7A for ; Wed, 31 May 2023 15:46:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xr2/kLbUWszVbNrx5rDDLpkdpvNQFZO1Jd36iXPakDU=; b=w2VsNUn/v+mAIF aD5iyQsVY+ov9SBthhmEQ6tWi95U7PFo8Y6VUUeNMu0qn8b8djktDtYJHDKz2VwM/QsQPvTCUegti az/uCh2FKmMpZA9be73z4fcMYyEedDIcBL3gTGgt6m+NP4i5ooZTqDYci0bPJ+a3m0z9Vdmp0l8ku LiGiHZ2Du+RJXRaxth6SIPb+50eOu9OmRYICTi8TDH0AeSCyUYZuzcnhenGsLVUF8EgdtmYkxE6l0 u4k7Ts7s7kdFa/9oOaHVgL0R2RWx9nBoO7CR4FICOOc3SKhnwLIajHpPks1x6Nd9SRJdBUJW4qmF0 yhTQB6vASLA8A/xw6o3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4O1g-000L24-1K; Wed, 31 May 2023 15:46:16 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4O1c-000KzA-0l for linux-arm-kernel@lists.infradead.org; Wed, 31 May 2023 15:46:14 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QWYTK03h2z67nFJ; Wed, 31 May 2023 23:43:48 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 31 May 2023 16:45:56 +0100 Date: Wed, 31 May 2023 16:45:56 +0100 From: Jonathan Cameron To: Junhao He CC: , , , , , , , , Subject: Re: [PATCH v2 1/3] drivers/perf: hisi: Add support for HiSilicon H60PA and PAv3 PMU driver Message-ID: <20230531164556.000027e9@Huawei.com> In-Reply-To: <20230531104625.18296-2-hejunhao3@huawei.com> References: <20230531104625.18296-1-hejunhao3@huawei.com> <20230531104625.18296-2-hejunhao3@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230531_084612_440435_E2BE1FAD X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 31 May 2023 18:46:23 +0800 Junhao He wrote: > Compared to the original PA device, H60PA offers higher bandwidth. > The H60PA is a new device and we use HID to differentiate them. > > The events supported by PAv3 and PAv2 are different. They use the > same HID. The PMU version register is used in the driver to > distinguish different versions. > > For each H60PA PMU, except for the overflow interrupt register, other > functions of the H60PA PMU are the same as the original PA PMU module. > It has 8-programable counters and each counter is free-running. > Interrupt is supported to handle counter (64-bits) overflow. > > Signed-off-by: Junhao He Hi, I would have slightly preferred to see the refactoring done as a first patch and then the new device supported added in a second, but as that second patch would only be a few lines I don't mind that much. The result looks fine to me. Reviewed-by: Jonathan Cameron _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel