From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8383C7EE23 for ; Wed, 31 May 2023 16:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CgEimbFcsH6tYGhB0M1+qwBL4SlGksjUCUax8CQJ3A8=; b=cr70daChJrqLlb fNYcGn+7juMmB/woMO7UAJni49XZa2k7drAB80IQDGDOc4hEc30sSCncPdpBQbwX7kVbspvlba5jU obUfpNdWfEGiDdnNM/wY+M7P5FUZhLz+Av5hWEf/ZXzo9uAMYZGgDUPUYTVs1HUWo9/Hccn6rg3rp qhMDqhvsTrG3pb2kz1qowp5bHaYFFY5pFt+e11ve4blR2hrEOwUAjjL/m7oRL6hs6X8G1J503gu9w rgSUvMPZQvxIIIvBjCeBXdlHM6YS3kpi7TzLaDM3KQGmTQ7JvY3+jGjQ9EO1XlGTRyGOpUMj/bFtA yZfJG0PlC+a2tr1Zjlzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4Ol3-000U6U-36; Wed, 31 May 2023 16:33:09 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4Ol1-000U4j-1B for linux-arm-kernel@lists.infradead.org; Wed, 31 May 2023 16:33:09 +0000 X-GND-Sasl: luca.ceresoli@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685550782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CuEjCfYrSXwpkGNWiwpt9RfeE5fAvVGA+wyh8qN+kyk=; b=CIkzXrTBevFhycdDTUYWl1lxs9WC4SxZMisyMnxKJOwtwChgHNHdQnW6OiLV0DlxtzCQlc 8nvkEAEzHHpJxKnyXPEQTmiyfbjIXa04F2RoWRQKb3yWdIOk0bJ5k8ND73opRq0+eSRIDb AG/sQs1M7a/M+UWbjUHedVWNJCXF8u5VrsGHjv+micSoLQTQ4F3wuOwnIQ1eNQrr/XSpgf HEsjdmqaC/eaYqToLd/2J8gVOdL6ZnXM3m0wsW7iqmbgElHMyG+aDWikV46ewa4yA5M9wI V4lxNGNWuFN4WS5FXUWJQpjXQhUgrlqb0d8P0IHLFcdEaGHiP2LpHrLk7GYDSg== X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com X-GND-Sasl: luca.ceresoli@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id C81B220009; Wed, 31 May 2023 16:32:57 +0000 (UTC) Date: Wed, 31 May 2023 18:32:56 +0200 From: Luca Ceresoli To: Claudiu Beznea Cc: , , , , , , , , , , , , , , Subject: Re: [PATCH 1/8] clk: vc5: check memory returned by kasprintf() Message-ID: <20230531183256.48e1b893@booty> In-Reply-To: <20230530093913.1656095-2-claudiu.beznea@microchip.com> References: <20230530093913.1656095-1-claudiu.beznea@microchip.com> <20230530093913.1656095-2-claudiu.beznea@microchip.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230531_093307_711362_E22CBDBA X-CRM114-Status: GOOD ( 10.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Claudiu, On Tue, 30 May 2023 12:39:06 +0300 Claudiu Beznea wrote: > kasprintf() returns a pointer to dynamically allocated memory. > Pointer could be NULL in case allocation fails. Check pointer validity. > Identified with coccinelle (kmerr.cocci script). > > Fixes: f491276a5168 ("clk: vc5: Allow Versaclock driver to support multiple instances") > Signed-off-by: Claudiu Beznea I think this driver would benefit a bit of refactoring, moving all those similar sections to a single function. But for the time being your change is fine: Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel