From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B639C77B73 for ; Wed, 31 May 2023 21:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nvg1Ckye1TRRFu2KReNeA6dERWFSs5/TD+V1FKsWTyc=; b=Bbqo/+i8w+Xlp6 vATgXFb/tiNROAd7j/uU5SJotsByzs6nlXiIGv9i2Jsg2mjQRlZ+QQVoVBVF4/6fSE5mrEnO54Rm7 4I9f3hDYaT0pij/6bZZHXbJg4D8FEAVjbArxP0RjntoXa0dhIvLce+IUeuNfxT63D206V8uryLXb7 rh+7+iTlFOMGptdNXKkPirmL/w38G9a0f9gyHShrFVbnNt/tQaXLM1okxpP+87QLzxb3V+kFczpAh SSSZO/Ue18SnSR8FexKwqb+XCupPrSw9cZmXUfMZzrQ/G8uL9XHZCjMjNQfyEgAjCXXHdvXFF0toZ gfmEcMGZvhC8Mwq4hwgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4TjW-001E6v-1M; Wed, 31 May 2023 21:51:54 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4TjR-001E5l-1a for linux-arm-kernel@lists.infradead.org; Wed, 31 May 2023 21:51:51 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 34VLpjPB103086; Wed, 31 May 2023 16:51:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1685569905; bh=h3g0B28wPPCyczRYs/JjUclI0PqNyrP1/X6niyx0I94=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=jAEFqxYT/uolSI1Ty90SoIUHFFRSgDYqznPYFjr0uKWhUIE+56pRIDUQt93+EYQ+R d0suNbh9OqAOFuYmsyB46Pc+6EZ+uAYZmxawhboFDIkZc8r3P05hQmwkwiO+oXaoDA Yrx3wnfFunlBhbKsqYIsnqeICqxDik1YL7qIQ3ns= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 34VLpjkU113595 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 31 May 2023 16:51:45 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 31 May 2023 16:51:45 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 31 May 2023 16:51:45 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 34VLpjBm109874; Wed, 31 May 2023 16:51:45 -0500 Date: Wed, 31 May 2023 16:51:45 -0500 From: Nishanth Menon To: Udit Kumar CC: , , , , , , , , Subject: Re: [PATCH 1/5] arm64: dts: ti: k3-j7200: Add general purpose timers Message-ID: <20230531215145.a6xiurql6jtvbr3y@filling> References: <20230426103219.1565266-1-u-kumar1@ti.com> <20230426103219.1565266-2-u-kumar1@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230426103219.1565266-2-u-kumar1@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230531_145149_646918_DAAA2606 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:02-20230426, Udit Kumar wrote: [..] > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > index ef352e32f19d..555bde0e7fda 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi [...] > + main_timer13: timer@24d0000 { > + compatible = "ti,am654-timer"; > + reg = <0x00 0x24d0000 0x00 0x400>; > + interrupts = ; > + clocks = <&k3_clks 63 1>; > + clock-names = "fck"; > + assigned-clocks = <&k3_clks 63 1>; > + assigned-clock-parents = <&k3_clks 63 2>; > + power-domains = <&k3_pds 63 TI_SCI_PD_EXCLUSIVE>; ^^ I think you need to use device ID 64 here instead of 63 for the node Also for odd numbered timers, we need to set the TIMERx_CLKSEL_VD explicitly for J7200, unfortunately the IDs are different from J721e, preventing re-use :( Example: https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j7200/clocks.html#clocks-for-timer1-device https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j7200/clocks.html#clocks-for-timer1-clksel-vd-device > + ti,timer-pwm; > + }; [...] > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > index 331b4e482e41..1c09e442b379 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > @@ -34,6 +34,126 @@ k3_reset: reset-controller { > }; > }; [...] > + mcu_timer6: timer@40460000 { > + compatible = "ti,am654-timer"; > + reg = <0x00 0x40460000 0x00 0x400>; > + interrupts = ; > + clocks = <&k3_clks 76 1>; > + clock-names = "fck"; > + assigned-clocks = <&k3_clks 76 1>; > + assigned-clock-parents = <&k3_clks 76 2>; > + power-domains = <&k3_pds 35 TI_SCI_PD_EXCLUSIVE>; I think this needs to be 76 instead of 35 > + ti,timer-pwm; > + }; > + -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel