From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD046C77B7E for ; Thu, 1 Jun 2023 15:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EjZr+6U4s4KlrmvWWMj+iXQuvI3hguH/kVTfdYLQY40=; b=YlUNTbWy+NzL7z ALPsc5Ate9AFECJ79ODrCN7CeGwtq3Lfg+pZvZKK/RtsMpmVfEP5EEzam12GA5eZM/9AKTy7U5gHl qMDebVtqN/bbEFX/l6KnHgkvEs0R8yHd2G4McKOqkDlae6T2Qd1VD+J02pYxALkQvNwBnSdidrTgI PdmQRfw9T+G2cwP1OyDQZ/7NRBxd0uRjP18VUyvcroZdjvH3R+oeSGXSYktJqsIooMQIwoou+XXvX RwUoLQ4qNARJ7W9YiN/9QHBKuE6KiDsv40WA43gr3dZIghFYqA34kaAUCbLj5FUz1l6PKjFZkvTWx i6ABm44aM3M0ezEA/Xxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4k0L-003zEG-2g; Thu, 01 Jun 2023 15:14:21 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4k0J-003zDP-0y for linux-arm-kernel@lists.infradead.org; Thu, 01 Jun 2023 15:14:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D5AF64671; Thu, 1 Jun 2023 15:14:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23260C433D2; Thu, 1 Jun 2023 15:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685632456; bh=BWuqix3iYt6ItyW/yuJYXANq/UkAe3dLO3iaTH5bAos=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PIFSvxtK/eczcW/oiSWtq8/LRBF27fA/5p369wHLSDjrdsCCowQ+TgIodjhEInsgb 3CbR5A4IX5hFfPSH3kZ76v4gehNEfnhM7IAS03bV/2jpofmUrfRFi18x5BsPR4BjiK Z6ztrFX7/aH5oDcgI7NZXPTWKIF0DFrk3oezAAkY3aheftezh35+UxYLy2cZ33/Ts5 u7PYAhRiffx8dz3PX2sAhteAkiNkxRuTD1kfe25CdhMWg1CCmFGw8tE5MhtMXmZXv3 yFRMHmPmDQJ9Co0M0xVXEwg4WyDlli2LVp4k3FzY2EgyZ/mrQ92yxcVcb44CG6ivEd blcAMD216b84g== Date: Thu, 1 Jun 2023 17:14:12 +0200 From: Andi Shyti To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Dong Aisheng , Shawn Guo , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] i2c: imx-lpi2c: Don't open-code DIV_ROUND_UP Message-ID: <20230601151412.qfszgsl73q2jrr5l@intel.intel> References: <20230601132532.2749426-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230601132532.2749426-1-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_081419_396241_C89C5487 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Uwe, On Thu, Jun 01, 2023 at 03:25:32PM +0200, Uwe Kleine-K=F6nig wrote: > There is no change in the generated code (tested on an ARCH=3Darm > allmodconfig build). > = > Signed-off-by: Uwe Kleine-K=F6nig > --- > drivers/i2c/busses/i2c-imx-lpi2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-= imx-lpi2c.c > index 1af0a637d7f1..ae6ce28d3330 100644 > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c > @@ -217,7 +217,7 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *= lpi2c_imx) > for (prescale =3D 0; prescale <=3D 7; prescale++) { > clk_cycle =3D clk_rate / ((1 << prescale) * lpi2c_imx->bitrate) > - 3 - (filt >> 1); > - clkhi =3D (clk_cycle + I2C_CLK_RATIO) / (I2C_CLK_RATIO + 1); > + clkhi =3D DIV_ROUND_UP(clk_cycle, I2C_CLK_RATIO + 1); you updated this at the end... looks good :) Reviewed-by: Andi Shyti = Andi > clklo =3D clk_cycle - clkhi; > if (clklo < 64) > break; > = > base-commit: ac9a78681b921877518763ba0e89202254349d1b > -- = > 2.39.2 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel