From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4989FC77B73 for ; Sun, 4 Jun 2023 21:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JjUv3aosjszs6Ytc7gxhmuaVO1QIu61VpL7yRccSAAo=; b=b/zGl6QcHKj6CMkFbDpeQ/gPO0 PAli5bqrg4buDaMtmBTPIIaKqvlFAcpl224XGpfGvY9KFh6ETcN4TUWZDcwpj2Lan+EW9FLKmruw2 2RmgVl0ZFAO6gMPGb1ZgRUMAwuTTlZ+Q0f+l9OmUO/Lfr9PgZ16wWH10Sg1H5jlxYs/1ttSXp+wgl aposQhIOEaMusDHwQmt6pM0gtemW8XRNz6H+OvESOVMBjRNpsX1XB6Eh7yL3+m80Nx20WxZsIa3eq IMNFgYW7g4/mb39BQfr1FGVYVQSkVDTwGf9TLzJC8/PHQHdTaFeQYiHnRkA7WefvNuFG+RvzMgrUa zN4/UhPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q5uq6-00D64W-1R; Sun, 04 Jun 2023 21:00:38 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q5uq2-00D63o-2C; Sun, 04 Jun 2023 21:00:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E22E0609AD; Sun, 4 Jun 2023 21:00:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB97FC433EF; Sun, 4 Jun 2023 21:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685912433; bh=bP33TM36+Nno9c9jmbHjs6cfji8fLGfto2b0EkwdTmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dz0JAJ/z++ZXys+o8PXM4tJtgvoWr0aPQTOlME1Tnuo9UTwo9FNVZ3CrO76ayaOCA wPLXlXvbwq/tFhC2hWi7ZuhKOxSiwUUewbylPzM54BszYnBG8uxqunt6v4HzCMI00l OCYkG0+JylrrOLXd7lMffOa9Y1N+pgsueKtWond32u+j2+noyb2Pxy2F20x9N6xXhI 3MQ46uiR9tCgSRIDZVB0vPqWp39u+fDn0dtp7xEcqeSMzarkTNa8m4WwEkPD+oI5j2 TraMflNSGp8aLmqhGIcn6T04p+P+eBsYh91FUo+k77AZq7fgd0nCeRRNmvN6UyWBAh i8uLGtMpcaLew== Date: Sun, 4 Jun 2023 22:00:24 +0100 From: Conor Dooley To: Maxim Kiselev Cc: Krzysztof Kozlowski , linux-iio@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Cristian Ciocaltea , Heiko Stuebner , Andy Shevchenko , Cosmin Tanislav , Stephen Boyd , Arnd Bergmann , William Breathitt Gray , Hugo Villeneuve , Mike Looijmans , ChiYuan Huang , Ramona Bolboaca , Ibrahim Tilki , Caleb Connolly , AngeloGioacchino Del Regno , ChiaEn Wu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 2/3] dt-bindings: iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC Message-ID: <20230604-afternoon-frighten-42222010557b@spud> References: <20230601223104.1243871-1-bigunclemax@gmail.com> <20230601223104.1243871-3-bigunclemax@gmail.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230604_140034_807976_A9FE7734 X-CRM114-Status: GOOD ( 24.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1734346933731085860==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1734346933731085860== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="R6NUQuCQejyhVbgd" Content-Disposition: inline --R6NUQuCQejyhVbgd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 04, 2023 at 11:20:43PM +0300, Maxim Kiselev wrote: > =D0=BF=D1=82, 2 =D0=B8=D1=8E=D0=BD. 2023=E2=80=AF=D0=B3. =D0=B2 11:38, Kr= zysztof Kozlowski > : > > On 02/06/2023 00:30, Maksim Kiselev wrote: > > > From: Maxim Kiselev > > > > > > Allwinner's D1/T113s/R329/T507 SoCs have a new general purpose ADC. > > > This ADC is the same for all of this SoCs. The only difference is > > > the number of available channels. > > > > Except that it wasn't tested... >=20 > Yes, you are right. I tested it only on the T113s board. And I will be gl= ad if > someone tests it on another SoC. I would imagine Krzysztof meant testing the binding w/ dt_binding_check etc, rather than testing the ADC itself. > > Please run scripts/checkpatch.pl and fix reported warnings. Some > > warnings can be ignored, but the code here looks like it needs a fix. > > Feel free to get in touch if the warning is not clear. >=20 > I got a warning about required maintainer property. Should I do > anything with this? Yes, you should! > If yes, then who should be a maintainer? You, preferably. > > Hm? So you do not allow anything from adc.yaml related? Are you sure > > this is your intention? >=20 > I'm not sure about it. I looked at other ADC bindings and didn't find > another driver with 'additionalProperties: true' Try `unevaluatedProperties: false` instead. Cheers, Conor. --R6NUQuCQejyhVbgd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZHz7ZAAKCRB4tDGHoIJi 0mhhAQDWUaQ6MsgMc3hJ9RhC8xIHkPkDg+t28YylGU9AHR/7TQEAoAIiWf+O7hZq dlGXke5/fRuOymui5uFzsqI45K65SAE= =8YSV -----END PGP SIGNATURE----- --R6NUQuCQejyhVbgd-- --===============1734346933731085860== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1734346933731085860==--