From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86A98C77B73 for ; Mon, 5 Jun 2023 11:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MoYoo0C94esM8uVBZukBOzy/+fRmeGtntNhIOFTRYW4=; b=fYV4oGnQlRAsYS N4xKis7TzzcFWsL10NvPsBZbeCR2vaRIqwlyiTywM7Z5a1oTx+DRQc6yBqUbPawCQA0YbbRD+eMw7 S1HSDR7gCOqgHTwWJ30SUkVz0wBLl0xB1LcIx66tfcJ/C82byt4yy2LazbPnNaNBPyMGu2Os5R9us XqL4pUOSApjQRfX5X1w5tqXq4WXVOLumw/IAJnUweU7kEM236LlzTgi7U31FeUuHC2MTIidC/Swb5 s47TJ9yIq8V4Gb/cLsuZTAKRshFQYgWPxxtT/q98N0Kqc9t00cmadvNWzWHs2cpsuxDuXV6aFCI0v deMXSFvEIvSMJ5mqGeCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q68iO-00FKgf-2O; Mon, 05 Jun 2023 11:49:36 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q68iL-00FKfp-2b for linux-arm-kernel@lists.infradead.org; Mon, 05 Jun 2023 11:49:35 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 355BnPM4122948; Mon, 5 Jun 2023 06:49:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1685965765; bh=KmeppYSzjhnTpjhlknmqIYVjpLAg8iwCiN9kkzil5Po=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=rzuBFDvxGTklZPQbUA+EnMHCnO893f+FUUw6RdIgpejH9a28MfrB8bKluQ5i/3lG1 LZjNazZ28TbsYR2r74qR/pCavB30IruTdTPMvvaAlSEZMJzh98WHLgfzQMsx2iBcA+ LUeFo9KB0dnysXCSzOCs3N8HP1OV+1Tew3j6IGmk= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 355BnPLN000485 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Jun 2023 06:49:25 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 5 Jun 2023 06:49:25 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 5 Jun 2023 06:49:25 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 355BnO2n029775; Mon, 5 Jun 2023 06:49:24 -0500 Date: Mon, 5 Jun 2023 06:49:24 -0500 From: Nishanth Menon To: Neha Malcom Francis CC: , , , , , , , Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2: Change CPTS clock parent Message-ID: <20230605114924.56ccpd6rvddnr463@undying> References: <20230605110443.84568-1-n-francis@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230605110443.84568-1-n-francis@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_044933_944362_15F81E09 X-CRM114-Status: GOOD ( 17.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:34-20230605, Neha Malcom Francis wrote: > MAIN_PLL0 has a flag set in DM (Device Manager) that removes it's > capability to re-initialise clock frequencies. CPTS and RGMII has > MAIN_PLL3 as their parent which does not have this flag. While RGMII > needs this reinitialisation to default frequency to be able to get > 250MHz with its divider, CPTS can not get its required 200MHz with its > divider. Thus, move CPTS clock parent on J721S2 from MAIN_PLL3_HSDIV1 to > MAIN_PLL0_HSDIV6. > > (Note: even GTC will be moved from MAIN_PLL3 to MAIN_PLL0 in U-Boot side > for the same reason) > > Signed-off-by: Neha Malcom Francis > --- > arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 ++ > arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 ++ Is this the only device with this change? or are we doing that across the board? if so, could you please do this in a single series so that we don't have a mix? > 2 files changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > index 2dd7865f7654..331e0c9b4db8 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > @@ -738,6 +738,8 @@ cpts@310d0000 { > reg-names = "cpts"; > clocks = <&k3_clks 226 5>; > clock-names = "cpts"; > + assigned-clocks = <&k3_clks 226 5>; /* NAVSS0_CPTS_0_RCLK */ > + assigned-clock-parents = <&k3_clks 226 7>; /* MAIN_0_HSDIVOUT6_CLK */ > interrupts-extended = <&main_navss_intr 391>; > interrupt-names = "cpts"; > ti,cpts-periodic-outputs = <6>; > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > index a353705a7463..b55a3e9daf85 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > @@ -333,6 +333,8 @@ cpts@3d000 { > reg = <0x0 0x3d000 0x0 0x400>; > clocks = <&k3_clks 29 3>; > clock-names = "cpts"; > + assigned-clocks = <&k3_clks 29 3>; /* CPTS_RFT_CLK */ > + assigned-clock-parents = <&k3_clks 29 5>; /* MAIN_0_HSDIVOUT6_CLK */ > interrupts-extended = <&gic500 GIC_SPI 858 IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "cpts"; > ti,cpts-ext-ts-inputs = <4>; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel