From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAC0DC77B73 for ; Mon, 5 Jun 2023 20:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c0FOhn3iw6Efaa1dU/rqaT4QFAyKwj1DTWYa1knQWHU=; b=fZKFrRC0opL1yg ZUK5nm1T2pV2z4WbT6V6C17mcW06rrNJ3ZOP15BUxY0nFJzivRZxyrmPhohOv075uTSbK5UPmqmLt YqB5wcm9WGkSkTZjOpyfS3DGcmyJvbcB1KoFemzfo6S2a6whkrOpxbtV0f903gzwzkK3v4tVBUgqY EY4xGHfGVmp5x71PiS16E8hI7s5uX2Sa9lrofJf73jEEoHQ0w2uiV5i9oqKJUrWsBGErGrgLS7juK QeWhgN31wi9tfJjaR6ElJgB1BMql2dl8yJhTRCuk3TQvbiKEDNOVf4209LOVEEvUNUS8QrNwvZTE9 YGR1X7EXt3Yl2+l9/Bog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6Guk-00GjKl-36; Mon, 05 Jun 2023 20:34:54 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6Guh-00GjK4-1f for linux-arm-kernel@lists.infradead.org; Mon, 05 Jun 2023 20:34:53 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 355KYjRj039900; Mon, 5 Jun 2023 15:34:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1685997285; bh=owfzNXjgRIhds0kf9ztj9jjDbFO7AWNXIHw+Ae0od9g=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=ZUgyNaxRqzm0UrGn0CGrMgmkSZzm/SjbzzFib5wVmwVC8Xm2soyo2+0R9AyzcCvXs M61kaAY8eqpaMmTPbuFV8EyA1nGkBL1JVwRN4ebIFoZGOeEwmzLnVb2l/tVn76HHUz 6nkiCbfIu+OxMd8UWFVknoBSBfD83/Zfh40PkVbA= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 355KYjth125048 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Jun 2023 15:34:45 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 5 Jun 2023 15:34:45 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 5 Jun 2023 15:34:45 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 355KYjN2021312; Mon, 5 Jun 2023 15:34:45 -0500 Date: Mon, 5 Jun 2023 15:34:45 -0500 From: Nishanth Menon To: CC: , , , , , , , , Dasnavis Sabiya Subject: Re: [PATCH] arm64: dts: ti: k3-am69-sk: Enable MCU CPSW2G Message-ID: <20230605203445.z3ducpq7pr74m56c@evident> References: <20230605174202.159278-1-sabiya.d@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230605174202.159278-1-sabiya.d@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_133451_681649_46A54932 X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23:12-20230605, sabiya.d@mistralsolutions.com wrote: > From: Dasnavis Sabiya > > Add device tree support to enable MCU CPSW for AM69 SK > > Signed-off-by: Dasnavis Sabiya Does'nt https://lore.kernel.org/linux-arm-kernel/20230602214937.2349545-6-nm@ti.com/ address this? I already CCed you, so do you care to ack instead? OR provide review comments so that I can improve the patch? > --- > arch/arm64/boot/dts/ti/k3-am69-sk.dts | 50 +++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts > index bc49ba534790..4b7d9280d76f 100644 > --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts > @@ -104,6 +104,32 @@ vdd_sd_dv: regulator-tlv71033 { > }; > }; > > +&wkup_pmx0 { > + mcu_cpsw_pins_default: mcu-cpsw-pins-default { > + pinctrl-single,pins = < > + J784S4_WKUP_IOPAD(0x094, PIN_INPUT, 0) /* (A35) MCU_RGMII1_RD0 */ > + J784S4_WKUP_IOPAD(0x090, PIN_INPUT, 0) /* (B36) MCU_RGMII1_RD1 */ > + J784S4_WKUP_IOPAD(0x08c, PIN_INPUT, 0) /* (C36) MCU_RGMII1_RD2 */ > + J784S4_WKUP_IOPAD(0x088, PIN_INPUT, 0) /* (D36) MCU_RGMII1_RD3 */ > + J784S4_WKUP_IOPAD(0x084, PIN_INPUT, 0) /* (B37) MCU_RGMII1_RXC */ > + J784S4_WKUP_IOPAD(0x06c, PIN_INPUT, 0) /* (C37) MCU_RGMII1_RX_CTL */ > + J784S4_WKUP_IOPAD(0x07c, PIN_OUTPUT, 0) /* (D37) MCU_RGMII1_TD0 */ > + J784S4_WKUP_IOPAD(0x078, PIN_OUTPUT, 0) /* (D38) MCU_RGMII1_TD1 */ > + J784S4_WKUP_IOPAD(0x074, PIN_OUTPUT, 0) /* (E37) MCU_RGMII1_TD2 */ > + J784S4_WKUP_IOPAD(0x070, PIN_OUTPUT, 0) /* (E38) MCU_RGMII1_TD3 */ > + J784S4_WKUP_IOPAD(0x080, PIN_OUTPUT, 0) /* (E36) MCU_RGMII1_TXC */ > + J784S4_WKUP_IOPAD(0x068, PIN_OUTPUT, 0) /* (C38) MCU_RGMII1_TX_CTL */ > + >; > + }; > + > + mcu_mdio_pins_default: mcu-mdio-pins-default { > + pinctrl-single,pins = < > + J784S4_WKUP_IOPAD(0x09c, PIN_OUTPUT, 0) /* (A36) MCU_MDIO0_MDC */ > + J784S4_WKUP_IOPAD(0x098, PIN_INPUT, 0) /* (B35) MCU_MDIO0_MDIO */ > + >; > + }; > +}; > + > &main_pmx0 { > main_uart8_pins_default: main-uart8-pins-default { > pinctrl-single,pins = < > @@ -178,3 +204,27 @@ &main_sdhci1 { > &main_gpio0 { > status = "okay"; > }; > + > +&mcu_cpsw { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&mcu_cpsw_pins_default>; > +}; > + > +&davinci_mdio { > + pinctrl-names = "default"; > + pinctrl-0 = <&mcu_mdio_pins_default>; > + > + mcu_phy0: ethernet-phy@0 { > + reg = <0>; > + ti,rx-internal-delay = ; > + ti,fifo-depth = ; > + ti,min-output-impedance; > + }; > +}; > + > +&mcu_cpsw_port1 { > + status = "okay"; > + phy-mode = "rgmii-rxid"; > + phy-handle = <&mcu_phy0>; > +}; > -- > 2.25.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel