From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EA32C7EE23 for ; Mon, 5 Jun 2023 20:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j3htYAuwxyi4E/vP47kumcpH7ZztDotIHnroLHs6VzA=; b=sinTFlN4FHOGly qn/1EFAmziL8ltcJSBb+2OABaZq0xDFNoABgKk3EvfhwwgQxFvDszj2i0G+BcqYzmYhv7QzHbt8WF fbYjdDqbmFu5ReXM4DoJ3UnmNj1uX1mHFS/l6RMvT11u5uAL1k0UoHtDP0f0saWC4N1IVbNQ5ASPp 2dEkTzlo66QHs8tAWESz6ouUWIA5UsSz370lc3GLWNtkEylEMBBn4ZztZHwxIzuSxEpUoks9Rtk2l i4um1jzmZRrtVlnhNukBG5kJW3cIuqCeD+Y6BfsOiEb5Ga9n41EMdP2xnH1/AA+1S3wmAgctROFGO ftB4qjwhIPJN1xtOS/ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6H9k-00GlRL-0Z; Mon, 05 Jun 2023 20:50:24 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6H9h-00GlQa-2h for linux-arm-kernel@lists.infradead.org; Mon, 05 Jun 2023 20:50:23 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 355KoIKC128194; Mon, 5 Jun 2023 15:50:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1685998218; bh=tO+k7Zn8F/wSJ0dZCxs7VvPqaIsdUBQr/Rr4NTkvxzw=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=eu+AL3GUWg3DktOLwQdwn7WAse8LEUzOLiZ1+Sx/LjK+eJPp9Ik4Qs+HDdLL6RmKy Kja8iHwykvutlsn7BulPXWJKTl8F3pAD8h97vdE23hOUku3hLvztCYtRbhfvLlYj3R QsK9vRCg1EPnBeY83VMydHYFpP58hU32pO64u/dc= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 355KoIFO011724 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Jun 2023 15:50:18 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 5 Jun 2023 15:50:18 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 5 Jun 2023 15:50:18 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 355KoIqO108346; Mon, 5 Jun 2023 15:50:18 -0500 Date: Mon, 5 Jun 2023 15:50:18 -0500 From: Nishanth Menon To: "Kumar, Udit" CC: Conor Dooley , Krzysztof Kozlowski , Rob Herring , , , , Tero Kristo , Vignesh Raghavendra Subject: Re: [PATCH 08/12] arm64: dts: ti: k3-am64-evm: Fixup reference to phandles array Message-ID: <20230605205018.4j3eq6vctfyc65i2@platypus> References: <20230601152636.858553-1-nm@ti.com> <20230601152636.858553-9-nm@ti.com> <720c8c43-9a95-d7b5-3267-405ff0149eea@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <720c8c43-9a95-d7b5-3267-405ff0149eea@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_135021_958479_D4CCD8BC X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22:32-20230605, Kumar, Udit wrote: > Hi Nishanth > = > On 6/1/2023 8:56 PM, Nishanth Menon wrote: > > When referring to array of phandles, using <> to separate the array > > entries is better notation as it makes potential errors with phandle and > > cell arguments easier to catch. Fix the outliers to be consistent with > > the rest of the usage. > > = > > Signed-off-by: Nishanth Menon > > --- > > arch/arm64/boot/dts/ti/k3-am642-evm.dts | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > = > > diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/= dts/ti/k3-am642-evm.dts > > index 91bdc6026d1f..fef68a778ac9 100644 > > --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts > > +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts > > @@ -467,8 +467,8 @@ &usb0 { > > &cpsw3g { > > pinctrl-names =3D "default"; > > - pinctrl-0 =3D <&rgmii1_pins_default > > - &rgmii2_pins_default>; > > + pinctrl-0 =3D <&rgmii1_pins_default>, > > + <&rgmii2_pins_default>; > = > = > Please see, if=A0 pinctrl-0 can be defined in one line, instead of two, t= o be > inline with most of changes in this series. OK. I think i can respin it with that style change included once other comments flow in. -- = Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5= 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel