From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C6A1C7EE37 for ; Tue, 6 Jun 2023 19:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7d/t/C2QJjrkXAbBfO2rF7Q1BWob8mlyNGbqZC7qDCg=; b=VsWL/2+1rq0zKMlyUkA6wOLjzZ mTHoDljIok8jY2BZ4dVeL/5NOgWGik2iWD4mJk9QKkVJy2exGpreSNwTFF67+X04LLYLRTcGU2O4e HEpP1l+nQa9/lD7QyY7pJwk6PdvYG7zyDB5TdyIDipYwHg9Dxw2XM9ETTAHGHPIvPJc/NYZ//bguF kWdBqAKQc44+jpSDuhC71++1oarELM1gegyHeor03Wkm7ToXwrA18R0IgPFYRPKf32DC6Gj7XEVAO HiQ7ZlMXYfXxbWbQjbzQTfav0OGd97vIGF9mAlstEFF+vTkhueIW/McGiIISQnxOSLikzkxx/l8n/ HEEwy/ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6cRp-002z8o-2P; Tue, 06 Jun 2023 19:34:29 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6cRm-002z7z-2F for linux-arm-kernel@lists.infradead.org; Tue, 06 Jun 2023 19:34:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 032D162CC6; Tue, 6 Jun 2023 19:34:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09098C433EF; Tue, 6 Jun 2023 19:34:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686080065; bh=8EDy4g29/S1znokLB5vVfHAJxVY5fZMjbfEqX1hXCIg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rXH3zcoAlzdEziIvREJLGbqv7b0siwY2St8YFPs48fjOXSXcK/FnTSFRFTlyeU8Yi 6mPDJCVuQCxAmGGEeCZlzdjtesngxFnNr0AWr0gKp0T2wzYv/4b+flPcAyI10v/WrE l2gy7ny0qQcEIgCCetF8OKjh+N2unGy3czLwoqkbjO7ux3Bp+tMyrzbV2OVpL8iYzB YiV6NWZ4xg1NFF51JvAj3pE8H/jFbuqZG0i3GmE9oVnhJDXTDNQJKYEdHUa5r2pB6j F6rF5yauHE052wUtg25MKOPsYupflVncVdn3aB2A2FQ4f3A1FpiM4eiZobdjdI4K+i qjO6oNuxqL6Vg== Date: Tue, 6 Jun 2023 20:34:18 +0100 From: Conor Dooley To: Liu Ying Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, peng.fan@nxp.com, marex@denx.de Subject: Re: [PATCH v3 1/2] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example Message-ID: <20230606-value-backfire-31e3ebf79071@spud> References: <20230605062217.3716328-1-victor.liu@nxp.com> <20230605062217.3716328-2-victor.liu@nxp.com> MIME-Version: 1.0 In-Reply-To: <20230605062217.3716328-2-victor.liu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230606_123426_843492_8D9CEAFB X-CRM114-Status: GOOD ( 18.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0249033704909621454==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0249033704909621454== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7YMIkTsAzSlnN58N" Content-Disposition: inline --7YMIkTsAzSlnN58N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 05, 2023 at 02:22:16PM +0800, Liu Ying wrote: > i.MX93 SoC mediamix blk-ctrl contains one DISPLAY_MUX register which > configures parallel display format by using the "PARALLEL_DISP_FORMAT" > field. Document the Parallel Display Format Configuration(PDFC) subnode > and add the subnode to example. The previous issues seem to be resolved & what you've got here looks fine to me. Perhaps Krzysztof will disagree! Reviewed-by: Conor Dooley Cheers, Conor. >=20 > Signed-off-by: Liu Ying > --- > v2->v3: > * Newly introduced to replace the standalone dt-binding in v1 and v2. (Ro= b) >=20 > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-bl= k-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk= -ctrl.yaml > index b3554e7f9e76..3f550c30d93d 100644 > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.= yaml > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.= yaml > @@ -24,6 +24,12 @@ properties: > reg: > maxItems: 1 > =20 > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 1 > + > '#power-domain-cells': > const: 1 > =20 > @@ -46,9 +52,43 @@ properties: > - const: csi > - const: dsi > =20 > + bridge@60: > + type: object > + additionalProperties: false > + > + properties: > + compatible: > + const: nxp,imx93-pdfc > + > + reg: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Input port node to receive pixel data. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Output port node to downstream pixel data recei= vers. > + > + required: > + - port@0 > + - port@1 > + > + required: > + - compatible > + - reg > + - ports > + > required: > - compatible > - reg > + - '#address-cells' > + - '#size-cells' > - power-domains > - clocks > - clock-names > @@ -76,5 +116,33 @@ examples: > <&clk IMX93_CLK_MIPI_DSI_GATE>; > clock-names =3D "apb", "axi", "nic", "disp", "cam", > "pxp", "lcdif", "isi", "csi", "dsi"; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > #power-domain-cells =3D <1>; > + > + bridge@60 { > + compatible =3D "nxp,imx93-pdfc"; > + reg =3D <0x60 0x4>; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@0 { > + reg =3D <0>; > + > + pdfc_from_lcdif: endpoint { > + remote-endpoint =3D <&lcdif_to_pdfc>; > + }; > + }; > + > + port@1 { > + reg =3D <1>; > + > + pdfc_to_panel: endpoint { > + remote-endpoint =3D <&panel_from_pdfc>; > + }; > + }; > + }; > + }; > }; > --=20 > 2.37.1 >=20 --7YMIkTsAzSlnN58N Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZH+KOgAKCRB4tDGHoIJi 0qTUAQCAIwEDBspj50xb8vJZ/cAzeXcU63walAvS9ME3SUbkpQD/QTiKL9oMyANI GF2+4FaL98JVFt3B1Mh/fCmqgsboigg= =Jctj -----END PGP SIGNATURE----- --7YMIkTsAzSlnN58N-- --===============0249033704909621454== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0249033704909621454==--