From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16ECCC7EE29 for ; Wed, 7 Jun 2023 13:08:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RTPhOOIbLJIlhxaPAgMKJH2Ocn+xzCC5KjtgX089rNI=; b=BF/9yIpvkArhfP ZqnuaG3+Nmm8zsB0P62Y645Y0Sk75L/RYz19fnaTEeqA2yQ3okR3Jf2LUAdTiVhE7TDgSdSo6C84b Vk72Ram1ORF0jJpsJifKeYMYznt6ZeLaFyc+GWeQKCymEa1ORu3Isd/hJ9h6YRgAclUU/c7M1ZoSH xc2f0Ph+/Wk3py3QpIp53fC+J+9FOsk3JzySltUOM0KNBmjj7RWy6Q8sVqCSq+q8aImA66gu0oFMK RnEZr8cYYXIoYlj5SkFGZqo+VRcudQxDzJUXJ3y1XNO7J5dd2uoFuU49LAAvXZWxLh7nZTM4RedlE WBo/5wwdfYmTeWMOzsnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6stE-0061E9-2X; Wed, 07 Jun 2023 13:07:52 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6stA-006174-2w for linux-arm-kernel@lists.infradead.org; Wed, 07 Jun 2023 13:07:50 +0000 X-GND-Sasl: maxime.chevallier@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1686143259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t4KeBVX9fh5BWILoxWykoaXgMPfgR3e6KlRWLXnIjh8=; b=IFlntwt9MiUqyl4gGig/vm8dRCZC9qibzaOkFWfioFD80JRYgMO4LmWNjxgQr50TutwLfL 05B0xsTMGMwWVjpZwuPpuxLAhlsUTUbqZcsWhTbx+Uyyqp38lAo/JTMwg/lo1qSo7JjoEq G/RmfirGiBqZE4bbsfw5J2R8aC3PzSraNp7N3wcWT4uy9DHcTyYMvf68IZ5rBX7ohTInTv UtIG93n4Pgd+bH2Dr73zbIQWO8tNPaRKTa0Op7fePe9XPgDMhJRfV4AiPgxOs8j1JR8dHA AdkROzL0P3ToQ5P822B9nOrlM3vmH7IseBuir7V4Qzsqm3CnoYtTCS3jjLWGKA== X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id B1E1920012; Wed, 7 Jun 2023 13:07:32 +0000 (UTC) Date: Wed, 7 Jun 2023 16:54:09 +0200 From: Maxime Chevallier To: "Russell King (Oracle)" Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro , Simon Horman , Maciej Fijalkowski , Feiyang Chen Subject: Re: [PATCH net-next v4 5/5] net: dwmac_socfpga: initialize local data for mdio regmap configuration Message-ID: <20230607165409.7fddd49a@pc-7.home> In-Reply-To: References: <20230607135941.407054-1-maxime.chevallier@bootlin.com> <20230607135941.407054-6-maxime.chevallier@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_060749_212024_63F8755A X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 7 Jun 2023 13:28:03 +0100 "Russell King (Oracle)" wrote: > On Wed, Jun 07, 2023 at 03:59:41PM +0200, Maxime Chevallier wrote: > > @@ -447,19 +446,22 @@ static int socfpga_dwmac_probe(struct platform_device *pdev) > > struct mdio_regmap_config mrc; > > struct regmap *pcs_regmap; > > struct mii_bus *pcs_bus; > > > ... > > + memset(&mrc, 0, sizeof(mrc)); > ... > > mrc.parent = &pdev->dev; > > mrc.valid_addr = 0x0; > > + mrc.autoscan = false; > > Isn't this covered by the memset() ? I have the same answer as for the above. It's redundant, but I don't think there's any harm having it set explicitely ? Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel