From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED9C3C7EE23 for ; Thu, 8 Jun 2023 16:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5SkONnZTq2+4vzm3S7KyHigAXan0WfaAn1NdSMfAdq4=; b=5FXiFQDudQW6qMZXzQUqglI7CV 2BVDGgYN6TB8hZZfUkt/OIpmmmRSwThDCOGaZyuTXQXOFlOBDiHPZz0CumPTvQV1t5rI+lARlegCV 5SJzcpNR/TWNLdOwdho8/4MBXsUJOtCoGXxw3FOJVUIzAFTnDtXOXrmRqqJvEcvcCsCJD68JOLyFF MTCdUjnTIC47Os2tIJ1ZQhhsiDTOIdfglt2o0l45CJul6M34nyKhqWfYeTQs81h1Gw6HC/qKg7BvE Ac2D5PtpMHNkVK2huf7num0NAP+8IfIdfzqhx8HstZtnjAaURx1moP289vKW9xK/LUTzTHixkjhPc g/iC5a1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7IoV-009wrN-0W; Thu, 08 Jun 2023 16:48:43 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7IoT-009wpw-0c; Thu, 08 Jun 2023 16:48:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5F4C264F7F; Thu, 8 Jun 2023 16:48:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87307C433EF; Thu, 8 Jun 2023 16:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686242917; bh=NItZle+oTrePZjmBVAT27mVwVfGQfOUwmTs+qmzGn6k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VuOb+jLe1WtbWqLUUym3QtQf1tvdlFkuQfkXMyt7i0SeMBl4Z5PMy/JBo/3J7StOa z13cXGwocgTkgqyZgejt0LSDiFJsSOlThO+7ClDdUklpU8a7ZdYDirSE1H56uiEfQt /44/2dX0GDtyh//EgAJRFSLbhXfGUYmEjy1HeV14GEaRd9tJ0mFC+FIWAzKQiW+FkK FsKUIo2Yx8vrLWVxJYbaRGLw2Xn5y+2XBhv2JvajneWwp2jVcF/oXznmkX7wCCrDFH NP3Otfho+XBrV6YQV8JoN2PDCovVIB2Ij1BdnNlHf7CUrBvaekN5RuTCZgzSmCqmcr PYDrrXuIM9eSg== Date: Thu, 8 Jun 2023 17:48:32 +0100 From: Conor Dooley To: =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado Cc: Matthias Brugger , Hans Verkuil , kernel@collabora.com, AngeloGioacchino Del Regno , Andrew-CT Chen , Conor Dooley , Krzysztof Kozlowski , Mauro Carvalho Chehab , Rob Herring , Tiffany Lin , Yunfei Dong , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 2/5] media: dt-bindings: mediatek,vcodec: Remove VDEC_SYS for mt8183 Message-ID: <20230608-helping-regally-3ce781f6d8ec@spud> References: <20230607205714.510012-1-nfraprado@collabora.com> <20230607205714.510012-3-nfraprado@collabora.com> MIME-Version: 1.0 In-Reply-To: <20230607205714.510012-3-nfraprado@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_094841_313497_F25131DD X-CRM114-Status: GOOD ( 22.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3807746366385945691==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3807746366385945691== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bqm2BrX9NmqPaHSz" Content-Disposition: inline --bqm2BrX9NmqPaHSz Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 07, 2023 at 04:53:39PM -0400, N=EDcolas F. R. A. Prado wrote: > The binding expects the first register space to be VDEC_SYS. But on > mt8183, which uses the stateless decoders, this space is used only for > controlling clocks and resets, which are better described as separate > clock-controller and reset-controller nodes. >=20 > In fact, in mt8173's devicetree there are already such separate > clock-controller nodes, which cause duplicate addresses between the > vdecsys node and the vcodec node. But for this SoC, since the stateful > decoder code makes other uses of the VDEC_SYS register space, it's not > straightforward to remove it. >=20 > In order to avoid the same address conflict to happen on mt8183, > since the only current use of the VDEC_SYS register space in > the driver is to read the status of a clock that indicates the hardware > is active, remove the VDEC_SYS register space from the binding and > describe an extra clock that will be used to directly check the hardware > status. >=20 > While adding the active clock, split the mt8183 clocks since there are > less of them than in mt8173. This is done in this same commit to avoid > changing the number of clocks twice. >=20 > Also add reg-names to be able to tell that this new register schema is > used, so the driver can keep backward compatibility. Rationale here seems to make sense to me & seems like whatever functionality, or lack thereof, for the mt8183 will be preserved w/ the old devicetree. Reviewed-by: Conor Dooley Cheers, Conor. --bqm2BrX9NmqPaHSz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZIIGXwAKCRB4tDGHoIJi 0l6GAP9Fj0Yzci2QZFnKHVu1ULZFD8JnPf07oxRvnEiMYMGg6gEAhC1nbdxyRxKx aw9kQMvf0BpeAZuX8VEoKUTSBCMZAwQ= =K2/N -----END PGP SIGNATURE----- --bqm2BrX9NmqPaHSz-- --===============3807746366385945691== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3807746366385945691==--