From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D470C7EE25 for ; Thu, 8 Jun 2023 08:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8VTAvzxYmYtB3/zaaTf8jJaeppj62SsNWg4o1J8NmHg=; b=MQpY47p+Cm5EOr l9zwwLwmxIO1u24rsrq3tadT6YNn4LRItCVcrQczLGpa1lA7e/VsxWn0IhMd9H4IPw0jKNAYbknS7 tceItFk7KmEpBCyfAt/dtZ7tEZCIsU17Kn0fX/7t2DMkWZgiknyRIvyKBzxKgSLwKTMVDvlfH0wMb RJdQHO5829J1M3fLnxSEe8OhjgTS12Dw/zPdOJW8QgPAtaJfyjkl5I0j5fmH4lI5Vfie1ikDf3ve2 hq0tPuXb5py4hhG77lmFHbty96oxhCQbjtLJqrQwTlp6eJ6voo+S+JgxBlPLKQVuFEqOWJKOXnrU9 AhNoHwp6poEWpanyWiAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7BQi-008c9k-36; Thu, 08 Jun 2023 08:55:40 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7BQh-008c7L-0O for linux-arm-kernel@lists.infradead.org; Thu, 08 Jun 2023 08:55:40 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5A7C780E0; Thu, 8 Jun 2023 08:55:35 +0000 (UTC) Date: Thu, 8 Jun 2023 11:55:34 +0300 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Nishanth Menon , Vignesh Raghavendra , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v6 1/1] dt-bindings: pinctrl: Update pinctrl-single to use yaml Message-ID: <20230608085534.GE14287@atomide.com> References: <20230605095216.18864-1-tony@atomide.com> <20230608063639.GD14287@atomide.com> <19710587-533c-f6df-9842-06a8e2db263c@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <19710587-533c-f6df-9842-06a8e2db263c@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_015539_196551_3626443B X-CRM114-Status: GOOD ( 13.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Krzysztof Kozlowski [230608 06:57]: > On 08/06/2023 08:36, Tony Lindgren wrote: > > * Krzysztof Kozlowski [230607 18:17]: > >> On 05/06/2023 11:52, Tony Lindgren wrote: > >>> +patternProperties: > >>> + '-pins$|-pin': > >> > >> you did not implement my comments fully, probably we misunderstood each > >> other. Why do you allow anything after '-pin'? Let's make it pure suffix > >> for both cases: '-pins?$' > > > > I'll check what kind of node renaming that would cause. At least TI > > arm64 SoCs use naming like -pins-default and -pins-wakeup. Is your > > preference to rename all those nodes to -default-pins and -wakeup-pins? > > No, pattern matching TI SoC is fine, but your current also doesn't. Or > rather - matches by mistake. You do not allow anything after -pins. So after the earlier dts node name clean-up, looks like it's only few hundred TI pins to rename. Not sure I want to add SoC specific handling for TI. Folks will try to use -pins-default, -pins-sleep, -pins-idle etc.. How about let's just fix the remaining dts files and then we can only allow -pin or -pins suffix? The match would be just '-pins$|-pin$ with a preference for -pins as it's a group that might get more pins added to it later on. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel