From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 781C2C7EE23 for ; Thu, 8 Jun 2023 17:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CqwkmK4wo//RUjWKRY1ie0rc28f470E584nq0QpXgpo=; b=LjOcddnRi+IAU6 szrvDkQ9+GeSpStRBT4eWrjox5aqztoV8uygz7QGaoSfncKbJUPm6AzAsyBW05JEx1H979/32UteJ ns8NsMRAwiE9+SK0cPQ/2xeBCjXIG4bru7nupixrsb5YtCkm9+Cm8w7+Nxd6IeRUIdOpr93oSqC15 Y9yT8d5oVUNDMt4R1bNcgd66zL5bStJRNVzywvFATH2iD7ox4rQ/NwJL/GREUfqCf52VVmyBO4Xam YOxsRDmwwsnB1qv8DfCvBWcDTpQNTn3gKBj2yh7ERKH/6218ropy1wlwONUfVT3rT/hJawR3fRWrt xdOQxkK1eBBz6UhHUONQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7JH4-00A0vf-1f; Thu, 08 Jun 2023 17:18:14 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7JH0-00A0u4-2m for linux-arm-kernel@lists.infradead.org; Thu, 08 Jun 2023 17:18:12 +0000 X-GND-Sasl: maxime.chevallier@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1686244685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JloVVkRUCrOBf964M9cSz6IG1kWpPZ1DM7vwOfF5Jy8=; b=ZmAd4v3AspZjOKuyH1fbC7yCuK6o2qMvN0DP1LsVo/o9uIj9QAy7oWM/DYwu3x5I1EqZul kCFwten5eXWftRKNgRhitus5GElXFFtJnUk8vk15eYIzPrptd4B9nUWlt+UPzAD0A2AS/x 1QxbpzOFvxbuY/vp8QiDbFih02N2uDmOM0l3echMF2uaDfaVAiNEGodgEf0g3nAM8oYZK1 J7QBQvYngtFpIqBPzcT9MkEz5+n1a/O4xtjhLhE4yWi7pznDShc3oJ8e6X/9UEY1Eacyjm OXnWOeg9STcqJB5sGmNwxEM3icq7VKKJghB4B3U0k9jmLRju3mq+tBtJRHTBiQ== X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com X-GND-Sasl: maxime.chevallier@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id E09CD60003; Thu, 8 Jun 2023 17:18:03 +0000 (UTC) Date: Thu, 8 Jun 2023 19:53:30 +0200 From: Maxime Chevallier To: "Russell King (Oracle)" Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , linux-arm-kernel@lists.infradead.org, Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com, UNGLinuxDriver@microchip.com, Vladimir Oltean Subject: Re: [PATCH net 2/2] net: phylink: use USXGMII control-word format to parse Q-USGMII word Message-ID: <20230608195330.476fca86@pc-7.home> In-Reply-To: References: <20230608163415.511762-1-maxime.chevallier@bootlin.com> <20230608163415.511762-4-maxime.chevallier@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_101811_206399_49D1191C X-CRM114-Status: GOOD ( 13.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, On Thu, 8 Jun 2023 17:32:52 +0100 "Russell King (Oracle)" wrote: > On Thu, Jun 08, 2023 at 06:34:15PM +0200, Maxime Chevallier wrote: > > diff --git a/include/uapi/linux/mdio.h b/include/uapi/linux/mdio.h > > index 256b463e47a6..1d20a9082507 100644 > > --- a/include/uapi/linux/mdio.h > > +++ b/include/uapi/linux/mdio.h > > @@ -444,4 +444,7 @@ static inline __u16 mdio_phy_id_c45(int prtad, int devad) > > #define MDIO_USXGMII_5000FULL 0x1a00 /* 5000Mbps full-duplex */ > > #define MDIO_USXGMII_LINK 0x8000 /* PHY link with copper-side partner */ > > > > +/* Usgmii control word is based on Usxgmii, masking away 2.5, 5 and 10Gbps */ > > +#define MDIO_USGMII_SPD_MASK 0x0600 > > This isn't correct: > > 11:9 Speed: Bit 11, 10, 9: > 1 1 1 to 011 = Reserved > 0 1 0 = 1000 Mbps: 1000BASE-TX, 1000BASE-X > 0 0 1 = 100 Mbps: 100BASE-TX, 100BASE-FX > 0 0 0 = 10 Mbps: 10BASET, 10BASE2, 10BASE5 > > If we only look at bits 10 and 9, then we're interpreting the reserved > combinations as valid as well. That's why I rewrote the decoding helper instead of simply masking away the extra bit, so that we exclude the 0 1 1 combination ( 10G speed ). The comment is wrong though. This patch set needs more coffee, Best regards, Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel