Re: [PATCH 1/9] regulator: dt-bindings: mt6358: Merge ldo_vcn33_* regulators

Matthias Brugger
2023-06-09T15:47:51Z

On 09/06/2023 10:29, Chen-Yu Tsai wrote:
> The ldo_vcn33_bt and ldo_vcn33_wifi regulators are actually the same
> regulator, having the same voltage setting and output pin. There are
> simply two enable bits that are ORed together to enable the regulator.
>
> Having two regulators representing the same output pin is misleading
> from a design matching standpoint, and also error-prone in driver
> implementations.
>
> Merge the two as ldo_vcn33. Neither vcn33 regulators are referenced
> in upstream device trees. As far as hardware designs go, none of the
> Chromebooks using MT8183 w/ MT6358 use this output.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
> .../bindings/regulator/mt6358-regulator.txt | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
> index 7034cdca54e0..b22b956d1cbe 100644
> --- a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
> @@ -15,8 +15,7 @@ LDO:
> ldo_vcamd, ldo_vcn18, ldo_vfe28, ldo_vsram_proc11, ldo_vcn28, ldo_vsram_others,
> ldo_vsram_others_sshub, ldo_vsram_gpu, ldo_vxo22, ldo_vefuse, ldo_vaux18,
> ldo_vmch, ldo_vbif28, ldo_vsram_proc12, ldo_vcama1, ldo_vemc, ldo_vio28, ldo_va12,
> - ldo_vrf18, ldo_vcn33_bt, ldo_vcn33_wifi, ldo_vcama2, ldo_vmc, ldo_vldo28, ldo_vaud28,
> - ldo_vsim2
> + ldo_vrf18, ldo_vcn33, ldo_vcama2, ldo_vmc, ldo_vldo28, ldo_vaud28, ldo_vsim2
>
> Example:
>
> @@ -305,15 +304,8 @@ Example:
> regulator-enable-ramp-delay = <120>;
> };
>
> - mt6358_vcn33_bt_reg: ldo_vcn33_bt {
> - regulator-name = "vcn33_bt";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3500000>;
> - regulator-enable-ramp-delay = <270>;
> - };
> -
> - mt6358_vcn33_wifi_reg: ldo_vcn33_wifi {
> - regulator-name = "vcn33_wifi";
> + mt6358_vcn33_reg: ldo_vcn33 {
> + regulator-name = "vcn33";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3500000>;
> regulator-enable-ramp-delay = <270>;