From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3A4FC7EE2E for ; Fri, 9 Jun 2023 21:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ynzQQmFale588gCBL/q1QSLaNK3GZlIvC4doewg2nDU=; b=UHv+IJclOYK0x7 KQG7Xb+7sH2qDJHXZsnJ9WvneSsZjLvJsoE7JMycmrdKCMoVvExQf78Ek68yaCJjCbw2nVuHu23M4 dhoiBDC7bRD21I9I0dXER9LL/D2UCdpNpcW5EeHEOvxhaFU/Otc+sDH74afVD0HL3BdgM4i8ba8yN 2qGFmJFCEDU0uqN/AqNTTPFgWE53bVSlybGA1cM7CfSroS4uCtbHJZAH1zwVNWamonvZCNEOBsa6c /P9JHDsVCh/gF+sj3Q1P6kFAbdxVJbHSsucJgSeoBE4AuieqHf0occuGDH9GojDZuKGn3vccVDY5D xwRWbq/U3WKHQWxk8hoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7k4M-00EMF1-03; Fri, 09 Jun 2023 21:54:54 +0000 Received: from mail-il1-f174.google.com ([209.85.166.174]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7k4I-00EMEV-1m for linux-arm-kernel@lists.infradead.org; Fri, 09 Jun 2023 21:54:51 +0000 Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-33e585a0ca6so9522245ab.3 for ; Fri, 09 Jun 2023 14:54:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686347689; x=1688939689; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rJ4s8DLGxIQMZgO3h4yWSzjSw0o4+j3wjFGsywkwuyQ=; b=KMDtlPQbH2JV6+quVyaa8iIGda3Rs07XmzsEHq7oG92YrE9ofA4nzeFCVyflvJ4dVS v7EPiOqghk/MH6zVl6PXW/XUvjEngR5mzt/0H3hBKXoNu8msBwQaRJH8wmWqBMnOZL1r x1gr9RW6Ky+u44Lc2kWFjIxS+FCQszOhU0vutrAnyACuWN64ctN7r2a4qGrVAz/jyJ/6 g8Ol+OA8mhWgOQoj91YCuWNHJYVs6cNkSSxmJuyeo6Xd3jef0ZTR5HG4U9zi0LMECTFp ROJu0rdYwiX5QUe/QK2LInKiONApx8zCzhcFmcAKawCdCaN+SO/haPj9RciixNGtW1xH HA+g== X-Gm-Message-State: AC+VfDxkazhHai7ez4XJzPkLjJU3pbkpU5f9tsJG1vgNLVoD6VQM7MI3 7t97vcEkpwDNxSsomW3BEw== X-Google-Smtp-Source: ACHHUZ7asW6KLLFEuMl3Gpj9wEteHcFkfQtU+mBgAGx4LCseYTLClP89Gsdg7cl4uLoZoq/oLRK0Kw== X-Received: by 2002:a92:d690:0:b0:32b:50d1:3403 with SMTP id p16-20020a92d690000000b0032b50d13403mr2464164iln.7.1686347686371; Fri, 09 Jun 2023 14:54:46 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id k27-20020a02ccdb000000b0041aaebd2017sm1167046jaq.82.2023.06.09.14.54.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 14:54:45 -0700 (PDT) Received: (nullmailer pid 2528752 invoked by uid 1000); Fri, 09 Jun 2023 21:54:43 -0000 Date: Fri, 9 Jun 2023 15:54:43 -0600 From: Rob Herring To: Stefan Wahren Cc: Vinod Koul , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Ray Jui , Scott Branden , Jassi Brar , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-mmc@vger.kernel.org, linux-pwm@vger.kernel.org, linux-pm@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH 04/10] ARM: dts: bcm2835: adjust DMA nodes Message-ID: <20230609215443.GA2522299-robh@kernel.org> References: <20230604121223.9625-1-stefan.wahren@i2se.com> <20230604121223.9625-5-stefan.wahren@i2se.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230604121223.9625-5-stefan.wahren@i2se.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230609_145450_607969_B5BA10D1 X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jun 04, 2023 at 02:12:17PM +0200, Stefan Wahren wrote: > After converting the bcm2835-dma DT binding to YAML, the DT schema > checks gave warnings like: > > $nodename:0: 'dma@7e007000' does not match '^dma-controller(@.*)?$' > 'dma-channel-mask' is a required property > Unevaluated properties are not allowed ('brcm,dma-channel-mask' was unexpected) > > So fix them accordingly. > > Signed-off-by: Stefan Wahren > --- > arch/arm/boot/dts/bcm2711.dtsi | 4 ++-- > arch/arm/boot/dts/bcm2835-common.dtsi | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi > index 097e9f252235..83745672a120 100644 > --- a/arch/arm/boot/dts/bcm2711.dtsi > +++ b/arch/arm/boot/dts/bcm2711.dtsi > @@ -76,7 +76,7 @@ thermal: thermal { > }; > }; > > - dma: dma@7e007000 { > + dma: dma-controller@7e007000 { > compatible = "brcm,bcm2835-dma"; > reg = <0x7e007000 0xb00>; > interrupts = , > @@ -103,7 +103,7 @@ dma: dma@7e007000 { > "dma9", > "dma10"; > #dma-cells = <1>; > - brcm,dma-channel-mask = <0x07f5>; > + dma-channel-mask = <0x07f5>; You're breaking the ABI here. I'd think RPi users would care. You should either list both properties or just leave this as-is. You could also mark the driver "dma-channel-mask" support for stable and somewhat avoid the ABI issue. > }; > > pm: watchdog@7e100000 { > diff --git a/arch/arm/boot/dts/bcm2835-common.dtsi b/arch/arm/boot/dts/bcm2835-common.dtsi > index bb7e8f7facaf..3ba8db8eed0f 100644 > --- a/arch/arm/boot/dts/bcm2835-common.dtsi > +++ b/arch/arm/boot/dts/bcm2835-common.dtsi > @@ -8,7 +8,7 @@ / { > interrupt-parent = <&intc>; > > soc { > - dma: dma@7e007000 { > + dma: dma-controller@7e007000 { > compatible = "brcm,bcm2835-dma"; > reg = <0x7e007000 0xf00>; > interrupts = <1 16>, > @@ -46,7 +46,7 @@ dma: dma@7e007000 { > "dma14", > "dma-shared-all"; > #dma-cells = <1>; > - brcm,dma-channel-mask = <0x7f35>; > + dma-channel-mask = <0x7f35>; > }; > > intc: interrupt-controller@7e00b200 { > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel