From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65AA6C7EE2F for ; Mon, 12 Jun 2023 20:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TQGE2zx+2kI1cUiy5wMrEbWSqHsXprW80ZTTGD6w45c=; b=Vagxkefuu2bbb7 7V7fEDk6vQ0GF30lp0fgj8Ju1Xh9iXRpNXPujX+2fbAnWjV7vfjYCaz7aSiGZfIbHs2LMR5Tob5jn Xoz3VUA/CkKs4K5NEsfZ9QDcbn4FpzjyDf903ltuJYxxpMp5lervL7aD/jIYq70T6PuPmXhpoTizg lw+/IY3agXjmbNUrkG+vfqFwBhZEHSUD10WV/fjrRErylX8o9jS9LdsSnqpQBUo6WUzzhFK2watSc F3WHHxV6Ix75KSfF59MGGmSXeGogUjZctO28SjVePHJNthQn76+EaLN2E+pA4BvrAQ5ZKI9xL5tNb h0D6EnCH9t6tbgX1n7lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8oLL-005J8i-2B; Mon, 12 Jun 2023 20:40:51 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8oLI-005J4l-1g for linux-arm-kernel@lists.infradead.org; Mon, 12 Jun 2023 20:40:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686602447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+GICplP/MT1isAH+ok2l+9fKNc3rvvMZkj74HkVOtyg=; b=HZb4b7DF1KJD+PD54kOwh8oUXEN1DjN5oyTSoWWcoM6dThxgpjpqgck3J0C9KGjIjAVmWZ mWYjyoVs4f74U5YyY4goTjMRDrA7UGAwGy9fIuZ0xQsM1Lalgp4JHNLWo7AQWNLba/niJz 5Pz08+6aFVkjq1SjCGYDIcltIG/dGLA= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-192-Zf7POIqwNzW6jLw4zcv7JQ-1; Mon, 12 Jun 2023 16:40:46 -0400 X-MC-Unique: Zf7POIqwNzW6jLw4zcv7JQ-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-5695f6ebd85so68584867b3.3 for ; Mon, 12 Jun 2023 13:40:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686602445; x=1689194445; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+GICplP/MT1isAH+ok2l+9fKNc3rvvMZkj74HkVOtyg=; b=KarAcVJ7E+YpT1peP0woKA9r9G3Qo2JaXcs6uaTNS9UZyQ8Cn0tuJJZcqpVEI6GxpK V8Jguw0REJoAKoOHkUhhOTRlRmEvoqOSBmvJUAiF/4K+tAUrHOo6o1/AyUwfxTmoTwsY eJM19zhqT5EFzE7OBjWw1FKA55C7eyvHkhohWhPeQMHTAmOsWXgurEZE2KmCxhCZhLAF 3rEODfQFcqPGoSVzANIiRqa26Ne7l4MiSnO3U7SsFHMZC3lMwFVFJooJuvz8CL/b31hI YOTtAlElUz/apmRkbMM7Hq4IRA7QK6Qumj5xaUWalwH818gEjRYot74vhilnPi8788ti 9ySg== X-Gm-Message-State: AC+VfDxWdJnxPLmtHTWYYiII+d2WHvbPmn5BA0D3q1kF0U+o8hTmymfu SWYP4QP5TF/k7LmxcG7CnGk+Jw0KstuV4Rfg6TPpvDuC+mldqDdXBAaYC4J8Hkj6JUghCslQ3aE VtH9N4PDkPPrASJ/mTVEF77XhDkunB94vPf6uCUcnECU= X-Received: by 2002:a0d:d3c5:0:b0:569:770d:c9be with SMTP id v188-20020a0dd3c5000000b00569770dc9bemr12009525ywd.41.1686602445482; Mon, 12 Jun 2023 13:40:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5YAuKjyJv/dyosgPSnG9gP4AwJix4ti1YXmUnmzQLCn8a2Fe9vENV68IYdOSwyVmtTplKXgA== X-Received: by 2002:a0d:d3c5:0:b0:569:770d:c9be with SMTP id v188-20020a0dd3c5000000b00569770dc9bemr12009500ywd.41.1686602445225; Mon, 12 Jun 2023 13:40:45 -0700 (PDT) Received: from halaney-x13s ([2600:1700:1ff0:d0e0::45]) by smtp.gmail.com with ESMTPSA id k190-20020a0dc8c7000000b0056d51c39c1fsm208496ywd.23.2023.06.12.13.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 13:40:44 -0700 (PDT) Date: Mon, 12 Jun 2023 15:40:42 -0500 From: Andrew Halaney To: Bartosz Golaszewski Cc: Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kishon Vijay Abraham I , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Bartosz Golaszewski Subject: Re: [PATCH 13/26] net: stmmac: dwmac-qcom-ethqos: make the rgmii clock optional Message-ID: <20230612204042.litbbv23zdb3u5k7@halaney-x13s> References: <20230612092355.87937-1-brgl@bgdev.pl> <20230612092355.87937-14-brgl@bgdev.pl> MIME-Version: 1.0 In-Reply-To: <20230612092355.87937-14-brgl@bgdev.pl> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230612_134048_632678_25B7843D X-CRM114-Status: GOOD ( 20.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 12, 2023 at 11:23:42AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > On sa8775p there's no RGMII clock so make it optional in the driver. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 3438b6229351..252dca400071 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -663,7 +663,7 @@ static int qcom_ethqos_probe(struct platform_device *pdev) > ethqos->rgmii_config_loopback_en = data->rgmii_config_loopback_en; > ethqos->has_emac3 = data->has_emac3; > > - ethqos->rgmii_clk = devm_clk_get(dev, "rgmii"); > + ethqos->rgmii_clk = devm_clk_get_optional(dev, "rgmii"); This makes it optional for older platforms too, but as far as I know on those platforms it is mandatory. This can be enforced in dt-binding checks, but should we also enforce that in the driver still? Honestly I feel like yes, but there's probably some precedent maintainers follow on this front that I don't know of. > if (IS_ERR(ethqos->rgmii_clk)) { > ret = PTR_ERR(ethqos->rgmii_clk); > goto out_config_dt; > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel