From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF6D6C7EE2E for ; Mon, 12 Jun 2023 16:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qh8LMDSqdJjMbZ2OvGrKcoFYLe4E4CpcgrlwsFagtRM=; b=fXWw36AvvysXbR dbCW4EsoDTBju51WDptZWzwKAsCpEDfNYT9nt4OlwsTzRJEhIlnU+RmXrAq8QjDph38A/4BtdKEfQ 87UNLEyfEEikaryjnYJbfP0iO4hFVucDUEL7uPJiskPLTUOYY9sI9eJikIQPmyQ7yWvjOLDq1FBQ0 gkImEmrUMFUGHjSbiTcjbW8s4C4PL/JwI9SHUwiwGugGyLPla3WhFpVXPXgz1AbWuebg4To6JHg7b jiqXX9XoUIiLbOcvVwdII/OJbL2IbmFYQ9nkcayDi37Qv11/kwvKa3IFg/1urlgZLdYeYtByKgYMA Bn93F1NPgnNo3R68r7+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8kXU-004e4f-2W; Mon, 12 Jun 2023 16:37:08 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8kXS-004e44-0x; Mon, 12 Jun 2023 16:37:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CF8FB6247B; Mon, 12 Jun 2023 16:37:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE4A6C433EF; Mon, 12 Jun 2023 16:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686587825; bh=tVyrfzsCwApI/MUrmD7XF9CxwLI7I10+d8agdZfnyt0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jQ7MyhaIv2iiaDMMPE5S1/B09zcu2u2qCB5PjHn0KMt7W/ZHcn4tUyV+kFBo87mke 2YeX3oeNXvfh7OH8nLSN+YXOxZwF+Q3hqSdoMc26s1zscg047Sm5XkGGl5oLyvfs13 s/CYn5dsD1/1lXZI3QuWJ+hqsXKG2yGm6KR9jvMI= Date: Mon, 12 Jun 2023 18:37:02 +0200 From: Greg Kroah-Hartman To: "jim.tsai" Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Matthias Brugger , AngeloGioacchino Del Regno , wsd_upstream@mediatek.com, mel.lee@mediatek.com, ivan.tseng@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions Message-ID: <2023061226-repugnant-upstate-a2b4@gregkh> References: <20230612151545.17810-1-Wei-chin.Tsai@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230612151545.17810-1-Wei-chin.Tsai@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230612_093706_374391_2C2234C9 X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 12, 2023 at 11:15:41PM +0800, jim.tsai wrote: > +static void class_create_release(struct class *cls) > +{ > + /*do nothing because the mbraink class is not from malloc*/ > +} Then the code is totally broken and wrong :( Please just use the misc device api instead, it is much simpler and doesn't have these types of errors. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel