From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2963FEB64D0 for ; Tue, 13 Jun 2023 18:16:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XVYejgm9EckysXXHsoJffaHqZlynxAoJG42ww9iBDJU=; b=ISR3FBJgn9wyjBHTtyhnxY1bl4 dkjn6MSP5JBY6Y7nSDSfkeqR2BLadi1JkSi1sxZ90i9CPMb6vI3/MSf26zBSPSxr0FFGegd7oRvo0 HCkTMIx6aKoC9sd5S8sX8zNpS+DAkuCdYxuudqAbSeeJxTGxlKXaF1rnXX6hPk76JmAvqXjXhnUA4 9sNq/cRwQ+jil2yMx0jV3k4LMGcOnZW/kgEB7Z7m/1mNey180bSoFx5I2W5l3R/fascySS7MDw0ID VEkY9h7AVZMjNVXNgUaV23kEZiWX3qAt8d3v3v9HYt/cFkU6tJhBxRZ9UUS+QQJEm8eOfbTNj1Pog n0VagfkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q98Z2-008p2a-0y; Tue, 13 Jun 2023 18:16:20 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q98Yx-008p1Z-0K for linux-arm-kernel@lists.infradead.org; Tue, 13 Jun 2023 18:16:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 048186395C; Tue, 13 Jun 2023 18:16:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22B2FC433D9; Tue, 13 Jun 2023 18:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686680173; bh=3nta5h6vskHXP6e963+cgsjeVqvnWSz8FUDMtyHszeQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KZdjtdg681LkZlBV7iFB/NhtWhAMuqITDTNRQi77W2BPa6bg1tPBeFiTxFyWlF46E wIYEd39GRCYxSweANY3G68LRRkBPwubGORUWW+zj6gPTQDvbICIQ7kmyegmFZFwY3J fCBU/ty9NQsoVYzjmUzQi0UYgSFWIxdPE5j6FXl+QIhiXWN8zBhdEKlx2hylIsImJr cudRsJ79SvaB3b68gUreZXFcQarSbC5Xuv9YP4sre8xT/9WdwBBPNlhc6RNDelpzvm jgAOU1yOL9739iL2AM2FcsbL9+TmZ8j2eL9/uO09p8Gdfae7VJ+CXjduDK9/wu9xwz xnI9W7uvUA9Qw== Date: Tue, 13 Jun 2023 19:16:06 +0100 From: Conor Dooley To: Manikandan Muralidharan Subject: Re: [PATCH 5/9] drm: atmel-hlcdc: add compatible string check for XLCDC and HLCDC Message-ID: <20230613-unvocal-employed-aff3cf92d60a@spud> References: <20230613070426.467389-1-manikandan.m@microchip.com> <20230613070426.467389-6-manikandan.m@microchip.com> MIME-Version: 1.0 In-Reply-To: <20230613070426.467389-6-manikandan.m@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_111616_817548_CC58704F X-CRM114-Status: GOOD ( 19.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Hari.PrasathGE@microchip.com, krzysztof.kozlowski+dt@linaro.org, Varshini.Rajendran@microchip.com, airlied@gmail.com, sam@ravnborg.org, Balamanikandan.Gunasundar@microchip.com, lee@kernel.org, Dharma.B@microchip.com, Nayabbasha.Sayed@microchip.com, conor+dt@kernel.org, robh+dt@kernel.org, Durai.ManickamKR@microchip.com, linux-arm-kernel@lists.infradead.org, Balakrishnan.S@microchip.com, bbrezillon@kernel.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch, claudiu.beznea@microchip.com Content-Type: multipart/mixed; boundary="===============2909048934247699203==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2909048934247699203== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nLQwW+t8SA8oYufo" Content-Disposition: inline --nLQwW+t8SA8oYufo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 13, 2023 at 12:34:22PM +0530, Manikandan Muralidharan wrote: > From: Durai Manickam KR >=20 > Add compatible string check to differentiate XLCDC and HLCDC code > within the atmel-hlcdc driver files. >=20 > Signed-off-by: Durai Manickam KR > Signed-off-by: Manikandan Muralidharan > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 7 +++++++ > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 1 + > 2 files changed, 8 insertions(+) >=20 > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/d= rm/atmel-hlcdc/atmel_hlcdc_dc.c > index d7ad828e9e8c..fbbd2592efc7 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > @@ -761,6 +761,13 @@ static int atmel_hlcdc_dc_load(struct drm_device *de= v) > if (!dc) > return -ENOMEM; > =20 > + /* SAM9X7 supports XLCDC */ > + if (!strcmp(match->compatible, "microchip,sam9x7-xlcdc")) > + dc->is_xlcdc =3D true; > + else > + /* Other SoC's that supports HLCDC IP */ Should this be "Other SoCs that do not support HLCDC IP"? > + dc->is_xlcdc =3D false; > + > dc->desc =3D match->data; > dc->hlcdc =3D dev_get_drvdata(dev->dev->parent); > dev->dev_private =3D dc; > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h b/drivers/gpu/d= rm/atmel-hlcdc/atmel_hlcdc_dc.h > index aed1742b3665..804e4d476f2b 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > @@ -451,6 +451,7 @@ struct atmel_hlcdc_dc { > u32 imr; > struct drm_atomic_state *state; > } suspend; > + bool is_xlcdc; > }; > =20 > extern struct atmel_hlcdc_formats atmel_hlcdc_plane_rgb_formats; > --=20 > 2.25.1 >=20 --nLQwW+t8SA8oYufo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZIiyZgAKCRB4tDGHoIJi 0uODAP9H+hIVPJhxyu0rBvxNfNf8xPG/zVLhpX+gT6U3ob1cmAEAlAT79psmRyV5 QEhTZmaMUl3xGZF/7M2oLmN1ke+UlwE= =MOtr -----END PGP SIGNATURE----- --nLQwW+t8SA8oYufo-- --===============2909048934247699203== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2909048934247699203==--