From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 206D0C7EE2E for ; Tue, 13 Jun 2023 08:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1EpFHA8AEL/b76XpdXWp0y52xcHKeOdvtj1PIzbZV4I=; b=mZJZ0z2h+KQxts gofBXKOqOi00lYSJQm0ZdoYpK7x6NFtmuDukrUG2bscuhd6meAKlUef/IurhbrC6MygHT1r/x/dx+ 009nf15abWsg+hbm4dGBZkaam4oe/P7t4tMY73OijaDmoASATbXeSCzT8rdQz1B6ejc5Qzl4GZFkW Nd/c/70wPd7sqKAY2Kml2zZz9505yAr65nuXhYc8P836XmiQMiAT/RoeAHemti6ko8IJm7XC+/4bL Rb0xUrstohvKHNT78WzXvhkayjSKFx88rcaSPvxeookIQ0LoezCwn3SaR1IPUIEL7x+W/Qwa/cXpM 9l9NwoCDKPWd7XaZH1tA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8zHI-007M6Q-24; Tue, 13 Jun 2023 08:21:24 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8zHE-007M4l-0r for linux-arm-kernel@lists.infradead.org; Tue, 13 Jun 2023 08:21:22 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-977c72b116fso793540966b.3 for ; Tue, 13 Jun 2023 01:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1686644476; x=1689236476; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8Pvx1ZmU24K4FZvRE8B1LH+FzXYUhn7Zlw9SxVgFETI=; b=WV9KwxgCmwycsJKEZ2A3MVrJnOyEcnrhenIiS1vCorQckKUZbgaHKgCZ7aeeMzogI+ wHn1nD6eLRM9UUV/XH2vwtPs0ck9Hq6L0Z6GxZZK9h3eEBG+oUeQdYRO9rgYmvL3QAoU Z2E9ZR65YbMir/v5Tfy8o759WO6XSZMop80+Rr6gOpNLsO1sJ53OhUjZQ4LZmOVRsjXc 51/PMpMXfp6UJvH09Glowk7+iFXfbr4obL7nBtrgee4Il6UZGqe4wxLxt2YGma2doHLU 8AU7PMahB3SR//5174TShrk9tBKOqjXbxuUW0nFWQAObUIeM21zyUE9mWi+DT5VB0/et G+cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686644476; x=1689236476; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8Pvx1ZmU24K4FZvRE8B1LH+FzXYUhn7Zlw9SxVgFETI=; b=e1bQuW+piz4lRULCGHbqmqZ8mX3+m2+ha9OGvx2rWdT/5sWGTvXQFVDA50uKjlBycW wof99a/gamFNhWGRc/5Ihwlev++NQlYVuUNz/RYhjoTXnVzYCXRPZyaM4bIl9+MR9FcG 78vmd09ugNHMHeNgrUuwDfxdtiqE6UBPB2sB1HwYbOZQOAmy/T46mCtNf/PSQ24Io4nX BwzZgzJF6QrHylv2qmaPFQQGydHTUI0bjg3rztaAl0umqNLIHkEQWI3Hy9whYcXtbkNn 9tdxRYYQ/25tOr7Qv8Nm8wo966qhjJKb/h9js0jk+AcJIVrtODoMiAExENI5zSQMkkcN WrMQ== X-Gm-Message-State: AC+VfDxoefXO2Can6fUzuYWjZMObC/dmO5VlJyQ96Fg3cEDl+iTCA1Ke Tq2wx0KlzyW7CDBess7Sxi4/sw== X-Google-Smtp-Source: ACHHUZ5d/0b4pt5v1YwrkSYa0J18Ko73cwLj+3akehMf5jUxzvy6+qyhbgRNEvBhG9AFf0JQQLHfCw== X-Received: by 2002:a17:907:7249:b0:978:6e73:e841 with SMTP id ds9-20020a170907724900b009786e73e841mr9590037ejc.35.1686644476434; Tue, 13 Jun 2023 01:21:16 -0700 (PDT) Received: from blmsp ([2001:4090:a245:802c:7f03:2fe0:bd27:d746]) by smtp.gmail.com with ESMTPSA id g22-20020a17090613d600b009545230e682sm6329868ejc.91.2023.06.13.01.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 01:21:15 -0700 (PDT) Date: Tue, 13 Jun 2023 10:21:15 +0200 From: Markus Schneider-Pargmann To: Stephen Boyd Cc: AngeloGioacchino Del Regno , Matthias Brugger , Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alexandre Mergnat Subject: Re: [PATCH] clk: mediatek: mt8365: Fix inverted topclk operations Message-ID: <20230613082115.c56ds3btkouetpu6@blmsp> References: <20230511133226.913600-1-msp@baylibre.com> <4e4327afb0c71ae299e6aaaa3dffd4f9.sboyd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4e4327afb0c71ae299e6aaaa3dffd4f9.sboyd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_012120_505213_DEB16934 X-CRM114-Status: GOOD ( 13.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stephen, On Mon, Jun 12, 2023 at 06:13:10PM -0700, Stephen Boyd wrote: > Quoting Markus Schneider-Pargmann (2023-05-11 06:32:26) > > The given operations are inverted for the wrong registers which makes > > multiple of the mt8365 hardware units unusable. In my setup at least usb > > did not work. > > > > Fixed by swapping the operations with the inverted ones. > > > > Reported-by: Alexandre Mergnat > > Checkpatch complains now that there isn't a Closes: tag here. Alexandre reported this internally, so there is nothing I could point to for a Closes tag. > > > Fixes: 905b7430d3cc ("clk: mediatek: mt8365: Convert simple_gate to mtk_gate clocks") > > Signed-off-by: Markus Schneider-Pargmann > > --- > > Applied to clk-fixes Thank you. Best, Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel