From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2821EB64D7 for ; Tue, 13 Jun 2023 14:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NxnhApwD100UcqSJmJdX6kQpjPaE5km1wt2my7fnp30=; b=mMoyKmiY05fvzk Lul+cXuf+6msZ/H9QRcWvkw1t7At+IBg+RUUbjp91o8MG3S+JbTDFW5Byv0s3jxPprNALNm+fHMgp KRVToMQ559qOgHnJ2A9eh9NhiBusXmejYDEtyGtjK5VYDva6e40B1HqrGpZ+INGmcygNOnLQsTPSD g2RrrcRYJ9Iq0DEv40xki5HM/C3LQWmaD80Hq11RJnerb4hML4gE/uuXlaXmmVesEnW6MkG74RJX2 R6Znw7RKXYL/MxTaog/RSaDUIbkw3+vnRQfYCOtbPlikkkp6fw/i2X+xMAoy0b50XZOZyA8mRx40J ackSBTA5kBw6w3sYUbgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q94gt-008H4b-1L; Tue, 13 Jun 2023 14:08:11 +0000 Received: from mx0a-00176a03.pphosted.com ([67.231.149.52]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q94gp-008H3f-0h for linux-arm-kernel@lists.infradead.org; Tue, 13 Jun 2023 14:08:09 +0000 Received: from pps.filterd (m0048275.ppops.net [127.0.0.1]) by m0048275.ppops.net-00176a03. (8.17.1.19/8.17.1.19) with ESMTP id 35D9sUR0038981 for ; Tue, 13 Jun 2023 10:08:05 -0400 Date: Tue, 13 Jun 2023 17:07:55 +0300 From: Ian Ray To: Alexander Stein Cc: Philipp Zabel , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam , Sebastian Reichel , dri-devel@lists.freedesktop.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] drm/imx/ipuv-v3: Fix front porch adjustment upon hactive aligning Message-ID: <20230613140755.GA9128@zoo6.em.health.ge.com> References: <20230503111456.1748511-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230503111456.1748511-1-alexander.stein@ew.tq-group.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: VcHBJ4qWcUyuus1kAXx7erlgdfCxsLd5 X-Proofpoint-ORIG-GUID: VcHBJ4qWcUyuus1kAXx7erlgdfCxsLd5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-13_16,2023-06-12_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 clxscore=1011 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306130124 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_070807_265247_E7744451 X-CRM114-Status: GOOD ( 20.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 03, 2023 at 01:14:56PM +0200, Alexander Stein wrote: > When hactive is not aligned to 8 pixels, it is aligned accordingly and > hfront porch needs to be reduced the same amount. Unfortunately the front > porch is set to the difference rather than reducing it. There are some > Samsung TVs which can't cope with a front porch of instead of 70. > > Fixes: 94dfec48fca7 ("drm/imx: Add 8 pixel alignment fix") > Signed-off-by: Alexander Stein Tested on the same 1366x768 display hardware that required the original fix in commit 94dfec48fca7. Tested-by: Ian Ray > --- > AFAICS ipu_di_adjust_videomode() checks that front porch is big enough to > reduce the alignment difference. > > drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c > index 1d306f7be9fd..341e9125bf2c 100644 > --- a/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c > +++ b/drivers/gpu/drm/imx/ipuv3/ipuv3-crtc.c > @@ -311,7 +311,7 @@ static void ipu_crtc_mode_set_nofb(struct drm_crtc *crtc) > sig_cfg.mode.hactive, new_hactive); > > dev_info(ipu_crtc->dev, "hfront_porch: %u\n", sig_cfg.mode.hfront_porch); > - sig_cfg.mode.hfront_porch = new_hactive - sig_cfg.mode.hactive; > + sig_cfg.mode.hfront_porch -= new_hactive - sig_cfg.mode.hactive; > dev_info(ipu_crtc->dev, "hfront_porch: %u\n", sig_cfg.mode.hfront_porch); > sig_cfg.mode.hactive = new_hactive; > } > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel