From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 299ACEB64D9 for ; Wed, 14 Jun 2023 17:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Arj19Vmsr3yoUCU7Di0h8TXPpUmx68KbNTjRGYe1NX0=; b=HmUUxEeITIF7j6 6JNSfpTqoHpUvQO7zHUfFmQ8xlRwEjRuLXytK4U8c3l/YKaqey9iEEj7DqkTQIAaxTlclB8Hm75XJ P72UqzKmrcCH143OUG1Syiz3scE8pyp1xtjp5qJOrHWwZAsFW0WZ/GT+DiJeLBufvUrRdq8qn13Cb IRUG0oBRHYYuBibhoj1C2+5wEm0SdPWmDOrsFDWhGgHSM9cvm4clEUZVHjwpiqQlXoRyBDAiSmLb+ wf86aSX2P3VRnu2mxx9NZDYWZ5zTxzB3MxKfLegc/1B6QEnTIStBERkrwnzhsoMedaOQzvBrtDsNB 4DVDnjo4xY2yobnNeNJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9UA4-00CKZH-1D; Wed, 14 Jun 2023 17:20:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9UA1-00CKYS-2z; Wed, 14 Jun 2023 17:19:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F3BCC60EDF; Wed, 14 Jun 2023 17:19:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C177C433C8; Wed, 14 Jun 2023 17:19:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686763196; bh=FBPLlXJTl5oVPIOPzrt5kTOhHK/0WZZMZVMLcsH1ZH8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bqiLkMyQonScWxAcXtXXhd1qcoUafJ6eL0nHPu3TUwujOOG4LpGv2rjcQ/FMv593s EsSCAoScxOeGSMMHD3r0PDfR9+anVV1dNoxh9twPpXpF11DtXyva8n7FLHbbnkpJy5 QObKzf/hPoHPr+rEdTZVFyCcilZhx5BniQehCirpuKcBm5kjgQ/aBk1vh18vJ01Z0G gfXyH8HKchL6NXt/5SJLcdaSpj6YHufR1kHDx6K1F/34lxFLKfcPksvz46/UEELH4z DWZGAVdOk7aWP3+lyo/0d/5ENzEBG5/ig3VIIIGIQZk1XPUsZ+RN+er8ucNVV2HRM2 xBlvXCCDubMZA== Date: Wed, 14 Jun 2023 10:19:54 -0700 From: Jakub Kicinski To: Yunsheng Lin Cc: , , , , Lorenzo Bianconi , Alexander Duyck , Yisen Zhuang , Salil Mehta , Eric Dumazet , Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Saeed Mahameed , Leon Romanovsky , Felix Fietkau , Ryder Lee , Shayne Chen , Sean Wang , Kalle Valo , Matthias Brugger , AngeloGioacchino Del Regno , Jesper Dangaard Brouer , Ilias Apalodimas , , , , Subject: Re: [PATCH net-next v4 4/5] page_pool: remove PP_FLAG_PAGE_FRAG flag Message-ID: <20230614101954.30112d6e@kernel.org> In-Reply-To: <20230612130256.4572-5-linyunsheng@huawei.com> References: <20230612130256.4572-1-linyunsheng@huawei.com> <20230612130256.4572-5-linyunsheng@huawei.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_101958_007435_6E0FCD6A X-CRM114-Status: UNSURE ( 9.28 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 12 Jun 2023 21:02:55 +0800 Yunsheng Lin wrote: > struct page_pool_params pp_params = { > - .flags = PP_FLAG_DMA_MAP | PP_FLAG_PAGE_FRAG | > - PP_FLAG_DMA_SYNC_DEV, > + .flags = PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV, > .order = hns3_page_order(ring), Does hns3_page_order() set a good example for the users? static inline unsigned int hns3_page_order(struct hns3_enet_ring *ring) { #if (PAGE_SIZE < 8192) if (ring->buf_size > (PAGE_SIZE / 2)) return 1; #endif return 0; } Why allocate order 1 pages for buffers which would fit in a single page? I feel like this soft of heuristic should be built into the API itself. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel