Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: "Kumar, Udit" <u-kumar1@ti.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Tero Kristo <kristo@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Neha Malcom Francis <n-francis@ti.com>
Subject: Re: [PATCH 6/9] arm64: dts: ti: k3-j721e-beagleboneai64: Add wakeup_uart pinmux
Date: Wed, 14 Jun 2023 07:03:03 -0500	[thread overview]
Message-ID: <20230614120303.5ievpixlpjb3wtdz@elective> (raw)
In-Reply-To: <22b67e80-1f5f-d8e0-3c85-c69d97ea0d39@ti.com>

On 19:26-20230613, Kumar, Udit wrote:
> Hi Nishanth,
> 
> On 6/2/2023 12:01 AM, Nishanth Menon wrote:
> > Define the wakeup uart pin-mux for completeness. This allows the
> > device tree usage in bootloader and firmwares that can configure the
> > same appropriately.
> > 
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> >   arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> > index c13246a9ed8f..bc53ca566a68 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> > @@ -531,6 +531,13 @@ J721E_WKUP_IOPAD(0xfc, PIN_INPUT_PULLUP, 0) /* (H24) WKUP_I2C0_SDA */
> >   		>;
> >   	};
> > +	wkup_uart0_pins_default: wkup-uart0-pins-default {
> > +		pinctrl-single,pins = <
> > +			J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
> > +			J721E_WKUP_IOPAD(0xa4, PIN_OUTPUT, 0) /* (J28) WKUP_UART0_TXD */
> > +		>;
> > +	};
> > +
> >   	mcu_usbss1_pins_default: mcu-usbss1-pins-default {
> >   		pinctrl-single,pins = <
> >   			J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO0_30 */
> > @@ -541,6 +548,8 @@ J721E_WKUP_IOPAD(0x3c, PIN_OUTPUT_PULLUP, 5) /* (A23) MCU_OSPI1_LBCLKO.WKUP_GPIO
> >   &wkup_uart0 {
> >   	/* Wakeup UART is used by TIFS firmware. */
> >   	status = "reserved";
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&wkup_uart0_pins_default>;
> >   };
> 
> 
> If you like to consider alias for wkup_uart0 for this board ,
> 
> Just to align with other boards for this SOC family.  I understand
> wkup_uart0 is not being used.

Vignesh,
could you squash this locally OR if you like, I can post a v2:

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
index 3304460f6a0b..9922d7bb061f 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
@@ -20,6 +20,7 @@ / {
 	model = "BeagleBoard.org BeagleBone AI-64";
 
 	aliases {
+		serial0 = &wkup_uart0;
 		serial2 = &main_uart0;
 		mmc0 = &main_sdhci0;
 		mmc1 = &main_sdhci1;

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-06-14 12:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 18:31 [PATCH 0/9] arm64: dts: ti: k3-j721e-*: Fix up pinmux and aliases Nishanth Menon
2023-06-01 18:31 ` [PATCH 1/9] arm64: dts: ti: k3-j721e-sk: Add missing uart pinmuxes Nishanth Menon
2023-06-01 18:31 ` [PATCH 2/9] arm64: dts: ti: k3-j721e-sk: Enable wakeup_i2c0 and eeprom Nishanth Menon
2023-06-01 18:31 ` [PATCH 3/9] arm64: dts: ti: j721e-som/common-proc-board: Add product links Nishanth Menon
2023-06-01 18:31 ` [PATCH 4/9] arm64: dts: ti: j721e-common-proc-board: Add uart pinmux Nishanth Menon
2023-06-01 18:31 ` [PATCH 5/9] arm64: dts: ti: k3-j721e-som-p0: Enable wakeup_i2c0 and eeprom Nishanth Menon
2023-06-01 18:31 ` [PATCH 6/9] arm64: dts: ti: k3-j721e-beagleboneai64: Add wakeup_uart pinmux Nishanth Menon
2023-06-13 13:56   ` Kumar, Udit
2023-06-14 12:03     ` Nishanth Menon [this message]
2023-06-15 13:38       ` Vignesh Raghavendra
2023-06-01 18:31 ` [PATCH 7/9] arm64: dts: ti: k3-j721e-sk: Define aliases at board level Nishanth Menon
2023-06-01 18:31 ` [PATCH 8/9] arm64: dts: ti: k3-j721e-common-proc-board: " Nishanth Menon
2023-06-01 18:31 ` [PATCH 9/9] arm64: dts: ti: k3-j721e: Drop SoC level aliases Nishanth Menon
2023-06-15 13:39 ` [PATCH 0/9] arm64: dts: ti: k3-j721e-*: Fix up pinmux and aliases Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230614120303.5ievpixlpjb3wtdz@elective \
    --to=nm@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n-francis@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox