From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 877EFEB64D9 for ; Wed, 14 Jun 2023 22:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E/Wpw0q4LGHeYOoKp5gMXkHpzokztyA3x1OBrSc4TRY=; b=BrdcWbkkg0GqaH 35jaP8YfgIu9sxCh+6nDPdwf7DUu4htZK6NBEronZXWVud7hYLd7hTlmi38TQbQmWdqdLbcYXAGOn H4UN8YrziDLmTvqsOh/HlQfezMr1A0aGO5L64GD5rrC0F9+Ur6QHHavUjij6wo3VVtEcD/MquUN23 7iXfCxhkfkimqcqTUUdKRmHFBNmRl/WL2pjoBKNGTzXQHk91iYFgM7NfPTfsYFkIWcYla6vU2yPfr L1mXpLNKn1eLACYR4wfA4o65uryoBk8H3usxTXNhOyu3mLrjY/wFKwrrf+yoa7ouuKTHsPIICOURQ jzcpxb9NR5X96nBSMsQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9Z6d-00CsPG-2U; Wed, 14 Jun 2023 22:36:47 +0000 Received: from mail-io1-f41.google.com ([209.85.166.41]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9Z6b-00CsOg-17 for linux-arm-kernel@lists.infradead.org; Wed, 14 Jun 2023 22:36:46 +0000 Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-777ac169033so5357239f.0 for ; Wed, 14 Jun 2023 15:36:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686782203; x=1689374203; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a8Zf94E7WQ/9wcsLl9Q+QIwfy+59Ul0REJcdYnckuKU=; b=d49DSBIZGN7R1Tq9A5Qebk0kpMtzyYYHOiWHgk7f8Qrr/O5AwdN9LH8K7s7vU6P0LI PzO40Ye/aMO0pKvpDefxg/G1P7jvhNQJ9EUsSmJlNKTXkMZnYTI295KOml2bHKrjTyx+ aPIq2lSZ/cjbJ10zO/UnzBqx0tvrazIWq/7uJLQcSl4BjHWRwyDAuvIYNcr1NNIsstIY aPgUu7bfVHtFdjB3GILfuf261gkPXogawVDOLYS0F7oYYYCBhVeS6S770aqwUvo6oZM9 B50o+FSV2JLKNGTjY1y8VS80ogr4GbBE+eJQn03F43ngPujOUOA+kqPWxV1Y4K80xozZ VtNQ== X-Gm-Message-State: AC+VfDxuhavNPcZUzVNvFiWOnAwsA67a1km5RYYm7njmu9VDjHo/bUkh N6+kZ+uSLCgbIVnv7FP+BA== X-Google-Smtp-Source: ACHHUZ6JU7DCDYGAQ8/JWSyyuSrxrSNxeLDGbGaZcPHrcCorHY6KxNRpZMeRV9tKTmRrIK4JA7KNIg== X-Received: by 2002:a92:d6c8:0:b0:33f:c2f8:e503 with SMTP id z8-20020a92d6c8000000b0033fc2f8e503mr2224864ilp.5.1686782203533; Wed, 14 Jun 2023 15:36:43 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id o27-20020a02c6bb000000b004186badba5esm5136264jan.36.2023.06.14.15.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 15:36:42 -0700 (PDT) Received: (nullmailer pid 2990560 invoked by uid 1000); Wed, 14 Jun 2023 22:36:40 -0000 Date: Wed, 14 Jun 2023 16:36:40 -0600 From: Rob Herring To: Oleksii Moisieiev Cc: "sudeep.holla@arm.com" , Cristian Marussi , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" Subject: Re: [PATCH v3 4/4] dt-bindings: firmware: arm,scmi: Add support for pinctrl protocol Message-ID: <20230614223640.GA2980828-robh@kernel.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_153645_389580_A7C7D806 X-CRM114-Status: GOOD ( 19.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 06, 2023 at 04:22:28PM +0000, Oleksii Moisieiev wrote: > Add new SCMI v3.2 pinctrl protocol bindings definitions and example. > > Signed-off-by: Oleksii Moisieiev > --- > .../bindings/firmware/arm,scmi.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 5824c43e9893..a19aa184bbd1 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -233,6 +233,39 @@ properties: > reg: > const: 0x18 > > + protocol@19: > + $ref: '#/$defs/protocol-node' unevaluatedProperties: false > + > + properties: > + reg: > + const: 0x19 > + > + '#pinctrl-cells': > + const: 0 > + > + allOf: > + - $ref: /schemas/pinctrl/pinctrl.yaml# Group this and the '#/$defs/protocol-node' $ref under allOf. > + > + required: > + - reg > + > + additionalProperties: > + anyOf: Don't need anyOf with only 1 entry. But the use of additionalProperties is usually for existing cases where the pin config nodes had no naming convention. For new bindings, define a node name pattern (under patternProperties). I'd suggest '-pins$' as used elsewhere. > + - type: object > + allOf: > + - $ref: /schemas/pinctrl/pincfg-node.yaml# > + - $ref: /schemas/pinctrl/pinmux-node.yaml# > + > + description: > + A pin multiplexing sub-node describe how to configure a > + set of pins is some desired function. > + A single sub-node may define several pin configurations. > + This sub-node is using default pinctrl bindings to configure > + pin multiplexing and using SCMI protocol to apply specified > + configuration using SCMI protocol. > + > + unevaluatedProperties: false > + > additionalProperties: false > > $defs: > @@ -384,6 +417,26 @@ examples: > scmi_powercap: protocol@18 { > reg = <0x18>; > }; > + > + scmi_pinctrl: protocol@19 { > + reg = <0x19>; > + #pinctrl-cells = <0>; > + > + i2c2 { > + groups = "i2c2_a", "i2c2_b"; > + function = "i2c2"; > + }; > + > + pins_mdio { > + groups = "avb_mdio"; > + drive-strength = <24>; > + }; > + > + keys_pins: keys { > + pins = "GP_5_17", "GP_5_20", "GP_5_22", "GP_2_1"; > + bias-pull-up; > + }; > + }; > }; > }; > > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel