From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EF5FEB64D9 for ; Wed, 14 Jun 2023 18:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+s0/O488zfV+BcCqw+6w05wd4eNhIuLM9EL+bkmdwII=; b=2ZBxuJVUMLZjMK o3nQYrpC2unlSRhMC8T8CPEFiN+Y6qqP5kuQ0YSRBN8Oa5QeK7tH7KPvoAsUPXuyiR/QUZLwHw9PE VCjsIP0p5untxPZnvMM7VHikF0NfVmU+qyHsSApnioJpba5shfYWMpMMjSkhqW4Gcu6mJ7mX0jcM+ LPF1rDCaD09RISYQj3IdA3wv8DhFJDEpASfS+OIdupbPgAh+9rlrortMhG+LcMxyYnaYzEhA/3mYu hYl6VsR1S5geWMeawvSccKVjxgnjh8DsEUIlfNClA/i2be45S+fxLCE68zHBBCG9UvUdscG876RzE sFwG6vVmwryyNuObSLAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9VOF-00CSDB-1Z; Wed, 14 Jun 2023 18:38:43 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9VOB-00CSC9-2c for linux-arm-kernel@lists.infradead.org; Wed, 14 Jun 2023 18:38:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686767919; x=1718303919; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3sI4YDTtaY0g0URvNJ8Dd8m8uuHedTrH+fP517EWAwI=; b=XM7TDcyj2rNCdBcCZ1kQv6krQdmPwssMfiUssznEi1tIJJsn+ts7Y4Vk CLOh5vdQGWanGdf/dlTmfpoUHGWiq0bHFOWSUxD+sP1t5GNGxm49jUz1S ulgFSfS2Gqw+zOo4DCJuoE1wwSBNyhvsdym1qYG9kp4nzAY+39qUjwpZh 8xIb/hgCn83FCVdC7ZMYWPiTwv7wiqM4cLq22/uSizdLwZ7OzHNfg+8xP bIcVRP0f5rXWnqLGKmk1sR+7LHds3IfLeesRKcdINfINjta1gW0xcssxJ lFpZQixVAJLYs0U8UO2D+m7o9kA77iOywsDPvYKNwUQBC07gGRu5ttbG9 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="356195130" X-IronPort-AV: E=Sophos;i="6.00,243,1681196400"; d="scan'208";a="356195130" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2023 11:38:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="745184234" X-IronPort-AV: E=Sophos;i="6.00,243,1681196400"; d="scan'208";a="745184234" Received: from lkp-server02.sh.intel.com (HELO d59cacf64e9e) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 14 Jun 2023 11:38:24 -0700 Received: from kbuild by d59cacf64e9e with local (Exim 4.96) (envelope-from ) id 1q9VNv-0000xK-1R; Wed, 14 Jun 2023 18:38:23 +0000 Date: Thu, 15 Jun 2023 02:38:07 +0800 From: kernel test robot To: Jisheng Zhang , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 3/3] net: stmmac: use pcpu statistics where necessary Message-ID: <202306150255.k4BaJTXY-lkp@intel.com> References: <20230614161847.4071-4-jszhang@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230614161847.4071-4-jszhang@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_113839_862998_9E3815CE X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jisheng, kernel test robot noticed the following build warnings: [auto build test WARNING on sunxi/sunxi/for-next] [also build test WARNING on linus/master v6.4-rc6] [cannot apply to next-20230614] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jisheng-Zhang/net-stmmac-don-t-clear-network-statistics-in-ndo_open/20230615-003137 base: https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git sunxi/for-next patch link: https://lore.kernel.org/r/20230614161847.4071-4-jszhang%40kernel.org patch subject: [PATCH 3/3] net: stmmac: use pcpu statistics where necessary config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230615/202306150255.k4BaJTXY-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 12.3.0 reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add sunxi https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git git fetch sunxi sunxi/for-next git checkout sunxi/sunxi/for-next b4 shazam https://lore.kernel.org/r/20230614161847.4071-4-jszhang@kernel.org # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/net/ If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306150255.k4BaJTXY-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c: In function 'stmmac_get_per_qstats': >> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:564:26: warning: 'start' is used uninitialized [-Wuninitialized] 564 | } while (u64_stats_fetch_retry(&stats->syncp, start)); | ^~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:551:22: note: 'start' was declared here 551 | unsigned int start; | ^~~~~ vim +/start +564 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c 546 547 static void stmmac_get_per_qstats(struct stmmac_priv *priv, u64 *data) 548 { 549 u32 tx_cnt = priv->plat->tx_queues_to_use; 550 u32 rx_cnt = priv->plat->rx_queues_to_use; 551 unsigned int start; 552 int q, stat, cpu; 553 char *p; 554 u64 *pos; 555 556 pos = data; 557 for_each_possible_cpu(cpu) { 558 struct stmmac_pcpu_stats *stats, snapshot; 559 560 data = pos; 561 stats = per_cpu_ptr(priv->xstats.pstats, cpu); 562 do { 563 snapshot = *stats; > 564 } while (u64_stats_fetch_retry(&stats->syncp, start)); 565 566 for (q = 0; q < tx_cnt; q++) { 567 p = (char *)&snapshot + offsetof(struct stmmac_pcpu_stats, 568 txq_stats[q].tx_pkt_n); 569 for (stat = 0; stat < STMMAC_TXQ_STATS; stat++) { 570 *data++ = (*(u64 *)p); 571 p += sizeof(u64); 572 } 573 } 574 for (q = 0; q < rx_cnt; q++) { 575 p = (char *)&snapshot + offsetof(struct stmmac_pcpu_stats, 576 rxq_stats[q].rx_pkt_n); 577 for (stat = 0; stat < STMMAC_RXQ_STATS; stat++) { 578 *data++ = (*(u64 *)p); 579 p += sizeof(u64); 580 } 581 } 582 } 583 } 584 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel