From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52B51EB64D8 for ; Fri, 16 Jun 2023 08:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z8uG+242tmr61Rvd+PPX2c2Dtmf9XUw6UFp1X7Wqiuw=; b=kavLeF5uTAUOvY S7SjVyb30bzNo80h4R5TtqkAPU/rAFfKUihfgrEOaqbSBZMqWgLtsXbBk44Eltzgfs50AadopVJqy Rq4pLYi/nnX4rOTxWidFrr8aKr+dLutqzdrWxjojG+waIVWD8iDcAJw1OPavgu3D0vF9JMKcdqeeZ uLPygQUDHi7fibUU0OqglBTRrplP21rdzvg2Yvs2ZYq7msWWLgBaTR+VH92NwVbIMQXJIw9GT1VnF BbOEbKy3TOLPiSj1Dsa1UkczKjbBoNwWJSP+o830bzcaDlfDRrlSSCGs9dTMZJCC+U2GUTWvopxkK rJenaXxFY8ZyGnFZg/Xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA53c-00HJ7g-29; Fri, 16 Jun 2023 08:43:48 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA53a-00HJ5g-00 for linux-arm-kernel@lists.infradead.org; Fri, 16 Jun 2023 08:43:47 +0000 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-51a3f911135so224137a12.2 for ; Fri, 16 Jun 2023 01:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1686905024; x=1689497024; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=x4uTs7FnJFXFKLzC/P4qYa/B1cEUkKIPyzVP/HrU79w=; b=Vd+/fffm1Uc8+qGgYcYHzDB2xIqMW5bL4ViQV8/368o6TiCAFco68clq30DTFuymu6 LXtkPZW8X705V85I/4+vh/080wgkXWz/DEguJe6ewmXdukW2zpURCO3cLSbO3/WgDCq9 ovt3WcQvTbajSUE+z0Wfm/8lCiH8hM35TCEu2/9Y8L11KEyVuHAo9r59Ugt9bivmTe7k DvNwaqjjiJjDp3Ie19Shk7me32pGoWYXKHnkWfVI3eSBUOKXnd5xROfO57MAikISuguy 8+h6knuri0btoFT/M4HF44VgICvdNtLXBmT5qzYlX+aCSN8GRQwvw4vUP5qOMrEZiTPl LN2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686905024; x=1689497024; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x4uTs7FnJFXFKLzC/P4qYa/B1cEUkKIPyzVP/HrU79w=; b=cfoenujmDkwp+mekIlWlz6ALvURQU0pnZgaqO4+ccw9xfUspVhmbnlvr5zkNTIXgco QzkryIquLNdpGzsyq7b+2Vx9dgLqiOYDeNH5feM7xHIDP1WtJwj40FFs6z/SluupqHXH UcSgTLkOYI1iEE1eQyIwoNW6MqFojdyl0DYncnuBT+y2weKiLSp2EOelIACPP3E8+zsY gFZF2aBIVwAF9jhFTVzEor04dHlSMPLxQ/J7bySha+5rOKFgm408OEJcJepqze106dC8 AEfNanfZTKPtfIj36Fxj4qHn5GE8w61apNx8ln1lEBLsg3+jttUoajWChE0HJnvZ2HyD sBdw== X-Gm-Message-State: AC+VfDxK3YcDZd1qiszjQbQDn688g7dyK6J7BFJedpoYd3DebYObddt5 /X4N3yKYfJY6iPyATxYfE2g/xA== X-Google-Smtp-Source: ACHHUZ4h5oKJwDdIEew4cO4SDJba08vuXA+fsfymmQgCUsDf2tPbwnu7yYD1mZpP8w3z5/ngP/FaEA== X-Received: by 2002:a17:907:7290:b0:96b:48d2:1997 with SMTP id dt16-20020a170907729000b0096b48d21997mr1218630ejc.65.1686905024280; Fri, 16 Jun 2023 01:43:44 -0700 (PDT) Received: from blmsp ([2001:4090:a245:802c:7f03:2fe0:bd27:d746]) by smtp.gmail.com with ESMTPSA id ot25-20020a170906ccd900b00965f5d778e3sm10387696ejb.120.2023.06.16.01.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 01:43:43 -0700 (PDT) Date: Fri, 16 Jun 2023 10:43:42 +0200 From: Markus Schneider-Pargmann To: AngeloGioacchino Del Regno Cc: sboyd@kernel.org, mturquette@baylibre.com, matthias.bgg@gmail.com, wenst@chromium.org, u.kleine-koenig@pengutronix.de, miles.chen@mediatek.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 2/3] clk: mediatek: clk-mt8173-apmixedsys: Fix return value for of_iomap() error Message-ID: <20230616084342.4liggsixa7a3w32k@blmsp> References: <20230615122051.546985-1-angelogioacchino.delregno@collabora.com> <20230615122051.546985-3-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230615122051.546985-3-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_014346_036742_B0B465E3 X-CRM114-Status: GOOD ( 17.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 15, 2023 at 02:20:50PM +0200, AngeloGioacchino Del Regno wrote: > The of_iomap() function returns NULL in case of error so usage of > PTR_ERR() is wrong! > Change that to return -ENOMEM in case of failure. > > Fixes: 41138fbf876c ("clk: mediatek: mt8173: Migrate to platform driver and common probe") > Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Markus Schneider-Pargmann > --- > drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > index daa2856d1ab7..ba1386e70a24 100644 > --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > @@ -148,7 +148,7 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev) > > base = of_iomap(node, 0); > if (!base) > - return PTR_ERR(base); > + return -ENOMEM; > > clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK); > if (IS_ERR_OR_NULL(clk_data)) > -- > 2.40.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel