From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8023BEB64DC for ; Fri, 16 Jun 2023 08:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kTnl7d6t4tpflpkOI0ahnPgi3lHE4ZtvxRNyUft4rSI=; b=NbISM5jBwTSkla loFm/aI5ZvUYj3gDz+sdx0n/fQtUN7geiTQXOKgurBRK9K7n7epQh19NbQzQ/oXSc0vR36zqfO67I YLeveES3qeclN/d0M98wOtXgp2IDqDCUDICIfGs2O0MTHZ9ygfOnar9XtJ3xXZW0Hc1ou3zgK2/1j InHZspvAzroMbFs8LXQPTgTLUuRjGGZC+G6bW48jdBYPRcIWsCtUdU6T61P7NXI3olcSJZKOEz2MK +tczJMVdUsnXeUSBid7KfqPni0HHxHDbVFcGkW4kIo6alyuchj+sgQLTu17/eGMnjkIWCW1nLZ6Bt ftR132k3KNsev4oI66Eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA5Am-00HKO0-0f; Fri, 16 Jun 2023 08:51:12 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA5Ai-00HKLV-2H for linux-arm-kernel@lists.infradead.org; Fri, 16 Jun 2023 08:51:10 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-51a2de3385fso598587a12.0 for ; Fri, 16 Jun 2023 01:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1686905467; x=1689497467; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q+CFo3A2Oynws7qBN6wqUi/Hm2JvW7rwW8Ek/sxYPrA=; b=xp+d4kWfW2lh8gA77lSwp+QpbjTsV6q8Chpk1g+OOPT7jvm9j0hhEn5/zQyN8BMPaH Dx2bQ5+TGTXAw/zpARqubUyMZgBszWnv4veggKJz9RfWh7RkgQP6mfLwdH6jk0w3AnUs 3436FebMYZiTWzmtGAk+UCTsjzgMUCfYUGOFCLFRxlL3N8H29vn6lUmJgKmSPpmv1BPI hWpK+rEVGqCDPK70jg7+wtLMSqDFdq9Er+wrcBFQ5wnvM4GvL7g8qp/d7uRM3bBwUv+3 5OFS1PCnsw9tf03kxXhrJdcvIPp680F7DvrERMaOiX8RVMKLQxKgSUt/kpOaFHwoObC8 TiRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686905467; x=1689497467; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q+CFo3A2Oynws7qBN6wqUi/Hm2JvW7rwW8Ek/sxYPrA=; b=Ud2ZTRQ0s/Thpn9XJCReuDCBh+27iHPXXDzO/37sjCd5945n6DhkiMaL8/P5xlEQoP A5PpHKvOb+HedYKX/i23QjtEahDBXdiTjjM61LLfgut/qQPWkF8JR/PuXMhpmuxXr400 isWCsGEAk+Byy72IPAAxX1aTTCPPW0HA9dDUYGxtewDHGaw9SzvUUbJGqrJJvOjh4Ugv DaeOSiDsur78SAG32seVjnu7SEGZ/q3KR9ykE18jOKJHnuIiGx2dB2HRQIuZz5YdCzEy NQN+SZV1rgEPCALFR4zTQkQmmD8Oj5SgtvokM0sbogQb/E/u+cRpn+u3u3+H0BWIs2XD b9hQ== X-Gm-Message-State: AC+VfDyZ7/6KvkMcHOkR+U8c5IsXfs5pKg792iaXysie++dMXYEWeHY0 7yEy5f2y68PcLSaXMxtPGFm5qw== X-Google-Smtp-Source: ACHHUZ5s6nb5u3oL/lmxvtKXzM48Gt46GFv/+kYzbWM9jRdu4S9zR7XWN3Sq4RQHkGz+l1oAr9mspw== X-Received: by 2002:aa7:c314:0:b0:516:3261:17d with SMTP id l20-20020aa7c314000000b005163261017dmr723581edq.20.1686905466853; Fri, 16 Jun 2023 01:51:06 -0700 (PDT) Received: from blmsp ([2001:4090:a245:802c:7f03:2fe0:bd27:d746]) by smtp.gmail.com with ESMTPSA id h23-20020a50ed97000000b0051a409e752asm5628edr.17.2023.06.16.01.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 01:51:06 -0700 (PDT) Date: Fri, 16 Jun 2023 10:51:04 +0200 From: Markus Schneider-Pargmann To: AngeloGioacchino Del Regno Cc: sboyd@kernel.org, mturquette@baylibre.com, matthias.bgg@gmail.com, wenst@chromium.org, u.kleine-koenig@pengutronix.de, miles.chen@mediatek.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 3/3] clk: mediatek: clk-mt8173-apmixedsys: Fix iomap not released issue Message-ID: <20230616085104.mjlt63e24ebzslsz@blmsp> References: <20230615122051.546985-1-angelogioacchino.delregno@collabora.com> <20230615122051.546985-4-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230615122051.546985-4-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_015108_747113_90DAB2F1 X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Angelo, On Thu, Jun 15, 2023 at 02:20:51PM +0200, AngeloGioacchino Del Regno wrote: > In case of error after of_ioremap() the resource must be released: > call iounmap() where appropriate to fix that. > > Fixes: 41138fbf876c ("clk: mediatek: mt8173: Migrate to platform driver and common probe") > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > index ba1386e70a24..1bbb21ab1786 100644 > --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > @@ -151,8 +151,10 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev) > return -ENOMEM; > > clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK); > - if (IS_ERR_OR_NULL(clk_data)) > + if (IS_ERR_OR_NULL(clk_data)) { > + iounmap(base); > return -ENOMEM; More of a nitpick, but I would prefer if you would use the same error catching style as the rest of the probe function: if (IS_ERR_OR_NULL(clk_data)) { r = -ENOMEM; goto unmap_io; } ... unmap_io: iounmap(base) return r; Best, Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel