From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6131EB64D7 for ; Fri, 16 Jun 2023 10:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J/cNfjbYJ4+vTfve6fFNiL/BOZICP/tcLmXl1FSxTsc=; b=cL6Kwlk+ZpnOde TN6QBt1cCdgF5K5oLnzLEbG7vBmWlTPBdpzvxyiGoW517c8QN+g0nX+e1uJddqSq1Z0ma1FsgEtkS I/CsMHHTxicFL6vcPLKShvLo1fpzhyWC7eG5NDUuCIXhJ0BFdH1vB/QMfVkrg2Zsbhuj7+o2mVBMX 1jCKjXAgFdGfRWT4q8va9theDLBM6xZNDTygo4UNjHH40tWecdw+b9WDBEPlFskxdU6e6Zny7tKsL 6nkKd8Ic58VHNlYhdR8Tm6ycSmY2hDAw2jSrqiNDiamyH3+S96v0zgeUbpY8aKc+O4f55DWYqVVcz c58sk+e3VMeVxYDxeQkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA6hY-0003FP-28; Fri, 16 Jun 2023 10:29:08 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA6hP-00036r-1F for linux-arm-kernel@lists.infradead.org; Fri, 16 Jun 2023 10:29:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E7E676367C; Fri, 16 Jun 2023 10:28:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0E63C43397; Fri, 16 Jun 2023 10:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686911338; bh=ngZd97GJO9P6sC4jMSqvWLbJfghbLBb2vX/wMBK7D4E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ff9U5pu2CwrOVLPhsrFlqubWn5UH5vYPaCe9LvlX9pbiSBIBXwHanXP1IrjEmIijM MdQFRIOqh5bmpuiESPPCV63MSHR9KFGJhyrdrfLmENwOoob0AGvMbB5iZM3oCmgY6N 9b3llJJHx4Wwm8vJGccVz9geina3ckWqw9WOGxLEADuFsOQyq+MRyfpOJaw3BlkKBr a68DFjdeykAC5nWJpZ9VPa6wpxj86eI7Pi6jSFPb6RO3gOSPi7hB0fBqewZjqETDyz 7mQ0ccpjUKI0CTOFjm+bEUNGl3BoAnnvjBw4X85IQ7kNlsOSr+5J4IMST0OU1oiYAr F+xQEfOKQHDvA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Min Li , Andi Shyti , Inki Dae , Sasha Levin , sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@gmail.com, daniel@ffwll.ch, krzysztof.kozlowski@linaro.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 3/5] drm/exynos: fix race condition UAF in exynos_g2d_exec_ioctl Date: Fri, 16 Jun 2023 06:28:49 -0400 Message-Id: <20230616102852.674366-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616102852.674366-1-sashal@kernel.org> References: <20230616102852.674366-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.318 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_032859_461096_1F81D145 X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Min Li [ Upstream commit 48bfd02569f5db49cc033f259e66d57aa6efc9a3 ] If it is async, runqueue_node is freed in g2d_runqueue_worker on another worker thread. So in extreme cases, if g2d_runqueue_worker runs first, and then executes the following if statement, there will be use-after-free. Signed-off-by: Min Li Reviewed-by: Andi Shyti Signed-off-by: Inki Dae Signed-off-by: Sasha Levin --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 9effe40f5fa5d..ddfcf22a883d5 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c @@ -1387,7 +1387,7 @@ int exynos_g2d_exec_ioctl(struct drm_device *drm_dev, void *data, /* Let the runqueue know that there is work to do. */ queue_work(g2d->g2d_workq, &g2d->runqueue_work); - if (runqueue_node->async) + if (req->async) goto out; wait_for_completion(&runqueue_node->complete); -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel