From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF5E6EB64D7 for ; Fri, 16 Jun 2023 06:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x+J8iALJ4se2clb7ebUyIaZZqShtMtpxYZoAGmAL2lc=; b=DaswrisQhBJHm7 bAOFXHBblsMvOyvU+a14frmhA1c5uIgihloWpnZVvuoXvZlGupgT5Qw3Xh82kC1PMjdRGtokgUboN Yufs+KPdMuirwN4RXn6YfUiNBP5xFsiH5sEuef/69O5Ed3hKJ+5LzTColHNjgCEHMKmjkH8axNmEN VdxPDQTViXUHFHuxGqlrJw9AaG29LdIKRCU9HB/nTFZGnkly1WHgBevz+l3hHMSVBlysPyTRTIXIz KhRRj294Ze0t+jBOMBkoHBLFHeDgDN83X7QQdDpw9SHMGOatNM2RIl8oxEZSMfjGiY/CaP627yl3l 4stbFX3GUCXe3oo7xjtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qA2tW-00H1xT-1H; Fri, 16 Jun 2023 06:25:14 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qA2tT-00H1wO-0n for linux-arm-kernel@lists.infradead.org; Fri, 16 Jun 2023 06:25:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 47CE161FD4; Fri, 16 Jun 2023 06:25:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1446C433C0; Fri, 16 Jun 2023 06:25:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686896709; bh=LDabtgOo2j1S5Mdb6D/SWY6U6r4qBrDWsMZ26M0NjyY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i+ifZNLhBIs0bLQRprA0wJst7xHgayyPBR1CJY+tULNpi8aZw/JEjzeYvNgD22VdX Dz1deQrSGq7EfzE3weZjanbrOx6ifZ9pLEKvk2ab5I9ZVHTFNTg+ZLj0halgMY7agx 6djKIb5AyCnkNVB4hESH4xYSluxo8u9HBkhIfMR8= Date: Fri, 16 Jun 2023 08:25:06 +0200 From: Greg KH To: Alison Wang Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, leoyang.li@nxp.com, xuelin.shi@nxp.com, xiaofeng.ren@nxp.com, feng.guo@nxp.com Subject: Re: [PATCH 1/8] ethosu: Add Arm Ethos-U driver Message-ID: <2023061616-sacrifice-mollusk-737f@gregkh> References: <20230616055913.2360-1-alison.wang@nxp.com> <20230616055913.2360-2-alison.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230616055913.2360-2-alison.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230615_232511_322631_3A48F182 X-CRM114-Status: GOOD ( 20.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 16, 2023 at 01:59:06PM +0800, Alison Wang wrote: > Ethos-U Linux driver is to provide an example of how a rich operating > system like Linux can dispatch inferences to an Arm Cortex-M subsystem, > consisting of an Arm Cortex-M and an Arm Ethos-U NPU. > = > Link: https://git.mlplatform.org/ml/ethos-u/ethos-u-linux-driver-stack.git > Tag: 22.02 What does "Tag:" mean? > = > Signed-off-by: Kristofer Jonsson > Signed-off-by: Per Astrand > Signed-off-by: Jonny Sv=E4rd > Signed-off-by: Lior Dekel > Signed-off-by: Henrik Hoglind > Signed-off-by: Davide Grohmann > Signed-off-by: Alison Wang If this many people signed off on this, it better be correct :) > --- /dev/null > +++ b/drivers/firmware/ethosu/Kconfig > @@ -0,0 +1,24 @@ > +# > +# (C) COPYRIGHT 2020 ARM Limited. All rights reserved. It's not 2020 anymore. > +# > +# This program is free software and is provided to you under the terms o= f the > +# GNU General Public License version 2 as published by the Free Software > +# Foundation, and any use by you of this program is subject to the terms > +# of such GNU licence. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, you can access it online at > +# http://www.gnu.org/licenses/gpl-2.0.html. > +# > +# SPDX-License-Identifier: GPL-2.0-only > +# > + > +config ETHOSU > + tristate "Arm Ethos-U NPU support" > + help > + Arm Ethos-U NPU driver. {sigh} With all of those people, NO ONE ran checkpatch.pl on the thing? I'm stopping here, please go do that, fix up the obvious issues it tells you about (hint, no SPDX line and drop the huge license "boiler plate" texts) And also provide a REAL configuration help text, 4 words for this is just not acceptable, what would you do if you were asked to review this? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel