From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A585EB64D9 for ; Sat, 17 Jun 2023 13:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mMrdoaJyLtz6dspM+zOWQlgYfpaz3mExLjRKaku1sco=; b=ogLcCYbaRa+QGT INwfX6z7fom42j42FL4HaUFXFOqbL7tpzBaQ6pgTFX9udocllZzzzwEroOfxNIuam3DSb/LTm/y79 nTb4HWbm61yX3+9RZGbv3WhA74EFfGq8Rlk4wrIEOwhEbYcuPD/IO7mLPXsehwQkMB/VjRenMaLd0 gnFhbBfYLkQn1EjmrIXVq8+9Si0nyjXxAA5Hw9pGWKbuMZMnORSgN67LUnrFzJZd821a2aoR6688i DC/0eqqIPYJ/kxQRU0uOkJEBpioJ+PhMjyslp80E6VVxvYLP+FXP/z+ZXAeKya2QXMcfBwpraU9+9 KFZJsJ+yDUfSggQvi1Uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qAWIs-003hGo-0I; Sat, 17 Jun 2023 13:49:22 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qAWIo-003hFG-2n; Sat, 17 Jun 2023 13:49:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 10C0861222; Sat, 17 Jun 2023 13:49:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A19BC433C8; Sat, 17 Jun 2023 13:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687009750; bh=504yc8iPPjU8NVzPNBErG7ipfm0t5oxlemyrrJViFX0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tjon9VrmDrWjBjdgLGkvf/8Fb+HKIMLZwjsReYzLHRZ8QGRpVntYczSD/rl+YMHHA Xjwx8Sgg8hmJjCMaC1wi+IgUQRXM0f0anVkTYddzchDDiV68bFQn+H27ye03DP9q2e UUL037fuM7skmcPqT56XRBVi9fzNfIdlyBT/b4LDwD6g+1Hjyr+BA4FA6HDnCupdYw Gkf9895nfE8jlylfQ0Xcop5SqbJDIKJIJOcubgWUe1U9lnaGwGr9mwM7Eo9/vzpMKA btKbwrIEWqNHfwEdpdjr0JjLNTqQ64y1Vtre6qzAtAKmRldzmXGLcMhLLYcPxUE5Fb E5l/44Ln30euQ== Date: Sat, 17 Jun 2023 14:48:55 +0100 From: Jonathan Cameron To: Maksim Kiselev Cc: linux-iio@vger.kernel.org, Andy Shevchenko , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Cristian Ciocaltea , Heiko Stuebner , Cosmin Tanislav , Haibo Chen , Leonard =?UTF-8?B?R8O2aHJz?= , Caleb Connolly , Hugo Villeneuve , Mike Looijmans , ChiYuan Huang , Ramona Bolboaca , Ibrahim Tilki , William Breathitt Gray , Arnd Bergmann , ChiaEn Wu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v7 1/3] iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC Message-ID: <20230617144855.0388c4ff@jic23-huawei> In-Reply-To: <20230615205540.1803975-2-bigunclemax@gmail.com> References: <20230615205540.1803975-1-bigunclemax@gmail.com> <20230615205540.1803975-2-bigunclemax@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230617_064918_984959_1697AE5F X-CRM114-Status: GOOD ( 22.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 15 Jun 2023 23:55:20 +0300 Maksim Kiselev wrote: > The General Purpose ADC (GPADC) can convert the external signal into > a certain proportion of digital value, to realize the measurement of > analog signal, which can be applied to power detection and key detection. > > Theoretically, this ADC can support up to 16 channels. All SoCs below > contain this GPADC IP. The only difference between them is the number > of available channels: > > T113 - 1 channel > D1 - 2 channels > R329 - 4 channels > T507 - 4 channels > > Reviewed-by: Andy Shevchenko > Signed-off-by: Maksim Kiselev > --- > drivers/iio/adc/Kconfig | 10 ++ > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/sun20i-gpadc-iio.c | 276 +++++++++++++++++++++++++++++ > 3 files changed, 287 insertions(+) > create mode 100644 drivers/iio/adc/sun20i-gpadc-iio.c > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index eb2b09ef5d5b..deff7ae704ce 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -1123,6 +1123,16 @@ config SUN4I_GPADC > To compile this driver as a module, choose M here: the module will be > called sun4i-gpadc-iio. > > +config SUN20I_GPADC > + tristate "Support for the Allwinner SoCs GPADC" I applied this and started a build test before noticing that this Kconfig description is very vague and matches the one for the existing 4i driver... The 'Support for the' bit also isn't appropriate for what you see in make menuconfig menu etc. Please come up with something descriptive. Maybe "sun20i and similar SoC GPADC"? Bonus points if you change the text for the 4i at the same time to be more meaningful. I clearly missed that in review a long time ago! It's now too late anyway for the 6.5 cycle, so no particular rush though I can queue this up for build testing whilst waiting for 6.5-rc1 to come along (I'll rebase my tree on that once available) and it will then end up in next etc. Jonathan > + depends on ARCH_SUNXI || COMPILE_TEST > + help > + Say yes here to build support for Allwinner (D1, T113, T507 and R329) > + SoCs GPADC. This ADC provides up to 16 channels. > + > + To compile this driver as a module, choose M here: the module will be > + called sun20i-gpadc-iio. > + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel