Re: [PATCH v7 1/3] iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC

Jonathan Cameron
2023-06-17T13:49:42Z

On Thu, 15 Jun 2023 23:55:20 +0300
Maksim Kiselev <bigunclemax@gmail.com> wrote:

> The General Purpose ADC (GPADC) can convert the external signal into
> a certain proportion of digital value, to realize the measurement of
> analog signal, which can be applied to power detection and key detection.
>
> Theoretically, this ADC can support up to 16 channels. All SoCs below
> contain this GPADC IP. The only difference between them is the number
> of available channels:
>
> T113 - 1 channel
> D1 - 2 channels
> R329 - 4 channels
> T507 - 4 channels
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com>
> ---
> drivers/iio/adc/Kconfig | 10 ++
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/sun20i-gpadc-iio.c | 276 +++++++++++++++++++++++++++++
> 3 files changed, 287 insertions(+)
> create mode 100644 drivers/iio/adc/sun20i-gpadc-iio.c
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index eb2b09ef5d5b..deff7ae704ce 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -1123,6 +1123,16 @@ config SUN4I_GPADC
> To compile this driver as a module, choose M here: the module will be
> called sun4i-gpadc-iio.
>
> +config SUN20I_GPADC
> + tristate "Support for the Allwinner SoCs GPADC"
I applied this and started a build test before noticing that this Kconfig description
is very vague and matches the one for the existing 4i driver...

The 'Support for the' bit also isn't appropriate for what you see in make menuconfig
menu etc. Please come up with something descriptive. Maybe
"sun20i and similar SoC GPADC"?

Bonus points if you change the text for the 4i at the same time to be
more meaningful. I clearly missed that in review a long time ago!

It's now too late anyway for the 6.5 cycle, so no particular rush though
I can queue this up for build testing whilst waiting for 6.5-rc1 to come
along (I'll rebase my tree on that once available) and it will then end up
in next etc.

Jonathan

> + depends on ARCH_SUNXI || COMPILE_TEST
> + help
> + Say yes here to build support for Allwinner (D1, T113, T507 and R329)
> + SoCs GPADC. This ADC provides up to 16 channels.
> +
> + To compile this driver as a module, choose M here: the module will be
> + called sun20i-gpadc-iio.
> +