Re: [PATCH v7 1/3] iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC

Jonathan Cameron
2023-06-17T20:07:40Z

On Sat, 17 Jun 2023 21:52:12 +0300
Maxim Kiselev <bigunclemax@gmail.com> wrote:

> сб, 17 июн. 2023 г. в 16:49, Jonathan Cameron <jic23@kernel.org>:
> >
> > On Thu, 15 Jun 2023 23:55:20 +0300
> > Maksim Kiselev <bigunclemax@gmail.com> wrote:
> >
> > > The General Purpose ADC (GPADC) can convert the external signal into
> > > a certain proportion of digital value, to realize the measurement of
> > > analog signal, which can be applied to power detection and key detection.
> > >
> > > Theoretically, this ADC can support up to 16 channels. All SoCs below
> > > contain this GPADC IP. The only difference between them is the number
> > > of available channels:
> > >
> > > T113 - 1 channel
> > > D1 - 2 channels
> > > R329 - 4 channels
> > > T507 - 4 channels
> > >
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com>
> > > ---
> > > drivers/iio/adc/Kconfig | 10 ++
> > > drivers/iio/adc/Makefile | 1 +
> > > drivers/iio/adc/sun20i-gpadc-iio.c | 276 +++++++++++++++++++++++++++++
> > > 3 files changed, 287 insertions(+)
> > > create mode 100644 drivers/iio/adc/sun20i-gpadc-iio.c
> > >
> > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > > index eb2b09ef5d5b..deff7ae704ce 100644
> > > --- a/drivers/iio/adc/Kconfig
> > > +++ b/drivers/iio/adc/Kconfig
> > > @@ -1123,6 +1123,16 @@ config SUN4I_GPADC
> > > To compile this driver as a module, choose M here: the module will be
> > > called sun4i-gpadc-iio.
> > >
> > > +config SUN20I_GPADC
> > > + tristate "Support for the Allwinner SoCs GPADC"
> > I applied this and started a build test before noticing that this Kconfig description
> > is very vague and matches the one for the existing 4i driver...
>
> Indeed. I must have forgotten to change this line when copying from sun4i...
>
> > The 'Support for the' bit also isn't appropriate for what you see in make menuconfig
> > menu etc. Please come up with something descriptive. Maybe
> > "sun20i and similar SoC GPADC"?
> >
> > Bonus points if you change the text for the 4i at the same time to be
> > more meaningful. I clearly missed that in review a long time ago!
>
> Should I do this in a separate patch?
Yes please.

Thanks,

Jonathan