From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6A39EB64D9 for ; Mon, 19 Jun 2023 20:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AP294uuZauSrdU3M/VlYJdXsUI5BRSH2sLiljOxmQ2w=; b=pTTuaK2hfdR0nJe0KBNX2iks7/ +MY+sHe2+jSUQSk4Dww44hWgIv8CpHKck2X/dbKjUKVJqyvTILPlODn8gbmX4BhulC0FTBh7GKDNf P4TgyIN2MJBwVgeMHJSnYWFH+e3C/aN9hJ25s5qL6FY510z6WdBBW0Vmdu6u0ffWdbTbKhr2+m/lc jwBJSiNjqtYRJ+t8k6PeC5suNWJey7ulblkFXvhIblSOfL9tsV7z4YkvxwTemdPu26JjqmkWPWRCW ZRkUwH8seXp95vU+m57rk1jyqCTzcVaRo/CyHW+aIZrI/A0BPmAVY6VbJ/iTsVztSOYW5RY0XTT1r dbXRMX1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBLTS-009QcJ-02; Mon, 19 Jun 2023 20:27:42 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBLTP-009Qbk-0y for linux-arm-kernel@lists.infradead.org; Mon, 19 Jun 2023 20:27:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D157260EE2; Mon, 19 Jun 2023 20:27:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F16AC433C8; Mon, 19 Jun 2023 20:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687206458; bh=ikHFPDr06oSLXBFI/OiW6d9A5DSqxtEooadoVDaEX/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TSGaWnpLWakQJdHaFna5b4aJDT3EAdt38o+f9na6gzoY71JSTET+bGpFDlbVyfpIc gjqp1gNeJ7SNiuSxGQ9ZhULN8ErTAP1aJ52fscTJBkWOuNAhnAmoo8Y+VNd4iKwmr5 lM7EzdiYw0A4wWq+1md3PaN97a4FkhgtrJ4C+ufS9+0/B/PrYLQS7EhI0kB4nR/w/s SC0KSf6wv0nGdphy4NKZQ8OdBSwVfgSKAnDMvG4g68M6OSMNNPa01wMa3db+3JkivF fvGXTIs3JksYZ2AUJwQmQtMpHVJfRkBQoCQpk+aXftg847kwECX5LGPS1H2/2xuBRy Q3P6JitcbRfAA== Date: Mon, 19 Jun 2023 21:27:33 +0100 From: Conor Dooley To: Kamlesh Gurudasani Cc: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jayesh Choudhary , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional Message-ID: <20230619-trailside-shaft-72b2d6bcf978@spud> References: <20230614-sa3ul-v3-0-2eeb810327a1@ti.com> <20230614-sa3ul-v3-1-2eeb810327a1@ti.com> MIME-Version: 1.0 In-Reply-To: <20230614-sa3ul-v3-1-2eeb810327a1@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230619_132739_376471_FA24F1C6 X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3911481154743330522==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3911481154743330522== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Oun5Qk13m+H67PfU" Content-Disposition: inline --Oun5Qk13m+H67PfU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 19, 2023 at 06:58:47PM +0530, Kamlesh Gurudasani wrote: > Devices specific to compatible ti,am62-sa3ul don't have control over > power of SA3UL from main domain. >=20 > "power-domains" property in crypto node tries to access > the SA3UL power, for which it gets NACK and hence, driver doesn't > probe properly for those particular devices. >=20 > Make "power-domains" property as false for devices with > compatible ti,am62-sa3ul. >=20 > Signed-off-by: Kamlesh Gurudasani > --- > Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 ++++++++++++= +- > 1 file changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Doc= umentation/devicetree/bindings/crypto/ti,sa2ul.yaml > index 77ec8bc70bf7..88c8ee8821d4 100644 > --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml > +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml > @@ -66,10 +66,22 @@ patternProperties: > required: > - compatible > - reg > - - power-domains > - dmas > - dma-names > =20 > +allOf: > + - if: > + properties: > + compatible: > + items: The usual pattern here is s/items/contains/. With that, Reviewed-by: Conor Dooley Cheers, Conor. > + const: ti,am62-sa3ul > + then: > + properties: > + power-domains: false > + else: > + required: > + - power-domains > + > additionalProperties: false > =20 > examples: >=20 > --=20 > 2.34.1 >=20 --Oun5Qk13m+H67PfU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJC6NQAKCRB4tDGHoIJi 0iEYAQD+WDPPfLmPj3pgUhjB/6auvhq2AQ81Cdlt3SKWpv1BxAD+P2XRB9x4Pt8N VMchyEEGi/oeMAYxt2ySl3ft6xKh5Aw= =VLLt -----END PGP SIGNATURE----- --Oun5Qk13m+H67PfU-- --===============3911481154743330522== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3911481154743330522==--