From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0C88EB64D8 for ; Tue, 20 Jun 2023 08:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r9BbKw7Rw+O1L4cLXmhqNGED8IhiCfgIdzI/muczeI8=; b=ZUZq45jfiER+qm +sGCtXHBvXMp7BzYm4VkOtVFA8wL1N0dHWFNYh08YhSYR2gEIaMMBn9IC5rQPnsONeUlGbtG6szX4 nahDwv6Q/Tix1RUyUv0cFr4T6AZ3F+C3noG0XCfsoQBHqq6rUWgAjEm8nJHO7if31w6SSYJ8UZdjC BphcoC7N53/nA8Tc9fKqxLb9Zj3t5dojkUQCyl+cDpz5ZsQBvhxmDbmTh8SicEJCtqGnbQNarH7Ze Ggrkk4igbsdCCT8QyFyW98gZZ0b5nVEH4cmGTSv+V4S5y1ETgqvmlWGSirK+i7Lxuvj5eqvmw5FSN IYmNBiHCFIYP3LYHsfNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBX3Z-00AdGG-23; Tue, 20 Jun 2023 08:49:45 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBX3V-00AdFZ-2K for linux-arm-kernel@lists.infradead.org; Tue, 20 Jun 2023 08:49:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41B3A61055; Tue, 20 Jun 2023 08:49:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C407C433C0; Tue, 20 Jun 2023 08:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687250980; bh=ucG/+ss/pgC/7tMCNrpUOJF6gSvhna+8dtVR7W1ctZw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EEOjgHqfZNWkYSLHPMwCDt4D4JO00O+4WUOtb5ofmnZ/T8WEi7zUFS5NYoqWAOXSn tKCmAKpqKYSh99q3jqJ+ae6X/z+5pXPOUALi+lkUWajeD69Grp0WptTE/UMJSDY1bf 9PGTY1Fj4p7PVO2UvzBRLNZXEh0ZWbLO34he4Rmc= Date: Tue, 20 Jun 2023 10:49:38 +0200 From: Greg Kroah-Hartman To: Tao Zhang Cc: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski , Jinlong Mao , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, andersson@kernel.org Subject: Re: [PATCH v6 09/13] Add nodes for dsb edge control Message-ID: <2023062000-jaws-extortion-f782@gregkh> References: <1687246361-23607-1-git-send-email-quic_taozha@quicinc.com> <1687246361-23607-10-git-send-email-quic_taozha@quicinc.com> <2023062024-sincere-tripod-95dc@gregkh> <3aca4a55-0dc7-b34c-d2c0-111a96c33ec3@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3aca4a55-0dc7-b34c-d2c0-111a96c33ec3@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230620_014941_833909_C5D6A3A6 X-CRM114-Status: GOOD ( 26.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 20, 2023 at 04:31:59PM +0800, Tao Zhang wrote: > > On 6/20/2023 3:37 PM, Greg Kroah-Hartman wrote: > > On Tue, Jun 20, 2023 at 03:32:37PM +0800, Tao Zhang wrote: > > > Add the nodes to set value for DSB edge control and DSB edge > > > control mask. Each DSB subunit TPDM has maximum of n(n<16) EDCR > > > resgisters to configure edge control. DSB edge detection control > > > 00: Rising edge detection > > > 01: Falling edge detection > > > 10: Rising and falling edge detection (toggle detection) > > > And each DSB subunit TPDM has maximum of m(m<8) ECDMR registers to > > > configure mask. Eight 32 bit registers providing DSB interface > > > edge detection mask control. > > > > > > Signed-off-by: Tao Zhang > > > --- > > > .../ABI/testing/sysfs-bus-coresight-devices-tpdm | 32 +++++ > > > drivers/hwtracing/coresight/coresight-tpdm.c | 143 ++++++++++++++++++++- > > > drivers/hwtracing/coresight/coresight-tpdm.h | 22 ++++ > > > 3 files changed, 196 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > > > index 2a82cd0..34189e4a 100644 > > > --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > > > +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > > > @@ -60,3 +60,35 @@ Description: > > > Bit[3] : Set to 0 for low performance mode. > > > Set to 1 for high performance mode. > > > Bit[4:8] : Select byte lane for high performance mode. > > > + > > > +What: /sys/bus/coresight/devices//dsb_edge_ctrl > > > +Date: March 2023 > > > +KernelVersion 6.5 > > > +Contact: Jinlong Mao (QUIC) , Tao Zhang (QUIC) > > > +Description: > > > + Read/Write a set of the edge control registers of the DSB > > > + in TPDM. > > > + > > > + Expected format is the following: > > > + > > sysfs is "one value", not 3. Please never have to parse a sysfs file. > > Do you mean sysfs file can only accept "one value"? Yes. > I see that more than one value are written to the sysfs file > "trigout_attach". Then someone missed that and it needs to be fixed. > > > +static ssize_t dsb_edge_ctrl_show(struct device *dev, > > > + struct device_attribute *attr, > > > + char *buf) > > > +{ > > > + struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent); > > > + ssize_t size = 0; > > > + unsigned long bytes; > > > + int i; > > > + > > > + spin_lock(&drvdata->spinlock); > > > + for (i = 0; i < TPDM_DSB_MAX_EDCR; i++) { > > > + bytes = sysfs_emit_at(buf, size, > > > + "Index:0x%x Val:0x%x\n", i, > > Again, no, one value, no "string" needed to parse anything. > > I also see other sysfs files can be read more than one value in other > drivers. Again, they are broken, please send patches to fix them. > Is this "one value" limitation the usage rule of Linux sysfs system? Yes. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel