Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver

Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver

[kernel test robot]

Hi Yuji,

kernel test robot noticed the following build warnings:

[auto build test WARNING on media-tree/master]
[also build test WARNING on linus/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yuji-Ishikawa/dt-bindings-media-platform-visconti-Add-Toshiba-Visconti-Video-Input-Interface-bindings/20230620-120839
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20230620031111.3776-3-yuji2.ishikawa%40toshiba.co.jp
patch subject: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230620/202306201839.92EOK4H7-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230620/202306201839.92EOK4H7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306201839.92EOK4H7-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/media/platform/toshiba/visconti/viif.c:182:6: warning: no previous prototype for 'visconti_viif_hw_on' [-Wmissing-prototypes]
     182 | void visconti_viif_hw_on(struct viif_device *viif_dev)
         |      ^~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif.c:190:6: warning: no previous prototype for 'visconti_viif_hw_off' [-Wmissing-prototypes]
     190 | void visconti_viif_hw_off(struct viif_device *viif_dev)
         |      ^~~~~~~~~~~~~~~~~~~~
   drivers/media/platform/toshiba/visconti/viif.c: In function 'visconti_viif_probe':
>> drivers/media/platform/toshiba/visconti/viif.c:500:36: warning: variable 'of_id' set but not used [-Wunused-but-set-variable]
     500 |         const struct of_device_id *of_id;
         |                                    ^~~~~
--
>> drivers/media/platform/toshiba/visconti/viif_capture.c:604:6: warning: no previous prototype for 'visconti_viif_capture_switch_buffer' [-Wmissing-prototypes]
     604 | void visconti_viif_capture_switch_buffer(struct cap_dev *cap_dev, u32 status_err,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_capture.c:1325:5: warning: no previous prototype for 'visconti_viif_capture_register_ctrl_handlers' [-Wmissing-prototypes]
    1325 | int visconti_viif_capture_register_ctrl_handlers(struct viif_device *viif_dev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_capture.c:1434:5: warning: no previous prototype for 'visconti_viif_capture_register' [-Wmissing-prototypes]
    1434 | int visconti_viif_capture_register(struct viif_device *viif_dev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_capture.c:1476:6: warning: no previous prototype for 'visconti_viif_capture_unregister' [-Wmissing-prototypes]
    1476 | void visconti_viif_capture_unregister(struct viif_device *viif_dev)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
>> drivers/media/platform/toshiba/visconti/viif_isp.c:243:6: warning: no previous prototype for 'visconti_viif_l2_set_roi_path' [-Wmissing-prototypes]
     243 | void visconti_viif_l2_set_roi_path(struct viif_device *viif_dev)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:254:6: warning: no previous prototype for 'visconti_viif_l2_set_roi' [-Wmissing-prototypes]
     254 | void visconti_viif_l2_set_roi(struct viif_device *viif_dev, const struct viif_l2_roi_config *param)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:699:5: warning: no previous prototype for 'visconti_viif_isp_main_set_unit' [-Wmissing-prototypes]
     699 | int visconti_viif_isp_main_set_unit(struct viif_device *viif_dev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:773:5: warning: no previous prototype for 'visconti_viif_isp_sub_set_unit' [-Wmissing-prototypes]
     773 | int visconti_viif_isp_sub_set_unit(struct viif_device *viif_dev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:1177:6: warning: no previous prototype for 'visconti_viif_isp_set_compose_rect' [-Wmissing-prototypes]
    1177 | void visconti_viif_isp_set_compose_rect(struct viif_device *viif_dev,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:1214:5: warning: no previous prototype for 'visconti_viif_isp_register' [-Wmissing-prototypes]
    1214 | int visconti_viif_isp_register(struct viif_device *viif_dev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/toshiba/visconti/viif_isp.c:1265:6: warning: no previous prototype for 'visconti_viif_isp_unregister' [-Wmissing-prototypes]
    1265 | void visconti_viif_isp_unregister(struct viif_device *viif_dev)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   drivers/media/platform/toshiba/visconti/viif_isp.c:162: warning: Function parameter or member 'viif_dev' not described in 'viif_l2_set_roi_num_2'
   drivers/media/platform/toshiba/visconti/viif_isp.c:192: warning: Function parameter or member 'viif_dev' not described in 'viif_l2_set_roi_num_1'
   drivers/media/platform/toshiba/visconti/viif_isp.c:244: warning: Function parameter or member 'viif_dev' not described in 'visconti_viif_l2_set_roi_path'
   drivers/media/platform/toshiba/visconti/viif_isp.c:255: warning: Function parameter or member 'viif_dev' not described in 'visconti_viif_l2_set_roi'
   drivers/media/platform/toshiba/visconti/viif_isp.c:255: warning: Function parameter or member 'param' not described in 'visconti_viif_l2_set_roi'
>> drivers/media/platform/toshiba/visconti/viif_isp.c:255: warning: expecting prototype for viif_l2_set_roi(). Prototype was for visconti_viif_l2_set_roi() instead
   drivers/media/platform/toshiba/visconti/viif_isp.c:287: warning: duplicate section name 'Return'
   drivers/media/platform/toshiba/visconti/viif_isp.c:290: warning: Function parameter or member 'viif_dev' not described in 'viif_main_set_unit'
>> drivers/media/platform/toshiba/visconti/viif_isp.c:290: warning: expecting prototype for hwd_viif_main_set_unit(). Prototype was for viif_main_set_unit() instead
   drivers/media/platform/toshiba/visconti/viif_isp.c:482: warning: duplicate section name 'Return'
   drivers/media/platform/toshiba/visconti/viif_isp.c:485: warning: Function parameter or member 'viif_dev' not described in 'viif_sub_set_unit'
   drivers/media/platform/toshiba/visconti/viif_isp.c:538: warning: Function parameter or member 'viif_dev' not described in 'viif_mux_start'
   drivers/media/platform/toshiba/visconti/viif_isp.c:568: warning: duplicate section name 'Return'
   drivers/media/platform/toshiba/visconti/viif_isp.c:570: warning: Function parameter or member 'viif_dev' not described in 'viif_mux_stop'


vim +/visconti_viif_hw_on +182 drivers/media/platform/toshiba/visconti/viif.c

   178	
   179	/*=============================================*/
   180	/* handling V4L2 framework */
   181	/*=============================================*/
 > 182	void visconti_viif_hw_on(struct viif_device *viif_dev)
   183	{
   184		/* Disable MPU */
   185		viif_mpu_disable(viif_dev);
   186		/* Enable HWAIF */
   187		viif_hwaif_enable(viif_dev);
   188	}
   189	
 > 190	void visconti_viif_hw_off(struct viif_device *viif_dev)
   191	{
   192		/* Uninitialize HWD driver */
   193	}
   194	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver

[kernel test robot]

Hi Yuji,

kernel test robot noticed the following build errors:

[auto build test ERROR on media-tree/master]
[also build test ERROR on linus/master sailus-media-tree/streams v6.4-rc7 next-20230620]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yuji-Ishikawa/dt-bindings-media-platform-visconti-Add-Toshiba-Visconti-Video-Input-Interface-bindings/20230620-120839
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20230620031111.3776-3-yuji2.ishikawa%40toshiba.co.jp
patch subject: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver
config: x86_64-buildonly-randconfig-r001-20230620 (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd9O-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd9O-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306202006.FUjZfd9O-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from <built-in>:1:
   In file included from ./usr/include/linux/visconti_viif.h:12:
>> usr/include/linux/videodev2.h:2464:20: error: field has incomplete type 'struct timespec'
           struct timespec                 timestamp;
                                           ^
   usr/include/linux/videodev2.h:2464:9: note: forward declaration of 'struct timespec'
           struct timespec                 timestamp;
                  ^
   1 error generated.

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver

[kernel test robot]

Hi Yuji,

kernel test robot noticed the following build errors:

[auto build test ERROR on media-tree/master]
[also build test ERROR on linus/master sailus-media-tree/streams v6.4-rc7 next-20230620]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yuji-Ishikawa/dt-bindings-media-platform-visconti-Add-Toshiba-Visconti-Video-Input-Interface-bindings/20230620-120839
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20230620031111.3776-3-yuji2.ishikawa%40toshiba.co.jp
patch subject: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230620/202306202308.y7ERKbSP-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230620/202306202308.y7ERKbSP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306202308.y7ERKbSP-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from ./usr/include/linux/visconti_viif.h:12,
                    from <command-line>:
>> usr/include/linux/videodev2.h:2464:41: error: field 'timestamp' has incomplete type
    2464 |         struct timespec                 timestamp;
         |                                         ^~~~~~~~~

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver

[yuji2.ishikawa]

> -----Original Message-----
> From: kernel test robot <lkp@intel.com>
> Sent: Wednesday, June 21, 2023 12:44 AM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@toshiba.co.jp>; Hans Verkuil <hverkuil@xs4all.nl>; Sakari
> Ailus <sakari.ailus@iki.fi>; Laurent Pinchart
> <laurent.pinchart@ideasonboard.com>; Mauro Carvalho Chehab
> <mchehab@kernel.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof
> Kozlowski <krzk@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>
> Cc: oe-kbuild-all@lists.linux.dev; linux-media@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti
> Video Input Interface driver
> 
> Hi Yuji,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on media-tree/master] [also build test ERROR on
> linus/master sailus-media-tree/streams v6.4-rc7 next-20230620] [If your patch
> is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:
> https://github.com/intel-lab-lkp/linux/commits/Yuji-Ishikawa/dt-bindings-me
> dia-platform-visconti-Add-Toshiba-Visconti-Video-Input-Interface-bindings/20
> 230620-120839
> base:   git://linuxtv.org/media_tree.git master
> patch link:
> https://lore.kernel.org/r/20230620031111.3776-3-yuji2.ishikawa%40toshiba.co.j
> p
> patch subject: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti
> Video Input Interface driver
> config: i386-allyesconfig
> (https://download.01.org/0day-ci/archive/20230620/202306202308.y7ERKbSP
> -lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce:
> (https://download.01.org/0day-ci/archive/20230620/202306202308.y7ERKbSP
> -lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of the
> same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes:
> | https://lore.kernel.org/oe-kbuild-all/202306202308.y7ERKbSP-lkp@intel.
> | com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from ./usr/include/linux/visconti_viif.h:12,
>                     from <command-line>:
> >> usr/include/linux/videodev2.h:2464:41: error: field 'timestamp' has
> >> incomplete type
>     2464 |         struct timespec                 timestamp;
>          |                                         ^~~~~~~~~
> 
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

I could not reproduce the error with the steps had been specified.

* archived config file didn't compile Visconti VIIF driver (at least, COMPILE_TEST is needed)
* the error message didn't appear even if I add some options to config file.
* Environment:
  * OS: Ubuntu 22.04
  * compiler: 12.1.0 (Ubuntu 12.1.0-2ubuntu1~22.04)

Regards,
Yuji Ishikawa


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver

[yuji2.ishikawa]

> -----Original Message-----
> From: kernel test robot <lkp@intel.com>
> Sent: Tuesday, June 20, 2023 9:58 PM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@toshiba.co.jp>; Hans Verkuil <hverkuil@xs4all.nl>; Sakari
> Ailus <sakari.ailus@iki.fi>; Laurent Pinchart
> <laurent.pinchart@ideasonboard.com>; Mauro Carvalho Chehab
> <mchehab@kernel.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof
> Kozlowski <krzk@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>
> Cc: llvm@lists.linux.dev; oe-kbuild-all@lists.linux.dev;
> linux-media@vger.kernel.org; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti
> Video Input Interface driver
> 
> Hi Yuji,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on media-tree/master] [also build test ERROR on
> linus/master sailus-media-tree/streams v6.4-rc7 next-20230620] [If your patch
> is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:
> https://github.com/intel-lab-lkp/linux/commits/Yuji-Ishikawa/dt-bindings-me
> dia-platform-visconti-Add-Toshiba-Visconti-Video-Input-Interface-bindings/20
> 230620-120839
> base:   git://linuxtv.org/media_tree.git master
> patch link:
> https://lore.kernel.org/r/20230620031111.3776-3-yuji2.ishikawa%40toshiba.co.j
> p
> patch subject: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti
> Video Input Interface driver
> config: x86_64-buildonly-randconfig-r001-20230620
> (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd9O-l
> kp@intel.com/config)
> compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git
> 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
> reproduce:
> (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd9O-l
> kp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of the
> same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes:
> | https://lore.kernel.org/oe-kbuild-all/202306202006.FUjZfd9O-lkp@intel.
> | com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from <built-in>:1:
>    In file included from ./usr/include/linux/visconti_viif.h:12:
> >> usr/include/linux/videodev2.h:2464:20: error: field has incomplete type
> 'struct timespec'
>            struct timespec                 timestamp;
>                                            ^
>    usr/include/linux/videodev2.h:2464:9: note: forward declaration of 'struct
> timespec'
>            struct timespec                 timestamp;
>                   ^
>    1 error generated.
> 
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

I could not reproduce the error with the steps had been specified.

* archived config file didn't compile Visconti VIIF driver (at least, COMPILE_TEST is needed)
* the error message didn't appear even if I add some options to config file.
* Environment:
  * OS: Ubuntu 22.04
  * compiler: Ubuntu clang version 15.07

Regards,
Yuji Ishikawa


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver

[Krzysztof Kozlowski]

On 10/07/2023 02:16, yuji2.ishikawa@toshiba.co.jp wrote:
>> -----Original Message-----
>> From: kernel test robot <lkp@intel.com>
>> Sent: Tuesday, June 20, 2023 9:58 PM
>> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
>> <yuji2.ishikawa@toshiba.co.jp>; Hans Verkuil <hverkuil@xs4all.nl>; Sakari
>> Ailus <sakari.ailus@iki.fi>; Laurent Pinchart
>> <laurent.pinchart@ideasonboard.com>; Mauro Carvalho Chehab
>> <mchehab@kernel.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>> Kozlowski <krzk@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
>> iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
>> <nobuhiro1.iwamatsu@toshiba.co.jp>
>> Cc: llvm@lists.linux.dev; oe-kbuild-all@lists.linux.dev;
>> linux-media@vger.kernel.org; devicetree@vger.kernel.org;
>> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti
>> Video Input Interface driver
>>
>> Hi Yuji,
>>
>> kernel test robot noticed the following build errors:
>>
>> [auto build test ERROR on media-tree/master] [also build test ERROR on
>> linus/master sailus-media-tree/streams v6.4-rc7 next-20230620] [If your patch
>> is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>>
>> url:
>> https://github.com/intel-lab-lkp/linux/commits/Yuji-Ishikawa/dt-bindings-me
>> dia-platform-visconti-Add-Toshiba-Visconti-Video-Input-Interface-bindings/20
>> 230620-120839
>> base:   git://linuxtv.org/media_tree.git master
>> patch link:
>> https://lore.kernel.org/r/20230620031111.3776-3-yuji2.ishikawa%40toshiba.co.j
>> p
>> patch subject: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti
>> Video Input Interface driver
>> config: x86_64-buildonly-randconfig-r001-20230620
>> (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd9O-l
>> kp@intel.com/config)
>> compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git
>> 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
>> reproduce:
>> (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd9O-l
>> kp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of the
>> same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes:
>> | https://lore.kernel.org/oe-kbuild-all/202306202006.FUjZfd9O-lkp@intel.
>> | com/
>>
>> All errors (new ones prefixed by >>):
>>
>>    In file included from <built-in>:1:
>>    In file included from ./usr/include/linux/visconti_viif.h:12:
>>>> usr/include/linux/videodev2.h:2464:20: error: field has incomplete type
>> 'struct timespec'
>>            struct timespec                 timestamp;
>>                                            ^
>>    usr/include/linux/videodev2.h:2464:9: note: forward declaration of 'struct
>> timespec'
>>            struct timespec                 timestamp;
>>                   ^
>>    1 error generated.
>>
>> --
>> 0-DAY CI Kernel Test Service
>> https://github.com/intel/lkp-tests/wiki
> 
> I could not reproduce the error with the steps had been specified.
> 
> * archived config file didn't compile Visconti VIIF driver (at least, COMPILE_TEST is needed)

That's not true. The config has enabled CONFIG_VIDEO_VISCONTI_VIIF, so
your reproduction steps were not correct (e.g. wrong arch, compiler etc).

> * the error message didn't appear even if I add some options to config file.
> * Environment:
>   * OS: Ubuntu 22.04
>   * compiler: Ubuntu clang version 15.07

Different compilers can have have or not have warnings, but it does not
allow to ignore this warning. You can analyze the code even without
reproducing it, if the reproduction is a problem.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver

[yuji2.ishikawa]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Monday, July 10, 2023 3:05 PM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@toshiba.co.jp>; lkp@intel.com; hverkuil@xs4all.nl;
> sakari.ailus@iki.fi; laurent.pinchart@ideasonboard.com; mchehab@kernel.org;
> robh+dt@kernel.org; krzk@kernel.org; conor+dt@kernel.org; iwamatsu
> nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>
> Cc: llvm@lists.linux.dev; oe-kbuild-all@lists.linux.dev;
> linux-media@vger.kernel.org; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti
> Video Input Interface driver
> 
> On 10/07/2023 02:16, yuji2.ishikawa@toshiba.co.jp wrote:
> >> -----Original Message-----
> >> From: kernel test robot <lkp@intel.com>
> >> Sent: Tuesday, June 20, 2023 9:58 PM
> >> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> >> <yuji2.ishikawa@toshiba.co.jp>; Hans Verkuil <hverkuil@xs4all.nl>;
> >> Sakari Ailus <sakari.ailus@iki.fi>; Laurent Pinchart
> >> <laurent.pinchart@ideasonboard.com>; Mauro Carvalho Chehab
> >> <mchehab@kernel.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof
> >> Kozlowski <krzk@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> >> iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
> >> <nobuhiro1.iwamatsu@toshiba.co.jp>
> >> Cc: llvm@lists.linux.dev; oe-kbuild-all@lists.linux.dev;
> >> linux-media@vger.kernel.org; devicetree@vger.kernel.org;
> >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba
> >> Visconti Video Input Interface driver
> >>
> >> Hi Yuji,
> >>
> >> kernel test robot noticed the following build errors:
> >>
> >> [auto build test ERROR on media-tree/master] [also build test ERROR
> >> on linus/master sailus-media-tree/streams v6.4-rc7 next-20230620] [If
> >> your patch is applied to the wrong git tree, kindly drop us a note.
> >> And when submitting patch, we suggest to use '--base' as documented
> >> in https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >>
> >> url:
> >> https://github.com/intel-lab-lkp/linux/commits/Yuji-Ishikawa/dt-bindi
> >> ngs-me
> >> dia-platform-visconti-Add-Toshiba-Visconti-Video-Input-Interface-bind
> >> ings/20
> >> 230620-120839
> >> base:   git://linuxtv.org/media_tree.git master
> >> patch link:
> >> https://lore.kernel.org/r/20230620031111.3776-3-yuji2.ishikawa%40tosh
> >> iba.co.j
> >> p
> >> patch subject: [PATCH v6 2/5] media: platform: visconti: Add Toshiba
> >> Visconti Video Input Interface driver
> >> config: x86_64-buildonly-randconfig-r001-20230620
> >> (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd
> >> 9O-l
> >> kp@intel.com/config)
> >> compiler: clang version 15.0.7
> >> (https://github.com/llvm/llvm-project.git
> >> 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
> >> reproduce:
> >> (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd
> >> 9O-l
> >> kp@intel.com/reproduce)
> >>
> >> If you fix the issue in a separate patch/commit (i.e. not just a new
> >> version of the same patch/commit), kindly add following tags
> >> | Reported-by: kernel test robot <lkp@intel.com>
> >> | Closes:
> >> | https://lore.kernel.org/oe-kbuild-all/202306202006.FUjZfd9O-lkp@intel.
> >> | com/
> >>
> >> All errors (new ones prefixed by >>):
> >>
> >>    In file included from <built-in>:1:
> >>    In file included from ./usr/include/linux/visconti_viif.h:12:
> >>>> usr/include/linux/videodev2.h:2464:20: error: field has incomplete
> >>>> type
> >> 'struct timespec'
> >>            struct timespec                 timestamp;
> >>                                            ^
> >>    usr/include/linux/videodev2.h:2464:9: note: forward declaration of
> >> 'struct timespec'
> >>            struct timespec                 timestamp;
> >>                   ^
> >>    1 error generated.
> >>
> >> --
> >> 0-DAY CI Kernel Test Service
> >> https://github.com/intel/lkp-tests/wiki
> >
> > I could not reproduce the error with the steps had been specified.
> >
> > * archived config file didn't compile Visconti VIIF driver (at least,
> > COMPILE_TEST is needed)
> 
> That's not true. The config has enabled CONFIG_VIDEO_VISCONTI_VIIF, so your
> reproduction steps were not correct (e.g. wrong arch, compiler etc).
> 
> > * the error message didn't appear even if I add some options to config file.
> > * Environment:
> >   * OS: Ubuntu 22.04
> >   * compiler: Ubuntu clang version 15.07
> 
> Different compilers can have have or not have warnings, but it does not allow to
> ignore this warning. You can analyze the code even without reproducing it, if the
> reproduction is a problem.
> 
> Best regards,
> Krzysztof

Thank you for your advice, I finally reproduced the error message.
The message is issued by HDRTEST process (not by CC or AR), therefore, we don't need to set Visconti related options to config.
The fix will be included in v7 patch.

Best regards,
Yuji Ishikawa
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel