From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C9AFEB64D7 for ; Tue, 20 Jun 2023 07:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ra18G/SiOAXx2AzemDMyc1EnnxSbT8T7Ujd28Innljc=; b=OcGFa8i5tmUjvg jZ3VQEHPTU24PVe0mF9k67ZI1ANqHIBoz3gEfGsqy/qJdCzlqt4Y9uTuLdNbtaTc4txwV4yFhYTI2 m+MjKNANPdWUTeT1X6j+r0nQbtmRRZ0x2Pc0Yev+a+4dB5Vk/1hxaF2MUS6VqIbQ4KYEFsfUgpzn2 u6uCo2a72sUD+6steF6HoNFtwcxwV9izXUtrVaQaluDiOJBwWCP4zkNi9dhJl2EACq7M8AAuaK8UW uNSxOCqNjU52EgfKl7juQD4bTYhfPtsXGnrxSiHIjt/FqFyCtec9l43RRrKeOewpG4rwS/WstqCBA Z9Xx4ILXDy3XXh2/gT9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBVvN-00AQ5D-1k; Tue, 20 Jun 2023 07:37:13 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBVvK-00AQ4K-33 for linux-arm-kernel@lists.infradead.org; Tue, 20 Jun 2023 07:37:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7186C61045; Tue, 20 Jun 2023 07:37:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FEA4C433C0; Tue, 20 Jun 2023 07:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687246629; bh=09W61tKwWlctGQWINh4tMSjckfcxDtyjNtx12lfzngk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uu4FHrGbD3PECxtje3Oo3eHwBU8nwJs1ioBlsahiImyJcL4J6e/7rb3G9dqIRXiZr FQ6QeriNFLkSwxtLzgzvdoUhvWS8ap7NQVVQVoTpUWsR4eLAtfFHFTg0E5IzNcgwJx ZkFEcmq2i3aAuQ0Ip4srqjIfEZN/Nvs1iiDoYrmY= Date: Tue, 20 Jun 2023 09:37:07 +0200 From: Greg Kroah-Hartman To: Tao Zhang Cc: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski , Jinlong Mao , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, andersson@kernel.org Subject: Re: [PATCH v6 09/13] Add nodes for dsb edge control Message-ID: <2023062024-sincere-tripod-95dc@gregkh> References: <1687246361-23607-1-git-send-email-quic_taozha@quicinc.com> <1687246361-23607-10-git-send-email-quic_taozha@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1687246361-23607-10-git-send-email-quic_taozha@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230620_003711_070947_05EA3D4F X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 20, 2023 at 03:32:37PM +0800, Tao Zhang wrote: > Add the nodes to set value for DSB edge control and DSB edge > control mask. Each DSB subunit TPDM has maximum of n(n<16) EDCR > resgisters to configure edge control. DSB edge detection control > 00: Rising edge detection > 01: Falling edge detection > 10: Rising and falling edge detection (toggle detection) > And each DSB subunit TPDM has maximum of m(m<8) ECDMR registers to > configure mask. Eight 32 bit registers providing DSB interface > edge detection mask control. > > Signed-off-by: Tao Zhang > --- > .../ABI/testing/sysfs-bus-coresight-devices-tpdm | 32 +++++ > drivers/hwtracing/coresight/coresight-tpdm.c | 143 ++++++++++++++++++++- > drivers/hwtracing/coresight/coresight-tpdm.h | 22 ++++ > 3 files changed, 196 insertions(+), 1 deletion(-) > > diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > index 2a82cd0..34189e4a 100644 > --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > @@ -60,3 +60,35 @@ Description: > Bit[3] : Set to 0 for low performance mode. > Set to 1 for high performance mode. > Bit[4:8] : Select byte lane for high performance mode. > + > +What: /sys/bus/coresight/devices//dsb_edge_ctrl > +Date: March 2023 > +KernelVersion 6.5 > +Contact: Jinlong Mao (QUIC) , Tao Zhang (QUIC) > +Description: > + Read/Write a set of the edge control registers of the DSB > + in TPDM. > + > + Expected format is the following: > + sysfs is "one value", not 3. Please never have to parse a sysfs file. > +static ssize_t dsb_edge_ctrl_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent); > + ssize_t size = 0; > + unsigned long bytes; > + int i; > + > + spin_lock(&drvdata->spinlock); > + for (i = 0; i < TPDM_DSB_MAX_EDCR; i++) { > + bytes = sysfs_emit_at(buf, size, > + "Index:0x%x Val:0x%x\n", i, Again, no, one value, no "string" needed to parse anything. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel